[LayoutNG] Layer size is different from legacy when multicol |
|||
Issue descriptionHaven't figured out where we computes the size of layers, but it looks like legacy creates for each column while NG creates for the multicol container. ex. -layer at (8,399) size 384x320 backgroundClip at (0,0) size 400x559 clip at (0,0) size 400x559 +layer at (8,399) size 384x320 backgroundClip at (0,0) size 800x559 clip at (0,0) size 800x559 fast/forms/select/menulist-appearance-rtl.html fragmentation/transformed-clip-before-second-column.html images/rendering-broken-block-flow-images.html images/rendering-broken-images.html virtual/gpu-rasterization/images/rendering-broken-block-flow-images.html virtual/gpu-rasterization/images/rendering-broken-images.html
,
Sep 28
Baselines were captured back when we had NG block fragmentation enabled by default.
,
Sep 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/734515a070b6d1263e4f72326e64e4e461bcec19 commit 734515a070b6d1263e4f72326e64e4e461bcec19 Author: Morten Stenshorne <mstensho@chromium.org> Date: Fri Sep 28 15:21:28 2018 [LayoutNG] Remove/update stale test baselines for multicol. This baselines must have been created back when we had NG block fragmentation enabled by default, which apparently generates (or generated) different paint layer sizes for multicol. Just removed NG-specific baselines, and the tests pass. With one exception: fast/forms/select/menulist-appearance-rtl.html still needs an NG-specific baseline, because RTL text run dumps are prefixed with "RTL" in legacy, while it's not in NG. Like this: text run at (26,0) width 52 RTL: [...] vs. text run at (26,0) width 52: [...] There are similar differences further below in the file. There are also some LayoutNGBlockFlow -> LayoutBlockFlow changes under LayoutMenuList, because we've started to force legacy inside form elements since last rebaseline. Bug: 890135 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I0da4e267fc216809c54dea0b3f6c7c4b26225a20 Reviewed-on: https://chromium-review.googlesource.com/1250922 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#595099} [modify] https://crrev.com/734515a070b6d1263e4f72326e64e4e461bcec19/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG [modify] https://crrev.com/734515a070b6d1263e4f72326e64e4e461bcec19/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/forms/select/menulist-appearance-rtl-expected.txt [delete] https://crrev.com/8ea27747b070e8bb15a2e62d1a8b266d37e1e69f/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fragmentation/transformed-clip-before-second-column-expected.txt [delete] https://crrev.com/8ea27747b070e8bb15a2e62d1a8b266d37e1e69f/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/images/rendering-broken-block-flow-images-expected.txt [delete] https://crrev.com/8ea27747b070e8bb15a2e62d1a8b266d37e1e69f/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/images/rendering-broken-images-expected.txt [delete] https://crrev.com/8ea27747b070e8bb15a2e62d1a8b266d37e1e69f/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/virtual/gpu-rasterization/images/rendering-broken-block-flow-images-expected.txt [delete] https://crrev.com/8ea27747b070e8bb15a2e62d1a8b266d37e1e69f/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/virtual/gpu-rasterization/images/rendering-broken-images-expected.txt
,
Sep 28
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Sep 28