New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 890134 link

Starred by 1 user
Status: Fixed
Owner:
shend@chromium.org
Closed: Oct 3
Cc:
omrilio@chromium.org
█ blakeo@chromium.org
yhanada@chromium.org
pcovell@chromium.org
█ dvallet@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Gesture editing is not implemented for new UI.

Project Member Reported by shend@chromium.org, Sep 28 
Chrome Version: 71.0.3560.0
OS: Chrome

What steps will reproduce the problem?
(1) Enable "gesture editing" in keyboard settings

What is the expected result?
I can swipe to move the caret.

What happens instead?
Nothing.

Comment 1 by shend@chromium.org, Sep 28

Owner: shend@chromium.org
Status: Started (was: Untriaged)
We can just disable the feature on C++ side.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/adb6f937fc963d2b1fecd6185c8753ccd76badc4

commit adb6f937fc963d2b1fecd6185c8753ccd76badc4
Author: Darren Shen <shend@chromium.org>
Date: Mon Oct 01 05:14:28 2018

[VK] Disable gesture editing feature in new UI.

Gesture editing is not supported in the new UI. So we should disable
the flag so that it doesn't appear in the keyboard settings page.

Bug:  890134 
Change-Id: I7dc3c6d05bad6e19e8cbfe0a6f89de603f4ddce5
Reviewed-on: https://chromium-review.googlesource.com/1250683
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595384}
[modify] https://crrev.com/adb6f937fc963d2b1fecd6185c8753ccd76badc4/ui/keyboard/keyboard_util.cc

Comment 3 by shend@chromium.org, Oct 1

Labels: Merge-Request-70
Project Member

Comment 4 by sheriffbot@chromium.org, Oct 2

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: We are only 13 days from stable.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by abdulsyed@chromium.org, Oct 2 

Please mark which OS's this is impacting.

Comment 6 by shend@chromium.org, Oct 2

Labels: OS-Chrome
Done

Comment 7 by geo...@google.com, Oct 3 

This is a P3, does this really need to be in M70?

Comment 8 by shend@chromium.org, Oct 3

Labels: -Hotlist-Merge-Review -Merge-Review-70
Status: Fixed (was: Started)
Discussed with PM, let's not merge it into M70. Thanks!
►

Sign in to add a comment