New issue
Advanced search Search tips

Issue 890125 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

video_VideoEncodeAccelerator failed at some board: MidStreamParamSwitchBitrate

Project Member Reported by akahuang@chromium.org, Sep 28

Issue description

Chrome OS Version: R71-11104.0.0
Board: 
- nyan_big, nyan_kitty, nyan_blaze
- peach_pit, peach_pi
- daisy_skate, daisy
- bob

https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/1229818 
In this CL, we added a new test case in the autotest. Those boards failed to switch bitrate from 1.2Mbps to 300kbps.
 
Labels: media-kernel-shortlist
We probably don't have too much control over these:
- nyan_big, nyan_kitty, nyan_blaze - close source userspace implementation from Nvidia,
- peach_pit, peach_pi, daisy_skate, daisy - old Exynos boards, without active support from Samsung anymore.

The above don't run ARC++, so our requirements for them should be much lower, I guess? Perhaps we could white list this test on them?

Bob is a member of the Gru (Rockchip RK3399) family, so we should be seeing the same problems with Kevin and Scarlet too. Is that not the case? For this one, the bitrate control is done by the libv4l plugin, so there is a chance we could fix it.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 3

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 3

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-bob-private/+/8a0cbdd04afdd34322ee1b7e796a78a100dc35c9

commit 8a0cbdd04afdd34322ee1b7e796a78a100dc35c9
Author: Chih-Yu Huang <akahuang@google.com>
Date: Wed Oct 03 03:02:58 2018

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 3

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 4

Labels: merge-merged-release-R70-11021.B
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-kevin-private/+/24966610f81f15f6484840e20c687b9775a57e0f

commit 24966610f81f15f6484840e20c687b9775a57e0f
Author: Chih-Yu Huang <akahuang@google.com>
Date: Thu Oct 04 02:26:51 2018

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 4

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 4

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-bob-private/+/f633b12ff7d50d1567723ca09c1d78655e49287e

commit f633b12ff7d50d1567723ca09c1d78655e49287e
Author: Chih-Yu Huang <akahuang@google.com>
Date: Thu Oct 04 02:26:52 2018

Labels: -Pri-2 Pri-1
Aka. Please whitelist the devices that we'll next fix in the autotest. The email alerts have lots of failures about this. They will hide the new regressions.
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/c2aff028e627285d457c6a038737a082aa38f42d

commit c2aff028e627285d457c6a038737a082aa38f42d
Author: Chih-Yu Huang <akahuang@google.com>
Date: Wed Oct 10 12:19:40 2018

video_VideoEncodeAccelerator: whitelist the device for bitrate switch.

In video_VideoEncodeAccelerator, the bitrate switch test cases are
mainly for ARC++. However, some devices that do not run ARC++ failed
at those test cases. Moreover, we don't have much control over these
devices.

Therefore, we whitelist the boards that should pass the bitrate switch
test in this CL.

BUG= chromium:890125 
TEST=Pass video_VideoEncodeAccelerator autotest on scarlet

Change-Id: I397300586a1dd9e788de2401e4f2b936566f645f
Reviewed-on: https://chromium-review.googlesource.com/1270377
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Chih-Yu Huang <akahuang@chromium.org>
Reviewed-by: Chih-Yu Huang <akahuang@chromium.org>

[modify] https://crrev.com/c2aff028e627285d457c6a038737a082aa38f42d/client/site_tests/video_VideoEncodeAccelerator/video_VideoEncodeAccelerator.py

Turn out the Intel Rambi Bay Trial and Haswell also failed at this case. I will disable them as well
Status: Started (was: Untriaged)
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/edda9fc4e08901b9418bbed4ba89a8f6a3db5cb1

commit edda9fc4e08901b9418bbed4ba89a8f6a3db5cb1
Author: Chih-Yu Huang <akahuang@google.com>
Date: Tue Oct 23 20:01:58 2018

video_VideoEncodeAccelerator: Change the whitelist for bitrate switch.

We didn't notice that Intel Baytrail and Haswell chipsets failed at
bitrate switch test case. We didn't enable ARC++ at them, so we
blacklist these devices.

Also, hana and elm are actually cannot pass the bitrate switch test.
(crbug/725087) We already filtered the test for them. Therefore we
remove hana and elm from the whitelist.

BUG= chromium:890125 
TEST=Pass video_VideoEncodeAccelerator autotest on scarlet

Change-Id: Iebc90fe04ea460a2548432de19f63680941498a6
Reviewed-on: https://chromium-review.googlesource.com/1288329
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Chih-Yu Huang <akahuang@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>

[modify] https://crrev.com/edda9fc4e08901b9418bbed4ba89a8f6a3db5cb1/client/site_tests/video_VideoEncodeAccelerator/video_VideoEncodeAccelerator.py

Status: Verified (was: Started)
All result went green from 11187.0.0. 

Sign in to add a comment