Add resize handler ui affordance |
||||||||||
Issue descriptionAdd icon on ChromeOS to indicate that the window is resizable.
,
Sep 28
,
Sep 28
,
Oct 11
,
Oct 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ccd3669d8798ee2013539723323bfd8d982b36a6 commit ccd3669d8798ee2013539723323bfd8d982b36a6 Author: Tommy Steimel <steimel@chromium.org> Date: Fri Oct 12 03:46:47 2018 [Picture in Picture] Add resize handle for CrOS. This change adds a UI affordance that the window is resizable and draggable on ChromeOS. This adds a ResizeHandleButton made specifically as the affordance. This icon is on the edge of the window that points to the center of the workspace screen. For example, if the window is on the bottom right quadrant, the icon will be on the top left. In the case where the window is on the bottom left quadrant, the icon replaces the close button. The close button is then shifted to the top left corner. Bug: 890113 Change-Id: Iea6b543e4ee5751d8478dc76daa024f5e85292d2 Reviewed-on: https://chromium-review.googlesource.com/c/1275526 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#599090} [modify] https://crrev.com/ccd3669d8798ee2013539723323bfd8d982b36a6/chrome/app/generated_resources.grd [modify] https://crrev.com/ccd3669d8798ee2013539723323bfd8d982b36a6/chrome/app/vector_icons/BUILD.gn [add] https://crrev.com/ccd3669d8798ee2013539723323bfd8d982b36a6/chrome/app/vector_icons/resize_handle.icon [modify] https://crrev.com/ccd3669d8798ee2013539723323bfd8d982b36a6/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc [modify] https://crrev.com/ccd3669d8798ee2013539723323bfd8d982b36a6/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/ccd3669d8798ee2013539723323bfd8d982b36a6/chrome/browser/ui/views/overlay/close_image_button.cc [modify] https://crrev.com/ccd3669d8798ee2013539723323bfd8d982b36a6/chrome/browser/ui/views/overlay/close_image_button.h [modify] https://crrev.com/ccd3669d8798ee2013539723323bfd8d982b36a6/chrome/browser/ui/views/overlay/overlay_window_views.cc [modify] https://crrev.com/ccd3669d8798ee2013539723323bfd8d982b36a6/chrome/browser/ui/views/overlay/overlay_window_views.h [add] https://crrev.com/ccd3669d8798ee2013539723323bfd8d982b36a6/chrome/browser/ui/views/overlay/resize_handle_button.cc [add] https://crrev.com/ccd3669d8798ee2013539723323bfd8d982b36a6/chrome/browser/ui/views/overlay/resize_handle_button.h
,
Oct 12
,
Oct 12
Issue 882719 has been merged into this issue.
,
Oct 14
,
Oct 14
This bug requires manual review: There is .grd file changes and we are only 50 days from stable. Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 16
Has this been tested and verified?
,
Oct 23
Yes. I've verified this on canary 72.0.3582.0
,
Oct 23
Approving merge to M71 Chrome OS.
,
Oct 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a046a1e7f9fb39fd1ec74a0606fddde6064c37d commit 2a046a1e7f9fb39fd1ec74a0606fddde6064c37d Author: Tommy Steimel <steimel@chromium.org> Date: Wed Oct 24 00:10:08 2018 [Picture in Picture] Add resize handle for CrOS. This change adds a UI affordance that the window is resizable and draggable on ChromeOS. This adds a ResizeHandleButton made specifically as the affordance. This icon is on the edge of the window that points to the center of the workspace screen. For example, if the window is on the bottom right quadrant, the icon will be on the top left. In the case where the window is on the bottom left quadrant, the icon replaces the close button. The close button is then shifted to the top left corner. Bug: 890113 Change-Id: Iea6b543e4ee5751d8478dc76daa024f5e85292d2 Reviewed-on: https://chromium-review.googlesource.com/c/1275526 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599090}(cherry picked from commit ccd3669d8798ee2013539723323bfd8d982b36a6) Reviewed-on: https://chromium-review.googlesource.com/c/1297635 Reviewed-by: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#281} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/2a046a1e7f9fb39fd1ec74a0606fddde6064c37d/chrome/app/generated_resources.grd [modify] https://crrev.com/2a046a1e7f9fb39fd1ec74a0606fddde6064c37d/chrome/app/vector_icons/BUILD.gn [add] https://crrev.com/2a046a1e7f9fb39fd1ec74a0606fddde6064c37d/chrome/app/vector_icons/resize_handle.icon [modify] https://crrev.com/2a046a1e7f9fb39fd1ec74a0606fddde6064c37d/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc [modify] https://crrev.com/2a046a1e7f9fb39fd1ec74a0606fddde6064c37d/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/2a046a1e7f9fb39fd1ec74a0606fddde6064c37d/chrome/browser/ui/views/overlay/close_image_button.cc [modify] https://crrev.com/2a046a1e7f9fb39fd1ec74a0606fddde6064c37d/chrome/browser/ui/views/overlay/close_image_button.h [modify] https://crrev.com/2a046a1e7f9fb39fd1ec74a0606fddde6064c37d/chrome/browser/ui/views/overlay/overlay_window_views.cc [modify] https://crrev.com/2a046a1e7f9fb39fd1ec74a0606fddde6064c37d/chrome/browser/ui/views/overlay/overlay_window_views.h [add] https://crrev.com/2a046a1e7f9fb39fd1ec74a0606fddde6064c37d/chrome/browser/ui/views/overlay/resize_handle_button.cc [add] https://crrev.com/2a046a1e7f9fb39fd1ec74a0606fddde6064c37d/chrome/browser/ui/views/overlay/resize_handle_button.h
,
Oct 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a046a1e7f9fb39fd1ec74a0606fddde6064c37d Commit: 2a046a1e7f9fb39fd1ec74a0606fddde6064c37d Author: steimel@chromium.org Commiter: steimel@chromium.org Date: 2018-10-24 00:10:08 +0000 UTC [Picture in Picture] Add resize handle for CrOS. This change adds a UI affordance that the window is resizable and draggable on ChromeOS. This adds a ResizeHandleButton made specifically as the affordance. This icon is on the edge of the window that points to the center of the workspace screen. For example, if the window is on the bottom right quadrant, the icon will be on the top left. In the case where the window is on the bottom left quadrant, the icon replaces the close button. The close button is then shifted to the top left corner. Bug: 890113 Change-Id: Iea6b543e4ee5751d8478dc76daa024f5e85292d2 Reviewed-on: https://chromium-review.googlesource.com/c/1275526 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599090}(cherry picked from commit ccd3669d8798ee2013539723323bfd8d982b36a6) Reviewed-on: https://chromium-review.googlesource.com/c/1297635 Reviewed-by: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#281} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by apaci...@chromium.org
, Sep 28