New issue
Advanced search Search tips

Issue 890113 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 12
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Add resize handler ui affordance

Project Member Reported by apaci...@chromium.org, Sep 28

Issue description

Add icon on ChromeOS to indicate that the window is resizable.
 
Status: Assigned (was: Untriaged)
Status: Started (was: Assigned)
Components: Internals>Media>UI
Owner: steimel@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ccd3669d8798ee2013539723323bfd8d982b36a6

commit ccd3669d8798ee2013539723323bfd8d982b36a6
Author: Tommy Steimel <steimel@chromium.org>
Date: Fri Oct 12 03:46:47 2018

[Picture in Picture] Add resize handle for CrOS.

This change adds a UI affordance that the window is resizable and
draggable on ChromeOS. This adds a ResizeHandleButton made specifically
as the affordance.

This icon is on the edge of the window that points to the center of
the workspace screen. For example, if the window is on the bottom right
quadrant, the icon will be on the top left. In the case where the window
is on the bottom left quadrant, the icon replaces the close button. The
close button is then shifted to the top left corner.

Bug:  890113 
Change-Id: Iea6b543e4ee5751d8478dc76daa024f5e85292d2
Reviewed-on: https://chromium-review.googlesource.com/c/1275526
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599090}
[modify] https://crrev.com/ccd3669d8798ee2013539723323bfd8d982b36a6/chrome/app/generated_resources.grd
[modify] https://crrev.com/ccd3669d8798ee2013539723323bfd8d982b36a6/chrome/app/vector_icons/BUILD.gn
[add] https://crrev.com/ccd3669d8798ee2013539723323bfd8d982b36a6/chrome/app/vector_icons/resize_handle.icon
[modify] https://crrev.com/ccd3669d8798ee2013539723323bfd8d982b36a6/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc
[modify] https://crrev.com/ccd3669d8798ee2013539723323bfd8d982b36a6/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/ccd3669d8798ee2013539723323bfd8d982b36a6/chrome/browser/ui/views/overlay/close_image_button.cc
[modify] https://crrev.com/ccd3669d8798ee2013539723323bfd8d982b36a6/chrome/browser/ui/views/overlay/close_image_button.h
[modify] https://crrev.com/ccd3669d8798ee2013539723323bfd8d982b36a6/chrome/browser/ui/views/overlay/overlay_window_views.cc
[modify] https://crrev.com/ccd3669d8798ee2013539723323bfd8d982b36a6/chrome/browser/ui/views/overlay/overlay_window_views.h
[add] https://crrev.com/ccd3669d8798ee2013539723323bfd8d982b36a6/chrome/browser/ui/views/overlay/resize_handle_button.cc
[add] https://crrev.com/ccd3669d8798ee2013539723323bfd8d982b36a6/chrome/browser/ui/views/overlay/resize_handle_button.h

Status: Fixed (was: Started)
Issue 882719 has been merged into this issue.
Labels: Merge-Request-71
Project Member

Comment 9 by sheriffbot@chromium.org, Oct 14

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: There is .grd file changes and we are only 50 days from stable.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Has this been tested and verified?
Yes. I've verified this on canary 72.0.3582.0
Labels: -Merge-Review-71 Merge-Approved-71
Approving merge to M71 Chrome OS.

Project Member

Comment 13 by bugdroid1@chromium.org, Oct 24

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a046a1e7f9fb39fd1ec74a0606fddde6064c37d

commit 2a046a1e7f9fb39fd1ec74a0606fddde6064c37d
Author: Tommy Steimel <steimel@chromium.org>
Date: Wed Oct 24 00:10:08 2018

[Picture in Picture] Add resize handle for CrOS.

This change adds a UI affordance that the window is resizable and
draggable on ChromeOS. This adds a ResizeHandleButton made specifically
as the affordance.

This icon is on the edge of the window that points to the center of
the workspace screen. For example, if the window is on the bottom right
quadrant, the icon will be on the top left. In the case where the window
is on the bottom left quadrant, the icon replaces the close button. The
close button is then shifted to the top left corner.

Bug:  890113 
Change-Id: Iea6b543e4ee5751d8478dc76daa024f5e85292d2
Reviewed-on: https://chromium-review.googlesource.com/c/1275526
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599090}(cherry picked from commit ccd3669d8798ee2013539723323bfd8d982b36a6)
Reviewed-on: https://chromium-review.googlesource.com/c/1297635
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#281}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/2a046a1e7f9fb39fd1ec74a0606fddde6064c37d/chrome/app/generated_resources.grd
[modify] https://crrev.com/2a046a1e7f9fb39fd1ec74a0606fddde6064c37d/chrome/app/vector_icons/BUILD.gn
[add] https://crrev.com/2a046a1e7f9fb39fd1ec74a0606fddde6064c37d/chrome/app/vector_icons/resize_handle.icon
[modify] https://crrev.com/2a046a1e7f9fb39fd1ec74a0606fddde6064c37d/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc
[modify] https://crrev.com/2a046a1e7f9fb39fd1ec74a0606fddde6064c37d/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/2a046a1e7f9fb39fd1ec74a0606fddde6064c37d/chrome/browser/ui/views/overlay/close_image_button.cc
[modify] https://crrev.com/2a046a1e7f9fb39fd1ec74a0606fddde6064c37d/chrome/browser/ui/views/overlay/close_image_button.h
[modify] https://crrev.com/2a046a1e7f9fb39fd1ec74a0606fddde6064c37d/chrome/browser/ui/views/overlay/overlay_window_views.cc
[modify] https://crrev.com/2a046a1e7f9fb39fd1ec74a0606fddde6064c37d/chrome/browser/ui/views/overlay/overlay_window_views.h
[add] https://crrev.com/2a046a1e7f9fb39fd1ec74a0606fddde6064c37d/chrome/browser/ui/views/overlay/resize_handle_button.cc
[add] https://crrev.com/2a046a1e7f9fb39fd1ec74a0606fddde6064c37d/chrome/browser/ui/views/overlay/resize_handle_button.h

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/2a046a1e7f9fb39fd1ec74a0606fddde6064c37d

Commit: 2a046a1e7f9fb39fd1ec74a0606fddde6064c37d
Author: steimel@chromium.org
Commiter: steimel@chromium.org
Date: 2018-10-24 00:10:08 +0000 UTC

[Picture in Picture] Add resize handle for CrOS.

This change adds a UI affordance that the window is resizable and
draggable on ChromeOS. This adds a ResizeHandleButton made specifically
as the affordance.

This icon is on the edge of the window that points to the center of
the workspace screen. For example, if the window is on the bottom right
quadrant, the icon will be on the top left. In the case where the window
is on the bottom left quadrant, the icon replaces the close button. The
close button is then shifted to the top left corner.

Bug:  890113 
Change-Id: Iea6b543e4ee5751d8478dc76daa024f5e85292d2
Reviewed-on: https://chromium-review.googlesource.com/c/1275526
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599090}(cherry picked from commit ccd3669d8798ee2013539723323bfd8d982b36a6)
Reviewed-on: https://chromium-review.googlesource.com/c/1297635
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#281}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

Sign in to add a comment