New issue
Advanced search Search tips

Issue 890111 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

Labels should NotifyAccessibilityEvent when their text changes

Project Member Reported by katie@chromium.org, Sep 28

Issue description

There have been several bugs discovered where native labels text is changed but those labels do not NotifyAccessibilityEvent, so accessibility services find out-dated text.

 crbug.com/885326 
 crbug.com/876419 
crbug.com/833668

A solution moving forward would be to remove all instances of label_->NotifyAccessibilityEvent and just have Label::SetText call NotifyAccessibilityEvent directly.

The pros are:
* All labels will always stay updated for Accessibility, and all additional undiscovered bugs of this nature will be fixed.
* Developers do not need to remember to to this going forward

The cons are:
* Need to ensure this does not cause any performance issues if NotifyAccessibilityEvent is called by the view or object holding the label, i.e. duplicate calls
* A solution would need to not NotifyAccessibilityEvent when a label is not yet added to a view, per tapted@:  "this has the potential to cause performance regressions when Labels are being created for the first time (there's no point sending out these notifications then)."


Dominic was thinking about making NotifyAccessibilityEvent more light-weight so that it could be called multiple times without impacting performance, which would unblock implementation of this without worrying about the cons above.
 
My comment about how Label could avoid the case Trent is worried about was that Label could probably check IsDrawn() before calling this.
Status: Available (was: Untriaged)
Labels: -Pri-3 Pri-2
This seems to impact users quite a bit so changing priority

Sign in to add a comment