New issue
Advanced search Search tips

Issue 890104 link

Starred by 3 users

Issue metadata

Status: Fixed
Merged: issue 840444
Owner:
Closed: Oct 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

SetCTPolicy not called on platform app NetworkContexts, not called against on network service restart

Project Member Reported by mmenke@chromium.org, Sep 28

Issue description

ProfileImpl::UpdateCTPolicy SetCTPolicy is only called on (non-incognito) profile creation, and only applies settings to the profile's main NetworkContext that one time.

In particular, it doesn't apply the settings on network service restart, or to app NetworkContexts, or to incognito NetworkContext.  Not sure if the last is desired or not, but the others are presumably bugs.

This bug affects production code, not just the case when the network service is enabled.  Not sure the priority of this, or how to test it.
 
The first is a bug, and is related to  Issue 840444 .

The second is not a bug, nor is the latter. That is, UpdateCTPolicy/SetCTPolicy are for Enterprise Policies tied to a specific profile, not for the general browser or apps. In the old code (that is, before https://chromium.googlesource.com/chromium/src/+/9e79cf0ca820c9c83af104df0555550e86ce0048 ), the CTPolicyManager was associated with the TransportSecurityState. Any contexts cloned from the main profile would inherit both the current settings and any future changes. If App Contexts were cloned from the Main Context, then this would propagate settings. I don't know how this works in the S13N world or if this is now handled differently.
Labels: Proj-Servicification
In the new world, there is no concept of "cloning" a NetworkContext, so they aren't inherited by apps.  They were before.  I assume the old behavior is the desired one.
Mergedinto: 840444
Status: Duplicate (was: Untriaged)
Marking this a dupe of  issue 840444  (If we want to hook it up to apps, easy enough to do in the same CL).
Status: Untriaged (was: Duplicate)
Actually, I should unmerge. 840444 is about the NetworkService configuration for CT, this would be about the NetworkContext configuration. I know there's OnNetworkServiceCreated, but what signals exist for a NetworkContext consumer to know to reconfigure a given context (e.g. the ProfileImpl?)
Cc: eroman@chromium.org mattm@chromium.org
There isn't one...Which is why it should be with the code that creates and manages all settings for NetworkContexts (ProfileNetworkContextService).  All NetworkContext state management should go there or SystemNetworkContextManager.
I see. Doug and John did the design for this, I don't feel qualified to sort it out. Hopefully Eric or Matt may have time.
Labels: Proj-Servicification-Stable
Owner: jam@chromium.org
Status: Assigned (was: Untriaged)
I can take a look at this.
Components: Internals>Services>Network
Labels: -Pri-2 OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows Pri-1
Status: Fixed (was: Assigned)

Sign in to add a comment