SetCTPolicy not called on platform app NetworkContexts, not called against on network service restart |
||||||||
Issue descriptionProfileImpl::UpdateCTPolicy SetCTPolicy is only called on (non-incognito) profile creation, and only applies settings to the profile's main NetworkContext that one time. In particular, it doesn't apply the settings on network service restart, or to app NetworkContexts, or to incognito NetworkContext. Not sure if the last is desired or not, but the others are presumably bugs. This bug affects production code, not just the case when the network service is enabled. Not sure the priority of this, or how to test it.
,
Sep 28
,
Sep 28
In the new world, there is no concept of "cloning" a NetworkContext, so they aren't inherited by apps. They were before. I assume the old behavior is the desired one.
,
Sep 28
Marking this a dupe of issue 840444 (If we want to hook it up to apps, easy enough to do in the same CL).
,
Sep 28
Actually, I should unmerge. 840444 is about the NetworkService configuration for CT, this would be about the NetworkContext configuration. I know there's OnNetworkServiceCreated, but what signals exist for a NetworkContext consumer to know to reconfigure a given context (e.g. the ProfileImpl?)
,
Sep 28
,
Sep 28
There isn't one...Which is why it should be with the code that creates and manages all settings for NetworkContexts (ProfileNetworkContextService). All NetworkContext state management should go there or SystemNetworkContextManager.
,
Sep 28
I see. Doug and John did the design for this, I don't feel qualified to sort it out. Hopefully Eric or Matt may have time.
,
Sep 28
I can take a look at this.
,
Sep 28
,
Sep 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/39d0a6717bf35111459d43f40795d412f0d4a553 commit 39d0a6717bf35111459d43f40795d412f0d4a553 Author: John Abd-El-Malek <jam@chromium.org> Date: Fri Sep 28 22:14:05 2018 Fix SetCTPolicy not getting called on network service restart. Bug: 890104 Change-Id: Id2f726cf4a2052080c1f984cb5844f1d084bf1b0 Reviewed-on: https://chromium-review.googlesource.com/1249732 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#595230} [modify] https://crrev.com/39d0a6717bf35111459d43f40795d412f0d4a553/chrome/browser/net/profile_network_context_service.cc [modify] https://crrev.com/39d0a6717bf35111459d43f40795d412f0d4a553/chrome/browser/net/profile_network_context_service.h [modify] https://crrev.com/39d0a6717bf35111459d43f40795d412f0d4a553/chrome/browser/policy/policy_browsertest.cc [modify] https://crrev.com/39d0a6717bf35111459d43f40795d412f0d4a553/chrome/browser/profiles/profile_impl.cc [modify] https://crrev.com/39d0a6717bf35111459d43f40795d412f0d4a553/chrome/browser/profiles/profile_impl.h
,
Oct 2
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by rsleevi@chromium.org
, Sep 28