New issue
Advanced search Search tips

Issue 890092 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 1
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug


Show other hotlists

Hotlists containing this issue:
Modern-Media-Controls


Sign in to add a comment

Media Controls: Volume slider has wrong padding for larger videos

Project Member Reported by steimel@chromium.org, Sep 28

Issue description

Larger videos have a larger button panel, but the volume slider styling doesn't account for it. This needs to be updated
 
Cc: nyerramilli@chromium.org rbasuvula@chromium.org steimel@chromium.org
 Issue 890185  has been merged into this issue.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85757796b22f94e0a25d1998f6bd828e0843e997

commit 85757796b22f94e0a25d1998f6bd828e0843e997
Author: Tommy Steimel <steimel@chromium.org>
Date: Mon Oct 01 22:17:33 2018

[Media Controls] Fix volume slider padding for larger videos

This CL updates the styling for the volume slider for larger videos.

Bug:  890092 
Change-Id: I1b410b7318f10247457c46cadbbb081801e19acf
Reviewed-on: https://chromium-review.googlesource.com/1250206
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595579}
[modify] https://crrev.com/85757796b22f94e0a25d1998f6bd828e0843e997/third_party/blink/renderer/modules/media_controls/resources/modernMediaControls.css

Status: Fixed (was: Started)
Labels: TE-Verified-M71 TE-Verified-71.0.3569.0
Update :
---------
Verified above issue in latest Canary build #71.0.3569.0 on Windows(7, 8, 8.1, 10), Linux(14.04 LTS) and Mac(10.12.6, 10.13.1, 10.14.1, 10.13.6) OS and the issue is fixed. 
Volume slider is now aligned properly with 'Volume' icon and it is working as intended, hence adding TE-Verified labels. Kindly review an attached screen-cast for reference.

Thank you..!
Latest_behavior.mp4
4.1 MB View Download

Sign in to add a comment