Issue metadata
Sign in to add a comment
|
Setup Flow UI right/left margin grow in each successive screen |
||||||||||||||||||||||
Issue descriptionI believe the margin around the main element (i.e. the 'multidevice-setup' element) goes from 0 in the start page, 40px in the password page, and 112px in the success screen. khorimoto thinks it is caused by one of the CLs directed at formatting for tablet mode.
,
Oct 1
Working on another issue right now, so I'm marking as available (this is P1 so if anyone else has bandwidth, they should take it). Glad to take it on later if still open.
,
Oct 1
,
Oct 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5cbcd4751d69ea41b97428ea3fff9710643ecfd7 commit 5cbcd4751d69ea41b97428ea3fff9710643ecfd7 Author: Jordy Greenblatt <jordynass@chromium.org> Date: Tue Oct 02 01:18:37 2018 [CrOS MultiDevice] Fix growing margins bug in setup flow Screenshots from both tablet and standard modes on PixelBook: https://drive.google.com/drive/folders/18lSB22-hWttyVZxNI7ASAE6m1Qvub8vI?usp=sharing Bug: 890088 Change-Id: I9367c87dc85a61b076d0db4ed1997980a308da86 Reviewed-on: https://chromium-review.googlesource.com/1256162 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#595678} [modify] https://crrev.com/5cbcd4751d69ea41b97428ea3fff9710643ecfd7/ui/webui/resources/cr_components/chromeos/multidevice_setup/multidevice_setup.html
,
Oct 2
,
Oct 4
Issue 892283 has been merged into this issue. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by khorimoto@chromium.org
, Sep 28Components: UI>Multidevice
Labels: -Type-Bug Type-Bug-Regression
Status: Assigned (was: Untriaged)