New issue
Advanced search Search tips

Issue 890084 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 4
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: TabCaptureApiPixelTest.OffscreenTabEvilTests



Sign in to add a comment

TabCaptureApiPixelTest.OffscreenTabEvilTests is flaky

Project Member Reported by Findit, Sep 28

Issue description

Labels: -Sheriff-Chromium
Owner: samans@chromium.org
Status: Assigned (was: Untriaged)
Reverted according to Findit's culprit, CL at https://chromium-review.googlesource.com/c/chromium/src/+/1249284

samans@, PTAL.
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2112dbffdd286898c8777fde20ec5451a04fcdea

commit 2112dbffdd286898c8777fde20ec5451a04fcdea
Author: Rakina Zata Amni <rakina@chromium.org>
Date: Fri Sep 28 03:39:36 2018

Revert "Don't update the surface range at every activation"

This reverts commit 5dea8c2f26f49b400fa2c0a507f918a5fe16b622.

Reason for revert: Causes TabCaptureApiPixelTest.OffscreenTabEvilTests is flaky


Original change's description:
> Don't update the surface range at every activation
>
> Updating the fallback lowerbound is not necessary anymore and will just
> waste time by causing an unnecessary commit and draw.
>
> Bug:  870456 
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
> Change-Id: Icd553c179c5a2eb98c1608524d9c1caf42a27835
> Reviewed-on: https://chromium-review.googlesource.com/1226366
> Commit-Queue: Saman Sami <samans@chromium.org>
> Reviewed-by: Khushal <khushalsagar@chromium.org>
> Reviewed-by: Fady Samuel <fsamuel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#594380}

TBR=fsamuel@chromium.org,khushalsagar@chromium.org,samans@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  870456 ,  890084 
Change-Id: Ia3cb2aa4b405f9e9f9c2a282ae0ec7fdc62e8682
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1249284
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594973}
[modify] https://crrev.com/2112dbffdd286898c8777fde20ec5451a04fcdea/components/viz/service/frame_sinks/direct_layer_tree_frame_sink.cc
[modify] https://crrev.com/2112dbffdd286898c8777fde20ec5451a04fcdea/content/browser/renderer_host/delegated_frame_host.cc
[modify] https://crrev.com/2112dbffdd286898c8777fde20ec5451a04fcdea/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/2112dbffdd286898c8777fde20ec5451a04fcdea/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/2112dbffdd286898c8777fde20ec5451a04fcdea/content/browser/renderer_host/render_widget_host_view_mac.mm
[modify] https://crrev.com/2112dbffdd286898c8777fde20ec5451a04fcdea/ui/android/delegated_frame_host_android.cc

Project Member

Comment 3 by Findit, Sep 28

Labels: -Sheriff-Chromium
Looks like this stopped flaking
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af5e170faab6bcf9d0897f65b047da5edc9ec955

commit af5e170faab6bcf9d0897f65b047da5edc9ec955
Author: Saman Sami <samans@chromium.org>
Date: Thu Oct 04 20:22:37 2018

Reland "Don't update the surface range at every activation"

Relands crrev.com/5dea8c2 but also makes SurfaceAggregator take into
account offscreen clients in damage_ranges_.

Updating the fallback lowerbound is not necessary anymore and will just
waste time by causing an unnecessary commit and draw.

TBR=khushalsagar@chromium.org

Bug:  870456 , 890084 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I8eb13587511f072583f8d746e41b93900fa5d695
Reviewed-on: https://chromium-review.googlesource.com/c/1259607
Commit-Queue: Saman Sami <samans@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596828}
[modify] https://crrev.com/af5e170faab6bcf9d0897f65b047da5edc9ec955/components/viz/service/display/surface_aggregator.cc
[modify] https://crrev.com/af5e170faab6bcf9d0897f65b047da5edc9ec955/components/viz/service/display/surface_aggregator_unittest.cc
[modify] https://crrev.com/af5e170faab6bcf9d0897f65b047da5edc9ec955/components/viz/service/frame_sinks/direct_layer_tree_frame_sink.cc
[modify] https://crrev.com/af5e170faab6bcf9d0897f65b047da5edc9ec955/content/browser/renderer_host/delegated_frame_host.cc
[modify] https://crrev.com/af5e170faab6bcf9d0897f65b047da5edc9ec955/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/af5e170faab6bcf9d0897f65b047da5edc9ec955/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/af5e170faab6bcf9d0897f65b047da5edc9ec955/content/browser/renderer_host/render_widget_host_view_mac.mm
[modify] https://crrev.com/af5e170faab6bcf9d0897f65b047da5edc9ec955/ui/android/delegated_frame_host_android.cc

Status: Fixed (was: Assigned)
I relanded my CL with a fix.

Sign in to add a comment