New issue
Advanced search Search tips

Issue 890078 link

Starred by 14 users
Status: Fixed
Owner:
steimel@chromium.org
Closed: Oct 15
Cc:
vamshi.kommuri@chromium.org
mlamouri@chromium.org
steimel@chromium.org
phanindra.mandapaka@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug


Show other hotlists

Hotlists containing this issue:
Modern-Media-Controls


Sign in to add a comment

Media Controls: Remove the overlay play button on desktop

Project Member Reported by steimel@chromium.org, Sep 27 
With the new media controls, we changed from only having the overlay play button on Android to having the overlay play button on both desktop and Android. Given the strong user feedback against having the button on desktop, we want to remove it in favor of a button in the left corner (leaving the button on Android).

Comment 1 by steimel@chromium.org, Sep 28

Summary: Media Controls: Remove the overlay play button on desktop (was: Remove the overlay play button on desktop)

Comment 2 by beccahughes@chromium.org, Oct 1 

This is the associated image with my comment:
Screenshot from 2018-10-01 16-47-36.png
9.6 KB View Download
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53c52480c292f9233154779436ac3b9df3ac4e23

commit 53c52480c292f9233154779436ac3b9df3ac4e23
Author: Tommy Steimel <steimel@chromium.org>
Date: Mon Oct 08 04:50:46 2018

[Media Controls] Remove overlay play button on desktop

This CL updates the media controls on desktop to have the standard
play button in the bottom left corner instead of the overlay play
button in the center.

As part of this change, the play button is given a disabled state
when appropriate, which also applies to the audio player. This fixes
a separate issue where the audio player wasn't giving proper feedback
with a broken source.

Bug:  890078 , 839101
Change-Id: Ifbc8b3c216d3537c657b04ff6fc53506b886c48f
Reviewed-on: https://chromium-review.googlesource.com/c/1252846
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597483}
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/media/controls/modern/doubletap-on-play-button.html
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/media/controls/modern/immersive-mode-adds-css-class.html
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/media/controls/modern/overlay-play-button-tap-to-hide.html
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/media/controls/modern/singletap-on-outside.html
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/media/controls/modern/singletap-on-overlay-closes-overflow-menu.html
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/media/controls/modern/singletap-on-play-button.html
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/media/controls/modern/singletouch-on-play-button.html
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/media/controls/modern/video-does-not-go-fullscreen-on-double-click-before-preload.html
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/media/controls/overlay-play-button-resizes-with-video.html
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/media/controls/tap-on-overlay-play-button-cant-be-preempted.html
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/media/controls/video-enter-exit-fullscreen-while-hovering-shows-controls.html
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/media/controls/video-enter-exit-fullscreen-without-hovering-doesnt-show-controls.html
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/media/media-controls-tap-show-controls-without-activating.html
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/media/media-controls.js
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/media/video-controls-always-visible-when-control-hovered.html
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/media/video-controls-auto-hide-after-play-by-touch.html
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/media/video-controls-hide-after-touch-on-control.html
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/media/video-controls-hide-on-move-outside-controls.html
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/media/video-controls-transformed.html
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/media/video-controls-visibility-multimodal-mouse-after-touch.html
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/media/video-controls-visibility-multimodal-touch-after-mouse.html
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/media/video-controls-zoomed.html
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/media/video-play-require-user-gesture.html
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/paint/invalidation/video-paint-invalidation-expected.txt
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/compositing/video/video-controls-layer-creation-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/fast/overflow/overflow-of-video-outline-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/media/controls-after-reload-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/media/controls-after-reload-expected.txt
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/media/controls-layout-direction-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/media/controls-strict-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/media/controls-strict-expected.txt
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/media/controls-styling-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/media/controls-styling-expected.txt
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/media/controls-styling-strict-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/media/controls-styling-strict-expected.txt
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/media/controls-without-preload-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/media/controls-without-preload-expected.txt
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/media/controls/lazy-loaded-style-expected.txt
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.txt
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/media/controls/paint-controls-webkit-appearance-none-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/media/controls/paint-controls-webkit-appearance-none-expected.txt
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/media/controls/video-controls-with-cast-rendering-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/media/controls/video-controls-with-cast-rendering-expected.txt
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/media/media-controls-clone-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/media/media-controls-clone-expected.txt
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/media/media-controls-grey-scrubber-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/media/media-controls-grey-scrubber-expected.txt
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/media/video-controls-rendering-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/media/video-controls-rendering-expected.txt
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/media/video-display-toggle-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/media/video-display-toggle-expected.txt
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/media/video-empty-source-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/media/video-empty-source-expected.txt
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/media/video-no-audio-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/media/video-no-audio-expected.txt
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/media/video-zoom-controls-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/media/video-zoom-controls-expected.txt
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/full-screen-iframe-allowed-video-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/video-controls-timeline-expected.png
[delete] https://crrev.com/b8dbaf47d93ee842defddd5bb054264671256484/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/video-overlay-scroll-expected.txt
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/video-scrolled-iframe-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style-expected.txt
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.txt
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-expected.txt
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/video-controls-with-cast-rendering-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/video-controls-with-cast-rendering-expected.txt
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-after-reload-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-after-reload-expected.txt
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-layout-direction-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-strict-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-strict-expected.txt
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-styling-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-styling-expected.txt
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-styling-strict-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-styling-strict-expected.txt
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-without-preload-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-without-preload-expected.txt
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls/video-controls-with-cast-rendering-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls/video-controls-with-cast-rendering-expected.txt
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/media-controls-clone-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/media-controls-clone-expected.txt
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/media-controls-grey-scrubber-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/media-controls-grey-scrubber-expected.txt
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-controls-rendering-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-controls-rendering-expected.txt
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-display-toggle-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-display-toggle-expected.txt
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-empty-source-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-empty-source-expected.txt
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-no-audio-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-no-audio-expected.txt
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-zoom-controls-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-zoom-controls-expected.txt
[delete] https://crrev.com/b8dbaf47d93ee842defddd5bb054264671256484/third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/video-zoom-controls-expected.png
[delete] https://crrev.com/b8dbaf47d93ee842defddd5bb054264671256484/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/video-surface-layer/media/video-zoom-controls-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/mac-mac10.12/compositing/video/video-controls-layer-creation-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/mac-mac10.12/fast/overflow/overflow-of-video-outline-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls-after-reload-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls-layout-direction-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls-strict-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls-styling-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls-styling-strict-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls-without-preload-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls/paint-controls-webkit-appearance-none-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/media-controls-clone-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/media-controls-grey-scrubber-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/video-controls-rendering-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/video-display-toggle-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/video-empty-source-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/video-no-audio-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/video-zoom-controls-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/controls-after-reload-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/controls-layout-direction-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/controls-strict-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/controls-styling-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/controls-styling-strict-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/controls-without-preload-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/media-controls-clone-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/media-controls-grey-scrubber-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/video-controls-rendering-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/video-display-toggle-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/video-empty-source-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/video-zoom-controls-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/mac/compositing/video/video-controls-layer-creation-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/mac/fast/overflow/overflow-of-video-outline-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/mac/media/controls-after-reload-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/mac/media/controls-after-reload-expected.txt
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/mac/media/controls-layout-direction-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/LayoutTests/platform/mac/media/controls-strict-expected.png
[modify] https://crrev.com/53c52480c292f9233154779436ac3b9df3ac4e23/third_party/WebKit/Layou
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf0f28aa9ae85826270c403bb172134cb2027489

commit bf0f28aa9ae85826270c403bb172134cb2027489
Author: Olga Sharonova <olka@chromium.org>
Date: Mon Oct 08 11:39:58 2018

Revert "[Media Controls] Remove overlay play button on desktop"

This reverts commit 53c52480c292f9233154779436ac3b9df3ac4e23.

Reason for revert: FindIt thinks it caused flakiness of virtual/android/fullscreen/video-fixed-background.html.

Speculative revert.

Bug:893097

Original change's description:
> [Media Controls] Remove overlay play button on desktop
> 
> This CL updates the media controls on desktop to have the standard
> play button in the bottom left corner instead of the overlay play
> button in the center.
> 
> As part of this change, the play button is given a disabled state
> when appropriate, which also applies to the audio player. This fixes
> a separate issue where the audio player wasn't giving proper feedback
> with a broken source.
> 
> Bug:  890078 , 839101
> Change-Id: Ifbc8b3c216d3537c657b04ff6fc53506b886c48f
> Reviewed-on: https://chromium-review.googlesource.com/c/1252846
> Reviewed-by: Becca Hughes <beccahughes@chromium.org>
> Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
> Commit-Queue: Tommy Steimel <steimel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#597483}

TBR=aleventhal@chromium.org,beccahughes@chromium.org,steimel@chromium.org

Change-Id: I4f405126f603bd2c8df849c3c210a5d8efedd74e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  890078 , 839101
Reviewed-on: https://chromium-review.googlesource.com/c/1268197
Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597530}
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/media/controls/modern/doubletap-on-play-button.html
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/media/controls/modern/immersive-mode-adds-css-class.html
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/media/controls/modern/overlay-play-button-tap-to-hide.html
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/media/controls/modern/singletap-on-outside.html
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/media/controls/modern/singletap-on-overlay-closes-overflow-menu.html
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/media/controls/modern/singletap-on-play-button.html
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/media/controls/modern/singletouch-on-play-button.html
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/media/controls/modern/video-does-not-go-fullscreen-on-double-click-before-preload.html
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/media/controls/overlay-play-button-resizes-with-video.html
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/media/controls/tap-on-overlay-play-button-cant-be-preempted.html
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/media/controls/video-enter-exit-fullscreen-while-hovering-shows-controls.html
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/media/controls/video-enter-exit-fullscreen-without-hovering-doesnt-show-controls.html
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/media/media-controls-tap-show-controls-without-activating.html
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/media/media-controls.js
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/media/video-controls-always-visible-when-control-hovered.html
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/media/video-controls-auto-hide-after-play-by-touch.html
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/media/video-controls-hide-after-touch-on-control.html
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/media/video-controls-hide-on-move-outside-controls.html
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/media/video-controls-transformed.html
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/media/video-controls-visibility-multimodal-mouse-after-touch.html
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/media/video-controls-visibility-multimodal-touch-after-mouse.html
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/media/video-controls-zoomed.html
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/media/video-play-require-user-gesture.html
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/paint/invalidation/video-paint-invalidation-expected.txt
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/compositing/video/video-controls-layer-creation-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/fast/overflow/overflow-of-video-outline-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/media/controls-after-reload-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/media/controls-after-reload-expected.txt
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/media/controls-layout-direction-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/media/controls-strict-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/media/controls-strict-expected.txt
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/media/controls-styling-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/media/controls-styling-expected.txt
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/media/controls-styling-strict-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/media/controls-styling-strict-expected.txt
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/media/controls-without-preload-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/media/controls-without-preload-expected.txt
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/media/controls/lazy-loaded-style-expected.txt
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.txt
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/media/controls/paint-controls-webkit-appearance-none-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/media/controls/paint-controls-webkit-appearance-none-expected.txt
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/media/controls/video-controls-with-cast-rendering-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/media/controls/video-controls-with-cast-rendering-expected.txt
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/media/media-controls-clone-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/media/media-controls-clone-expected.txt
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/media/media-controls-grey-scrubber-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/media/media-controls-grey-scrubber-expected.txt
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/media/video-controls-rendering-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/media/video-controls-rendering-expected.txt
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/media/video-display-toggle-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/media/video-display-toggle-expected.txt
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/media/video-empty-source-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/media/video-empty-source-expected.txt
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/media/video-no-audio-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/media/video-no-audio-expected.txt
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/media/video-zoom-controls-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/media/video-zoom-controls-expected.txt
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/full-screen-iframe-allowed-video-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/video-controls-timeline-expected.png
[add] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/video-overlay-scroll-expected.txt
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/video-scrolled-iframe-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style-expected.txt
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.txt
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-expected.txt
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/video-controls-with-cast-rendering-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/video-controls-with-cast-rendering-expected.txt
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-after-reload-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-after-reload-expected.txt
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-layout-direction-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-strict-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-strict-expected.txt
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-styling-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-styling-expected.txt
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-styling-strict-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-styling-strict-expected.txt
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-without-preload-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-without-preload-expected.txt
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls/video-controls-with-cast-rendering-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls/video-controls-with-cast-rendering-expected.txt
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/media-controls-clone-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/media-controls-clone-expected.txt
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/media-controls-grey-scrubber-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/media-controls-grey-scrubber-expected.txt
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-controls-rendering-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-controls-rendering-expected.txt
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-display-toggle-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-display-toggle-expected.txt
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-empty-source-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-empty-source-expected.txt
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-no-audio-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-no-audio-expected.txt
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-zoom-controls-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-zoom-controls-expected.txt
[add] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/video-zoom-controls-expected.png
[add] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/video-surface-layer/media/video-zoom-controls-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/mac-mac10.12/compositing/video/video-controls-layer-creation-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/mac-mac10.12/fast/overflow/overflow-of-video-outline-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls-after-reload-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls-layout-direction-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls-strict-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls-styling-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls-styling-strict-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls-without-preload-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls/paint-controls-webkit-appearance-none-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/media-controls-clone-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/media-controls-grey-scrubber-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/video-controls-rendering-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/video-display-toggle-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/video-empty-source-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/video-no-audio-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/video-zoom-controls-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/controls-after-reload-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/controls-layout-direction-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/controls-strict-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/controls-styling-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/controls-styling-strict-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/controls-without-preload-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/media-controls-clone-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/media-controls-grey-scrubber-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/video-controls-rendering-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/video-display-toggle-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/video-empty-source-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/video-zoom-controls-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/mac/compositing/video/video-controls-layer-creation-expected.png
[modify] https://crrev.com/bf0f28aa9ae85826270c403bb172134cb2027489/third_party/WebKit/LayoutTests/platform/mac/fast/overflow/
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16d3504ad4ade83588f086c8befccd3d04b73ae3

commit 16d3504ad4ade83588f086c8befccd3d04b73ae3
Author: Tommy Steimel <steimel@chromium.org>
Date: Mon Oct 08 20:44:22 2018

[Media Controls] Reland "Remove overlay play button on desktop"

This is a reland of crrev.com/c/1252846, modified to enable test mode
on a flaky layout test.

Description from crrev.com/c/1252846:

This CL updates the media controls on desktop to have the standard
play button in the bottom left corner instead of the overlay play
button in the center.

As part of this change, the play button is given a disabled state
when appropriate, which also applies to the audio player. This fixes
a separate issue where the audio player wasn't giving proper feedback
with a broken source.

Bug:  890078 , 839101
Change-Id: I03fa0a56b34c91cddeb9884a7922dc6885c3ac70
Reviewed-on: https://chromium-review.googlesource.com/c/1268663
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597673}
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/media/controls/modern/doubletap-on-play-button.html
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/media/controls/modern/immersive-mode-adds-css-class.html
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/media/controls/modern/overlay-play-button-tap-to-hide.html
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/media/controls/modern/singletap-on-outside.html
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/media/controls/modern/singletap-on-overlay-closes-overflow-menu.html
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/media/controls/modern/singletap-on-play-button.html
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/media/controls/modern/singletouch-on-play-button.html
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/media/controls/modern/video-does-not-go-fullscreen-on-double-click-before-preload.html
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/media/controls/overlay-play-button-resizes-with-video.html
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/media/controls/tap-on-overlay-play-button-cant-be-preempted.html
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/media/controls/video-enter-exit-fullscreen-while-hovering-shows-controls.html
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/media/controls/video-enter-exit-fullscreen-without-hovering-doesnt-show-controls.html
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/media/media-controls-tap-show-controls-without-activating.html
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/media/media-controls.js
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/media/video-controls-always-visible-when-control-hovered.html
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/media/video-controls-auto-hide-after-play-by-touch.html
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/media/video-controls-hide-after-touch-on-control.html
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/media/video-controls-hide-on-move-outside-controls.html
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/media/video-controls-transformed.html
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/media/video-controls-visibility-multimodal-mouse-after-touch.html
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/media/video-controls-visibility-multimodal-touch-after-mouse.html
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/media/video-controls-zoomed.html
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/media/video-play-require-user-gesture.html
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/paint/invalidation/video-paint-invalidation-expected.txt
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/compositing/video/video-controls-layer-creation-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/fast/overflow/overflow-of-video-outline-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/media/controls-after-reload-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/media/controls-after-reload-expected.txt
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/media/controls-layout-direction-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/media/controls-strict-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/media/controls-strict-expected.txt
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/media/controls-styling-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/media/controls-styling-expected.txt
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/media/controls-styling-strict-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/media/controls-styling-strict-expected.txt
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/media/controls-without-preload-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/media/controls-without-preload-expected.txt
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/media/controls/lazy-loaded-style-expected.txt
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.txt
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/media/controls/paint-controls-webkit-appearance-none-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/media/controls/paint-controls-webkit-appearance-none-expected.txt
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/media/controls/video-controls-with-cast-rendering-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/media/controls/video-controls-with-cast-rendering-expected.txt
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/media/media-controls-clone-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/media/media-controls-clone-expected.txt
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/media/media-controls-grey-scrubber-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/media/media-controls-grey-scrubber-expected.txt
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/media/video-controls-rendering-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/media/video-controls-rendering-expected.txt
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/media/video-display-toggle-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/media/video-display-toggle-expected.txt
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/media/video-empty-source-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/media/video-empty-source-expected.txt
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/media/video-no-audio-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/media/video-no-audio-expected.txt
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/media/video-zoom-controls-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/media/video-zoom-controls-expected.txt
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/full-screen-iframe-allowed-video-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/video-controls-timeline-expected.png
[delete] https://crrev.com/a544ca69f57da786d866979a634aeb509c8549ca/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/video-overlay-scroll-expected.txt
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/video-scrolled-iframe-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style-expected.txt
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.txt
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-expected.txt
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/video-controls-with-cast-rendering-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/video-controls-with-cast-rendering-expected.txt
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-after-reload-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-after-reload-expected.txt
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-layout-direction-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-strict-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-strict-expected.txt
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-styling-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-styling-expected.txt
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-styling-strict-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-styling-strict-expected.txt
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-without-preload-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-without-preload-expected.txt
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls/video-controls-with-cast-rendering-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls/video-controls-with-cast-rendering-expected.txt
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/media-controls-clone-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/media-controls-clone-expected.txt
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/media-controls-grey-scrubber-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/media-controls-grey-scrubber-expected.txt
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-controls-rendering-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-controls-rendering-expected.txt
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-display-toggle-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-display-toggle-expected.txt
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-empty-source-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-empty-source-expected.txt
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-no-audio-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-no-audio-expected.txt
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-zoom-controls-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-zoom-controls-expected.txt
[delete] https://crrev.com/a544ca69f57da786d866979a634aeb509c8549ca/third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/video-zoom-controls-expected.png
[delete] https://crrev.com/a544ca69f57da786d866979a634aeb509c8549ca/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/video-surface-layer/media/video-zoom-controls-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/mac-mac10.12/compositing/video/video-controls-layer-creation-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/mac-mac10.12/fast/overflow/overflow-of-video-outline-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls-after-reload-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls-layout-direction-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls-strict-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls-styling-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls-styling-strict-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls-without-preload-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls/paint-controls-webkit-appearance-none-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/media-controls-clone-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/media-controls-grey-scrubber-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/video-controls-rendering-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/video-display-toggle-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/video-empty-source-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/video-no-audio-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/video-zoom-controls-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/controls-after-reload-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/controls-layout-direction-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/controls-strict-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/controls-styling-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/controls-styling-strict-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/controls-without-preload-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/media-controls-clone-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/media-controls-grey-scrubber-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/video-controls-rendering-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/video-display-toggle-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/video-empty-source-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/video-zoom-controls-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/mac/compositing/video/video-controls-layer-creation-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/mac/fast/overflow/overflow-of-video-outline-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/mac/media/controls-after-reload-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/mac/media/controls-after-reload-expected.txt
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTests/platform/mac/media/controls-layout-direction-expected.png
[modify] https://crrev.com/16d3504ad4ade83588f086c8befccd3d04b73ae3/third_party/WebKit/LayoutTes

Comment 6 by steimel@chromium.org, Oct 15

Status: Fixed (was: Started)

Comment 7 by steimel@chromium.org, Oct 15

Cc: phanindra.mandapaka@chromium.org steimel@chromium.org vamshi.kommuri@chromium.org
 Issue 857245  has been merged into this issue.

Comment 8 by woxxom@gmail.com, Dec 1 

Will you also match the common web video player UX which is to pause/resume the video on click at any point of the thumbnail?
It has been implemented for years in popular video services like YouTube or DailyMotion and so on.

Comment 9 by steimel@chromium.org, Dec 3 

Yes. See  crbug.com/895636 . It should be released in M72. Thanks!
►

Sign in to add a comment