go/simplechrome fails to find assistant dep for chromium builds |
||
Issue descriptiongo/simplechrome fails to find assistant dep for chromium builds On linux, trying to build go/simplechrome for eve: (1) cros chrome-sdk --board=eve --log-level=info (2) autoninja -C out_eve/Release chrome chrome_sandbox nacl_helper Expected: Pass Actual: Fail, see output below: ===================================================================================== ninja -C out_eve/Release chrome chrome_sandbox nacl_helper -j 1120 -l 56 ninja: Entering directory `out_eve/Release' [1/1] Regenerating ninja files FAILED: build.ninja ../../buildtools/linux64/gn --root=../.. -q gen . ERROR at //ash/BUILD.gn:1458:15: Can't load input file. deps += [ "//chromeos/assistant/internal/logo_view" ] ^---------------------------------------- Unable to load: /work/chrome-git/src/chromeos/assistant/internal/logo_view/BUILD.gn I also checked in the secondary tree for: /work/chrome-git/src/build/secondary/chromeos/assistant/internal/logo_view/BUILD.gn ninja: error: rebuilding 'build.ninja': subcommand failed ===================================================================================== In out_eve/Release/args.gn, I have some unexpected values: enable_cros_assistant = true enable_cros_libassistant = true Removing those values allowed me to build as expected. Xiyuan thinks that the cros-sdk script is getting its gn args from a buildbot that's building an internal build. I have generally been able to build chromium (non-internal) builds for go/simplechrome, so hopefully we can continue supporting that workflow.
,
Sep 28
Also these two gn args are removed from latest chromeos chrome builds, so depend on which version of simple chrome sdk you are pulling down, maybe after getting a newer one you will see those gn flags gone.
,
Sep 28
BTW, those comments are me. My phone autologged in with one of my other accounts.
,
Sep 28
The build config works correctly that only set enable_cros_libassistant when it is enabled and for a branded build [1]. The problem is with the gn args that simple chrome script uses. It directly sets "enable_cros_libassistant = true" hence the problem. Removing that gets rid of the error. Simple chrome scripts seems gets it from build bots ebuild env [2] and we probably should get rid of "enable_cros_libassistant" and let the it use the generated value. [1] https://cs.chromium.org/chromium/src/chromeos/assistant/assistant.gni?rcl=459edf4f594ec1f154784da9800efe1fedf86321&l=12 [2] https://cs.chromium.org/chromium/src/third_party/chromite/cli/cros/cros_chrome_sdk.py?rcl=8241a7599974ed98de3e87c521b3a85047f614d3&l=880-881
,
Oct 1
I synced today and R71-11100.0.0 has the two gn flags removed.
,
Oct 1
Confirmed! So I guess this is fixed? Please reopen if there's more to do. |
||
►
Sign in to add a comment |
||
Comment 1 by sava...@gmail.com
, Sep 28