New issue
Advanced search Search tips

Issue 890072 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

android-marshmallow-arm64-rel does not block patch breaking some test

Project Member Reported by tikuta@chromium.org, Sep 27

Issue description

Why below build became green with failure of monochrome_apk_checker?
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-marshmallow-arm64-rel/95101
 
Looking
Looks like a bug

In the failing step text:
Total tests: 1
* Passed: 0 (0 expected, 0 unexpected)
* Skipped: 0 (0 expected, 0 unexpected)
* Failed: 1 (1 expected, 0 unexpected)
* Flaky: 0 (0 expected, 0 unexpected)
 

Somehow the recipe thinks the failure is expected, when it isn't. The json output says that the result isn't expected. Not sure why it thinks that exactly....
Owner: martiniss@chromium.org
Status: Started (was: Untriaged)
The json results output has a typo. It says 

  {
    "interrupted": false,
    "num_failures_by_type": {
      "FAIL": 1,
      "PASS": 0
    },
    "path_delimiter": "/",
    "seconds_since_epoch": 1538078992.76389,
    "tests": {
      "monochrome_apk_checker": {
        "actual": "FAIL",
        "expected": "PASS",
        "unexpected": true
      }
    },
    "version": 3
  }

unexpected should be "is_unexpected".

I'll fix.
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3fc3da7ce11a73889240c9ef6699072b086c40f

commit a3fc3da7ce11a73889240c9ef6699072b086c40f
Author: Stephen Martinis <martiniss@chromium.org>
Date: Fri Sep 28 02:14:25 2018

Fix typo in monochrome apk checker wrapper script

The test results format says that the key should be 'is_unexpected', not
'unexpected'.

TBR=dpranke

Bug:  890072 , 890075
Change-Id: I49d49b9a0ee7ebaf2346658eb8f334cef1cf8a19
Reviewed-on: https://chromium-review.googlesource.com/1250202
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594959}
[modify] https://crrev.com/a3fc3da7ce11a73889240c9ef6699072b086c40f/testing/scripts/monochrome_apk_checker_wrapper.py

Status: Fixed (was: Started)

Sign in to add a comment