New issue
Advanced search Search tips

Issue 890066 link

Starred by 1 user
Status: Fixed
Owner:
joanmari...@gmail.com
Closed: Sep 28
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

Listbox and Combobox roles embedded in labels should participate in accessible name calculation

Project Member Reported by joanmari...@gmail.com, Sep 27 
Steps to reproduce:
1. View the attached set of test cases
2. Use an accessibility inspector to view the accessible name of each checkbox

Expected results: Each checkbox would have a name which ended in "Flash the screen {2,two} times".

Actual results: Each checkbox has a name which ends in "Flash the screen times" because the selected item is not being used as part of the name calculation.

Note: Step 2E of the Accessible Name and Description Computation spec states: "If the embedded control has role combobox or listbox, return the text alternative of the chosen option." The presence of listbox in that statement is new to 1.1; combobox has been there awhile. Both WebKit and Gecko support combobox. WebKit also supports listbox. (Gecko still needs to be fixed.)
label-with-selected-option.html
2.4 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0e92501211eaabbe4bf1e08d6204b4f92713b70

commit e0e92501211eaabbe4bf1e08d6204b4f92713b70
Author: Joanmarie Diggs <jdiggs@igalia.com>
Date: Fri Sep 28 22:23:23 2018

Include selected listbox/combobox options in accessible name calculation

Step 2E of the Accessible Name and Description Computation spec states:
"If the embedded control has role combobox or listbox, return the text
alternative of the chosen option." This part of the accessible name
calculation had not been implemented in AXNodeObject::TextAlternative.

Bug:  890066 
Change-Id: I3829d8229b816fe69e939307aa6c44563a757eef
Reviewed-on: https://chromium-review.googlesource.com/1249887
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Joanmarie Diggs <joanmarie.diggs@gmail.com>
Cr-Commit-Position: refs/heads/master@{#595234}
[modify] https://crrev.com/e0e92501211eaabbe4bf1e08d6204b4f92713b70/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
[add] https://crrev.com/e0e92501211eaabbe4bf1e08d6204b4f92713b70/content/test/data/accessibility/aria/label-with-selected-option-expected-blink.txt
[add] https://crrev.com/e0e92501211eaabbe4bf1e08d6204b4f92713b70/content/test/data/accessibility/aria/label-with-selected-option.html
[add] https://crrev.com/e0e92501211eaabbe4bf1e08d6204b4f92713b70/content/test/data/accessibility/html/label-with-selected-option-expected-blink.txt
[add] https://crrev.com/e0e92501211eaabbe4bf1e08d6204b4f92713b70/content/test/data/accessibility/html/label-with-selected-option.html
[modify] https://crrev.com/e0e92501211eaabbe4bf1e08d6204b4f92713b70/third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-nameSources-visiblity-expected.txt
[modify] https://crrev.com/e0e92501211eaabbe4bf1e08d6204b4f92713b70/third_party/blink/renderer/modules/accessibility/ax_node_object.cc
[modify] https://crrev.com/e0e92501211eaabbe4bf1e08d6204b4f92713b70/third_party/blink/renderer/modules/accessibility/ax_node_object.h
[modify] https://crrev.com/e0e92501211eaabbe4bf1e08d6204b4f92713b70/third_party/blink/renderer/modules/accessibility/ax_object.cc
[modify] https://crrev.com/e0e92501211eaabbe4bf1e08d6204b4f92713b70/third_party/blink/renderer/modules/accessibility/ax_object.h

Comment 2 by joanmari...@gmail.com, Sep 28

Status: Fixed (was: Started)
►

Sign in to add a comment