New issue
Advanced search Search tips

Issue 890056 link

Starred by 2 users
Status: Verified
Owner:
rbpotter@chromium.org
Closed: Jan 10
Cc:
kkaluri@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

CHECK failure: !GetFrame()->GetDocument()->IsFrameSet() in web_local_frame_impl.cc

Project Member Reported by ClusterFuzz, Sep 27 
Detailed report: https://clusterfuzz.com/testcase?key=6037519727329280

Fuzzer: attekett_dom_fuzzer
Job Type: linux_debug_chrome
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  !GetFrame()->GetDocument()->IsFrameSet() in web_local_frame_impl.cc
  blink::WebLocalFrameImpl::PrintBegin
  printing::PrepareFrameAndViewForPrint::PrepareFrameAndViewForPrint
  
Sanitizer: address (ASAN)

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6037519727329280

Additional requirements: Requires Gestures

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.

Comment 1 by kkaluri@chromium.org, Sep 28

Cc: kkaluri@chromium.org
Labels: M-70 CF-NeedsTriage
Owner: rbpotter@chromium.org
Status: Assigned (was: Untriaged)
Predator and CL could not provide any possible suspects.

Using Code Search for the file, "print_render_frame_helper.cc" suspecting the below Cl might have caused this issue

Suspect CL: https://chromium.googlesource.com/chromium/src/+/da7dc652f35badf004c0c7e5b7966152fddbf4d3

rbpotter@ -- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks!

Comment 2 by manoranj...@chromium.org, Oct 16

Labels: -CF-NeedsTriage

Comment 3 by thestig@chromium.org, Jan 9

Components: Internals>Printing
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dcb35fd5c675d00dafda22073ca7ecd5ee4d5815

commit dcb35fd5c675d00dafda22073ca7ecd5ee4d5815
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Jan 09 06:48:47 2019

PrintRenderFrameHelper: Refuse to print framesets

blink::WebLocalFrameImpl::PrintBegin() will DCHECK if the body of the
document being printed is a <frameset>. Return early with a preview or
print failure if the document is a <frameset>, instead of running
through the DCHECK.

Note: To see the issue without running clusterfuzz, create an html file
with the following contents:
<html>
<head></head>
<frameset></frameset>
</html>
and press ctrl + P to open Print Preview in a debug build.

Bug:  890056 
Change-Id: Ifdb81deb55f6b481d5734c79b504bd6dfc172950
Reviewed-on: https://chromium-review.googlesource.com/c/1402001
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621062}
[modify] https://crrev.com/dcb35fd5c675d00dafda22073ca7ecd5ee4d5815/components/printing/renderer/print_render_frame_helper.cc
Project Member

Comment 5 by ClusterFuzz, Jan 10 

ClusterFuzz has detected this issue as fixed in range 621060:621062.

Detailed report: https://clusterfuzz.com/testcase?key=6037519727329280

Fuzzer: attekett_dom_fuzzer
Job Type: linux_debug_chrome
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  !GetFrame()->GetDocument()->IsFrameSet() in web_local_frame_impl.cc
  blink::WebLocalFrameImpl::PrintBegin
  printing::PrepareFrameAndViewForPrint::PrepareFrameAndViewForPrint
  
Sanitizer: address (ASAN)

Fixed: https://clusterfuzz.com/revisions?job=linux_debug_chrome&range=621060:621062

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6037519727329280

Additional requirements: Requires Gestures

See https://github.com/google/clusterfuzz-tools for instructions to reproduce this bug locally.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, Jan 10

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6037519727329280 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
►

Sign in to add a comment