Switch networks and contents of SMB directories doesn't appear back in Files app |
|||||||||||||
Issue descriptionChrome OS version: 11021.28.0, 70.0.3538.34 beta-channel eve What steps will reproduce the problem? 1. Mount network file shares from Settings > Downloads > Network File Shares > Add File Share Note that device connected to 'Network Files Shares Test' n/w 2. SMB file shares are mounted in Files app 3. Switch to a different n/w 4. Open Files app and wait for the directories to load 5. Connect back to 'Network Files Shares Test' n/w 6. Check the contents of SMB file shares in Files app What happens instead? File contents in the SMB directories don't appear back in Files app
,
Sep 28
baileyberro@ Can we check the log to see if we are getting these requests, and if so what error codes we are getting.
,
Oct 2
,
Oct 8
,
Oct 8
,
Oct 8
,
Oct 10
May only happen when navigating away from the File Manager after switching networks.
,
Oct 22
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/9342c808866b2aacfe96cdd78d92c4a54ae6e3f0 commit 9342c808866b2aacfe96cdd78d92c4a54ae6e3f0 Author: jimmy <jimmyxgong@google.com> Date: Tue Oct 23 20:01:56 2018 smbprovider: Add workaround fix with fake Stat to prevent SMB client hangs - This fix is a workaround fix to handle the case of switching networks while a share is mounted. - Previously, SmbProvider::GetMetaDataEntry would return an error if the root path was empty. The files app would then see the error and stop sending requests to the SMB daemon. BUG= chromium:890046 TEST=unit test + end to end Change-Id: Ie41470a2db5899f20bfac60e8a6723e33728438a Reviewed-on: https://chromium-review.googlesource.com/1287411 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: jimmy gong <jimmyxgong@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> [modify] https://crrev.com/9342c808866b2aacfe96cdd78d92c4a54ae6e3f0/smbprovider/smbprovider.cc
,
Oct 23
This fixes a bug where if you lose connectivity the share becomes unusable without a reboot or unmount/remount.
,
Oct 24
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 26
Merge cherry pick pending submit - https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1303113
,
Oct 26
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/8ede28dbc6f938fc7601888529d5886a5db3efbd commit 8ede28dbc6f938fc7601888529d5886a5db3efbd Author: jimmy <jimmyxgong@google.com> Date: Fri Oct 26 21:21:15 2018 smbprovider: Add workaround fix with fake Stat to prevent SMB client hangs - This fix is a workaround fix to handle the case of switching networks while a share is mounted. - Previously, SmbProvider::GetMetaDataEntry would return an error if the root path was empty. The files app would then see the error and stop sending requests to the SMB daemon. BUG= chromium:890046 TEST=unit test + end to end Change-Id: Ie41470a2db5899f20bfac60e8a6723e33728438a Reviewed-on: https://chromium-review.googlesource.com/1287411 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: jimmy gong <jimmyxgong@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> (cherry picked from commit 9342c808866b2aacfe96cdd78d92c4a54ae6e3f0) Reviewed-on: https://chromium-review.googlesource.com/c/1303113 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Tested-by: Zentaro Kavanagh <zentaro@chromium.org> [modify] https://crrev.com/8ede28dbc6f938fc7601888529d5886a5db3efbd/smbprovider/smbprovider.cc
,
Oct 26
,
Oct 29
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 2
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 2
Already merged |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by mkarkada@chromium.org
, Sep 27