upload 'retry with patch' test results steps fail due to 'build number conflict' |
|||||||
Issue descriptionHere is an example: build link: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/mac_chromium_rel_ng/150041 step name: Upload to test-results [chromedriver_py_tests on (none) GPU on Mac (retry with patch)] step link: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8934216342294816176/+/steps/Upload_to_test-results__chromedriver_py_tests_on__none__GPU_on_Mac__retry_with_patch__/0/stdout Detailed error logs: 2018-09-27 09:50:27,659 - root - INFO - Input JSON file probably has full json results format 2018-09-27 09:50:27,659 - root - INFO - Uploading JSON files for builder "mac_chromium_rel_ng" to server "test-results.appspot.com" 2018-09-27 09:50:27,661 - root - INFO - Sending request to https://test-results.appspot.com/testfile/upload at 2018-09-27 16:50:27.660679 UTC Traceback (most recent call last): File "/b/s/w/ir/kitchen-checkout/build/scripts/slave/recipe_modules/test_results/resources/upload_test_results.py", line 216, in <module> sys.exit(main(sys.argv[1:])) File "/b/s/w/ir/kitchen-checkout/build/scripts/slave/recipe_modules/test_results/resources/upload_test_results.py", line 207, in main options.test_results_server, attrs, files, 120) File "/b/s/w/ir/kitchen-checkout/build/scripts/slave/recipe_modules/test_results/resources/test_results_uploader.py", line 51, in upload_test_results timeout_secs) File "/b/s/w/ir/kitchen-checkout/build/scripts/slave/recipe_modules/test_results/resources/test_results_uploader.py", line 135, in _retry_exp_backoff % (e.code, e.filename, e.read())) test_results_uploader.PermanentError: Received HTTP status 409 loading "https://test-results.appspot.com/testfile/upload": build number conflict step returned non-zero exit code: 1
,
Sep 27
That's really weird it's giving that error. It's using the "correct" test type.
,
Sep 27
,
Sep 27
https://cs.chromium.org/chromium/infra/go/src/infra/appengine/test-results/frontend/builders.go?dr=C&q=cleanTestType+file:%5Einfra/go/src/infra/appengine/test-results/+package:%5Echromium$&g=0&l=260 is probably the problem. We strip a lot of the suffixes on tests. Probably what's happening here is that both the (without patch) and (retry with patch) suffixes are being stripped out by that logic, which means they have duplicate test types, and therefore have a build number conflict.
,
Sep 27
Thanks martiniss -- good find. Should be straight forward to change that logic to also keep "retry with patch".
,
Sep 27
But now I go through the usual process of trying to figure out where this repository actually lives...
,
Sep 27
It lives in https://chromium.googlesource.com/infra/infra/, the main infra checkout.
,
Sep 28
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/a021bc2fd729025a15380991717f0031fcff40d5 commit a021bc2fd729025a15380991717f0031fcff40d5 Author: erikchen <erikchen@chromium.org> Date: Fri Sep 28 15:19:32 2018 Add support for 'retry with patch' to test-results frontend. Change-Id: I2e994faefb25f2dedbb4885e272968c4e085114f Bug: 890044 Reviewed-on: https://chromium-review.googlesource.com/1250012 Reviewed-by: Stephen Martinis <martiniss@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#17945} [modify] https://crrev.com/a021bc2fd729025a15380991717f0031fcff40d5/go/src/infra/appengine/test-results/frontend/builders.go
,
Sep 28
Erik, would you mind following up to get a new version of test-results app deployed? https://findit-for-me.appspot.com/ranked-flakes is broken by the change of (retry with patch).
,
Sep 28
Sure -- are there more detailed instructions for how to deploy the built product? https://chromium.googlesource.com/infra/infra/+/a021bc2fd729025a15380991717f0031fcff40d5/go/src/infra/appengine/test-results#deploy
,
Sep 28
+ seanmccullough@ and martiniss@ who know how to deploy the test-results app
,
Oct 1
Did this get deployed yet? Usually I just deploy to staging, click around to make sure things aren't broken, then deploy to prod, do the same, then make it default. I can do this if it hasn't happened yet.
,
Oct 1
@martiniss: the latest deployment was by you at Sep 27, 2018, 12:41:32 PM. So I think no deployment was done here yet. It would be great if you could help out. Thanks! https://findit-for-me.appspot.com/ranked-flakes almost stops working now.
,
Oct 1
Will deploy.
,
Oct 1
Thank you!
,
Oct 1
Switched the app to the new version. Please verify your CL fixed the issue erik. There's a network outage right now, so stuff will be broken right now, but should be fixed sometime today I'd imagine. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by liaoyuke@chromium.org
, Sep 27