New issue
Advanced search Search tips

Issue 890038 link

Starred by 1 user
Status: Fixed
Owner:
erikc...@chromium.org
Closed: Sep 28
Cc:
liaoyuke@chromium.org
martiniss@chromium.org
jbudorick@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

More consistent red/green indicator codes for 'retry without patch' and 'retry with step' steps

Project Member Reported by erikc...@chromium.org, Sep 27 
Current behavior:

* initial test summary is red if there are failing tests, otherwise green.
* 'retry summary' is always green.
* 'retry with patch summary' is red if the error repeated in 'with patch' and 'retry with patch' steps, but not 'without patch'

New behavior [proposed by yuke]:

* initial test summary -- no change
* 'retry summary' -- red if we need to run 'retry with patch' on the test suite, otherwise green.
* 'retry with patch summary' -- no change

I like yuke's proposal. In general, we can have red mean -- this test suite either needs to be retried, or else should cause the recipe to fail. Green means -- this test suite has passed, there is no need to retry it any more.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/8e5f2aac8c5ae0610bbe263d2e1ad8b4d8f9b5aa

commit 8e5f2aac8c5ae0610bbe263d2e1ad8b4d8f9b5aa
Author: erikchen <erikchen@chromium.org>
Date: Fri Sep 28 21:04:22 2018

More consistent presentation status for 'retry summary'.

Previously, 'retry summary' would always have presentation status 'SUCCESS' for
the Chromium CQ. Now, the 'retry summary' will have presentation status
'FAILURE' if there were tests that failed in the original CL, but not in 'retry
without patch'.

Bug:  890038 
Change-Id: I83575a28e31ed3667ffd858c5e53bc57126e6021
Reviewed-on: https://chromium-review.googlesource.com/1252281
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>

[modify] https://crrev.com/8e5f2aac8c5ae0610bbe263d2e1ad8b4d8f9b5aa/scripts/slave/recipes/blink_downstream.py
[modify] https://crrev.com/8e5f2aac8c5ae0610bbe263d2e1ad8b4d8f9b5aa/scripts/slave/recipes/chromium_trybot.expected/invalid_results.json
[modify] https://crrev.com/8e5f2aac8c5ae0610bbe263d2e1ad8b4d8f9b5aa/scripts/slave/recipes/chromium_trybot.expected/swarmed_webkit_tests_unexpected_error.json
[modify] https://crrev.com/8e5f2aac8c5ae0610bbe263d2e1ad8b4d8f9b5aa/scripts/slave/README.recipes.md
[modify] https://crrev.com/8e5f2aac8c5ae0610bbe263d2e1ad8b4d8f9b5aa/scripts/slave/recipes/chromium_trybot.expected/swarming_test_failure.json
[modify] https://crrev.com/8e5f2aac8c5ae0610bbe263d2e1ad8b4d8f9b5aa/scripts/slave/recipe_modules/test_utils/api.py
[modify] https://crrev.com/8e5f2aac8c5ae0610bbe263d2e1ad8b4d8f9b5aa/scripts/slave/recipes/chromium_trybot.expected/dynamic_swarmed_isolated_script_test_failure_no_result_json.json
[modify] https://crrev.com/8e5f2aac8c5ae0610bbe263d2e1ad8b4d8f9b5aa/scripts/slave/recipes/chromium_trybot.expected/swarming_trigger_failure.json
[modify] https://crrev.com/8e5f2aac8c5ae0610bbe263d2e1ad8b4d8f9b5aa/scripts/slave/recipe_modules/chromium_tests/api.py
[modify] https://crrev.com/8e5f2aac8c5ae0610bbe263d2e1ad8b4d8f9b5aa/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_on_trybot_failing.json
[modify] https://crrev.com/8e5f2aac8c5ae0610bbe263d2e1ad8b4d8f9b5aa/scripts/slave/recipes/chromium_trybot.expected/swarmed_webkit_tests_interrupted.json
[modify] https://crrev.com/8e5f2aac8c5ae0610bbe263d2e1ad8b4d8f9b5aa/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/basic.json
[modify] https://crrev.com/8e5f2aac8c5ae0610bbe263d2e1ad8b4d8f9b5aa/scripts/slave/recipes/chromium_trybot.expected/swarmed_layout_tests_too_many_failures_for_retcode.json

Comment 2 by erikc...@chromium.org, Sep 28

Status: Fixed (was: Assigned)
►

Sign in to add a comment