upload_screenshots.py fails for missing translations for several languages |
||
Issue description
Stack trace:
python tools/translation/upload_screenshots.py
Traceback (most recent call last):
File "tools/translation/upload_screenshots.py", line 207, in <module>
main()
File "tools/translation/upload_screenshots.py", line 155, in main
TRANSLATION_EXPECTATIONS_PATH))
File "tools/translation/upload_screenshots.py", line 108, in find_screenshots
repo_root, list_grds_in_repository(repo_root), translation_expectations)
File "/usr/local/google/home/frechette/Applications/chromium/src/tools/translation/helper/translation_helper.py", line 127, in get_translatable_grds
('\n - '.join(errors)))
Exception: Please fix these issues:
- android_chrome_strings.grd: missing translations for these languages: ['bn', 'et', 'gu', 'kn', 'ml', 'mr', 'ms', 'ta', 'te']. Add <file> and <output> elements to the grd file, or update the translation expectations.
Looks like this is caused by https://chromium-review.googlesource.com/c/chromium/src/+/1203611
,
Oct 1
Normal translation runs are also affected by the above CL (https://bugs.chromium.org/p/chromium/issues/detail?id=890511), so this will probably require a non-screenshot specific fix.
,
Oct 2
Hi, Thank for for reporting this bug. Can you please attach screenshot for reference. Regards,
,
Oct 2
Let's merge this to 890511 since they have the same root cause.
,
Oct 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2554cc8b1207efcab37c0268dbe4dc863e163cd4 commit 2554cc8b1207efcab37c0268dbe4dc863e163cd4 Author: David 'Digit' Turner <digit@google.com> Date: Thu Oct 04 12:20:49 2018 Revert "Add translations for Android omitted locales." This reverts commit 04c5a83e224a318822dfc687bbd99142bc7b0fed. Reason for revert: it broke the translation import process (see related bugs). A fix is in the work in [1] but is not ready yet. Reverting will unblock the situation. Once [1] is submitted, the original should be applied without breaking anything. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1256822 BUG=890511, 890035 R=jshin@chromium.org,govind@chromium.org TBR=thestig@chromium.org Change-Id: I70ec089a438175edd13c4cd577e5c7327509b633 Reviewed-on: https://chromium-review.googlesource.com/c/1261635 Reviewed-by: David Turner <digit@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#596625} [modify] https://crrev.com/2554cc8b1207efcab37c0268dbe4dc863e163cd4/tools/gritsettings/translation_expectations.pyl |
||
►
Sign in to add a comment |
||
Comment 1 by mea...@chromium.org
, Sep 27