New issue
Advanced search Search tips

Issue 890020 link

Starred by 1 user
Status: Fixed
Owner:
yosin@chromium.org
Closed: Oct 4
Cc:
editing-dev@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression

Blocking:
issue 887148



Sign in to add a comment

In Element.innerText, whitespace around <input> is missing

Project Member Reported by xiaoche...@chromium.org, Sep 27 
Chrome Version: 71.0.3559.6 (Official Build) dev (64-bit)
OS: Linux

What steps will reproduce the problem?
(1) Use html "<div id=container>foo <input> bar</div>"
(2) Get container.innerText

Demo available at: https://jsfiddle.net/3cuabtfg/

What is the expected result?

container.innerText should be "foo  bar" (two spaces in between)

What happens instead?

container.innerText is "foo bar" (only one space in between)

Note: M69 Stable doesn't have this bug.

This is a recent regression broken in M70 due to new innerText implementation: crrev.com/c/1114673

Comment 1 by xiaoche...@chromium.org, Sep 27

Blocking: 887148
yosin: Would you like to fix it? Or I can take it over :)

I don't want to add wrong layout test baselines due to this bug...

Comment 2 by yosin@chromium.org, Sep 28

Status: Started (was: Assigned)
Looking...

Comment 3 by yosin@chromium.org, Sep 28 

In review: http://crrev.com/c/1250825
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdb60d4f8393e380949500b0cbf699aa4530b265

commit fdb60d4f8393e380949500b0cbf699aa4530b265
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Thu Oct 04 02:43:46 2018

Make Element#innerText to not collapse white space around inline-block

This patch makes |Element#innerText| not to collapse white space around inline-
block for improving interop.

Note: The spec doesn't explicitly mention about this.

Changes of AX test expectations added missing space after <input>.

TBR=dmazzoni@chromium.org

Bug:  890020 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I74a47fd5ba3a22ff17d9c36838a81b4277ac47cc
Reviewed-on: https://chromium-review.googlesource.com/c/1250825
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596485}
[modify] https://crrev.com/fdb60d4f8393e380949500b0cbf699aa4530b265/content/test/data/accessibility/html/contenteditable-descendants-expected-blink.txt
[modify] https://crrev.com/fdb60d4f8393e380949500b0cbf699aa4530b265/content/test/data/accessibility/html/contenteditable-descendants-expected-mac.txt
[modify] https://crrev.com/fdb60d4f8393e380949500b0cbf699aa4530b265/content/test/data/accessibility/html/contenteditable-descendants-expected-win.txt
[modify] https://crrev.com/fdb60d4f8393e380949500b0cbf699aa4530b265/content/test/data/accessibility/html/contenteditable-descendants-with-selection-expected-blink.txt
[modify] https://crrev.com/fdb60d4f8393e380949500b0cbf699aa4530b265/content/test/data/accessibility/html/contenteditable-descendants-with-selection-expected-mac.txt
[modify] https://crrev.com/fdb60d4f8393e380949500b0cbf699aa4530b265/content/test/data/accessibility/html/contenteditable-descendants-with-selection-expected-win.txt
[modify] https://crrev.com/fdb60d4f8393e380949500b0cbf699aa4530b265/third_party/WebKit/LayoutTests/external/wpt/html/dom/elements/the-innertext-idl-attribute/getter-expected.txt
[modify] https://crrev.com/fdb60d4f8393e380949500b0cbf699aa4530b265/third_party/WebKit/LayoutTests/external/wpt/html/dom/elements/the-innertext-idl-attribute/getter-tests.js
[modify] https://crrev.com/fdb60d4f8393e380949500b0cbf699aa4530b265/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/external/wpt/html/dom/elements/the-innertext-idl-attribute/getter-expected.txt
[modify] https://crrev.com/fdb60d4f8393e380949500b0cbf699aa4530b265/third_party/blink/renderer/core/editing/element_inner_text.cc

Comment 5 by yosin@chromium.org, Oct 4

Components: -Blink>Editing Blink>Editing>Serialization
Status: Fixed (was: Started)
►

Sign in to add a comment