New issue
Advanced search Search tips

Issue 889998 link

Starred by 5 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-09-27
OS: Chrome
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

VK+ChromeVox don't work well together

Project Member Reported by dtseng@chromium.org, Sep 27

Issue description

- with ChromeVox enabled
- touch explore and double tap the omnibox

result:
sometimes, the VK shows up; other times, it does not. In addition, when it shows up, ChromeVox provides no indication the VK appeared. When it doesn't, ChromeVox does speak the hint "is editing" correctly though no actual VK is on-screen.


Technical details:
- ChromeVox needs a mechanism to synthesize and inject pointer events (touch or mouse). This appears to be the only way the VK triggers. There are currently no other cases where ChromeVox does this.
- TouchExplorationController sometimes does not get the right anchor set or have its anchor cleared. This is leading to the two (time related) states above, both of which are incorrect in different ways.

 
Cc: ajha@chromium.org
 Issue 802994  has been merged into this issue.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c09753e07525c9d5626c3b6cd428b909577073e

commit 4c09753e07525c9d5626c3b6cd428b909577073e
Author: David Tseng <dtseng@chromium.org>
Date: Wed Oct 17 17:30:19 2018

Send a synthetic mouse click on double tap of a text field

Bug: 889998
Change-Id: Ief9fe4dd17d8eb11d0b968a008cc22b377c2fcf2
Reviewed-on: https://chromium-review.googlesource.com/c/1284049
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600446}
[modify] https://crrev.com/4c09753e07525c9d5626c3b6cd428b909577073e/chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js

Issue 778238 has been merged into this issue.
Labels: Merge-Request-71
Project Member

Comment 5 by sheriffbot@chromium.org, Nov 13

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
This bug currently affects touchscreen CfM (Chromebox for Meetings) units in prod.

E.g. when ChromeVox is enabled, it's pretty hard to bring up the virtual keyboard to dial a phone number.
Labels: -Merge-Review-71 Merge-Approved-71
Merge Approved for ChromeOS M71
Labels: -Merge-Approved-71 Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/c689bb11ea38b6a7ccfc2545cd3034cc1f9e9d7d

Commit: c689bb11ea38b6a7ccfc2545cd3034cc1f9e9d7d
Author: dtseng@chromium.org
Commiter: dtseng@chromium.org
Date: 2018-11-18 00:08:40 +0000 UTC

Merge to m71: Send a synthetic mouse click on double tap of a text field

Bug: 889998
Change-Id: Ief9fe4dd17d8eb11d0b968a008cc22b377c2fcf2
Reviewed-on: https://chromium-review.googlesource.com/c/1284049
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#600446}(cherry picked from commit 4c09753e07525c9d5626c3b6cd428b909577073e)
Reviewed-on: https://chromium-review.googlesource.com/c/1341278
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#746}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 18

Labels: merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c689bb11ea38b6a7ccfc2545cd3034cc1f9e9d7d

commit c689bb11ea38b6a7ccfc2545cd3034cc1f9e9d7d
Author: David Tseng <dtseng@chromium.org>
Date: Sun Nov 18 00:08:40 2018

Merge to m71: Send a synthetic mouse click on double tap of a text field

Bug: 889998
Change-Id: Ief9fe4dd17d8eb11d0b968a008cc22b377c2fcf2
Reviewed-on: https://chromium-review.googlesource.com/c/1284049
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#600446}(cherry picked from commit 4c09753e07525c9d5626c3b6cd428b909577073e)
Reviewed-on: https://chromium-review.googlesource.com/c/1341278
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#746}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/c689bb11ea38b6a7ccfc2545cd3034cc1f9e9d7d/chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js

Sign in to add a comment