New issue
Advanced search Search tips

Issue 889992 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
bpastene@chromium.org
jbudorick@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Clean up chromium recipe configs

Project Member Reported by martiniss@chromium.org, Sep 27 
The chromium recipe configs in tools/build are problematic and should be changed and cleaned up. That's a bit vague, so here are some concrete issues that can be fixed:

* Remove un-used values
* Remove GYP_DEFINES; chromium hasn't used GYP for a while, but we still use these to modify what gets run.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/1db1c0bee0ecff06eeaf05b242c0551827328281

commit 1db1c0bee0ecff06eeaf05b242c0551827328281
Author: Stephen Martinis <martiniss@chromium.org>
Date: Thu Sep 27 20:41:06 2018

Remove BUILD_PATH config option

Seems to be unused.

Bug: 889992
Change-Id: I426c07e62ec9180de4dd49e0b8d8431e57539e80
Reviewed-on: https://chromium-review.googlesource.com/1249762
Auto-Submit: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/1db1c0bee0ecff06eeaf05b242c0551827328281/scripts/slave/recipe_modules/chromium/config.py
[modify] https://crrev.com/1db1c0bee0ecff06eeaf05b242c0551827328281/scripts/slave/recipe_modules/chromium/api.py
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/c886c835e1f1c8e90af13e58f271bd9734f55402

commit c886c835e1f1c8e90af13e58f271bd9734f55402
Author: Stephen Martinis <martiniss@chromium.org>
Date: Fri Oct 05 22:13:47 2018

Remove set_build_data_dir config option

Seems to be used nowhere

Bug: 889992
Change-Id: Ic653383df286b27ef359cc0abf980c483591cb1e
Reviewed-on: https://chromium-review.googlesource.com/c/1249765
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/c886c835e1f1c8e90af13e58f271bd9734f55402/scripts/slave/recipe_modules/chromium/config.py
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/8418c20c544736ae455e2eea805f0ddade576bb8

commit 8418c20c544736ae455e2eea805f0ddade576bb8
Author: Stephen Martinis <martiniss@chromium.org>
Date: Thu Nov 01 23:28:28 2018

Remove ADB_VENDOR_KEYS

Seems to be set nowhere.

Bug: 889992
Change-Id: I6b2e35fb7ea676bfc6ddbbb3d1db27fcf9dd4366
Reviewed-on: https://chromium-review.googlesource.com/c/1313379
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Auto-Submit: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>

[modify] https://crrev.com/8418c20c544736ae455e2eea805f0ddade576bb8/scripts/slave/recipe_modules/chromium/tests/get_env.expected/goma_staging.json
[modify] https://crrev.com/8418c20c544736ae455e2eea805f0ddade576bb8/scripts/slave/recipe_modules/chromium/tests/get_env.expected/basic.json
[modify] https://crrev.com/8418c20c544736ae455e2eea805f0ddade576bb8/scripts/slave/recipe_modules/chromium_android/examples/full.expected/perf_adb_vendor_keys_basic.json
[modify] https://crrev.com/8418c20c544736ae455e2eea805f0ddade576bb8/scripts/slave/recipe_modules/chromium/config.py
[modify] https://crrev.com/8418c20c544736ae455e2eea805f0ddade576bb8/scripts/slave/recipe_modules/chromium/tests/get_env.py
[modify] https://crrev.com/8418c20c544736ae455e2eea805f0ddade576bb8/scripts/slave/recipe_modules/chromium_android/examples/full.py
[modify] https://crrev.com/8418c20c544736ae455e2eea805f0ddade576bb8/scripts/slave/README.recipes.md
[modify] https://crrev.com/8418c20c544736ae455e2eea805f0ddade576bb8/scripts/slave/recipe_modules/chromium/api.py
[modify] https://crrev.com/8418c20c544736ae455e2eea805f0ddade576bb8/scripts/slave/recipe_modules/chromium/tests/get_env.expected/goma_gce.json
[modify] https://crrev.com/8418c20c544736ae455e2eea805f0ddade576bb8/scripts/slave/recipe_modules/chromium/tests/get_env.expected/goma_rbe.json
[modify] https://crrev.com/8418c20c544736ae455e2eea805f0ddade576bb8/scripts/slave/recipe_modules/chromium/tests/get_env.expected/clang_tot.json
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/a1f88856f95086d1ea35b4bd1bde2adab6091b0f

commit a1f88856f95086d1ea35b4bd1bde2adab6091b0f
Author: Stephen Martinis <martiniss@chromium.org>
Date: Fri Nov 02 16:46:05 2018

Add tags support for swarming test specs

This should allow us to move different memory sanitizer tagging to
chromium/src, which should allow us to remove some of the config values
used by the memory sanitizers.

Bug: 889992
Change-Id: Ia94a82e9d4c27449e1c15af01eb253c462179e91
Reviewed-on: https://chromium-review.googlesource.com/c/1313777
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>

[modify] https://crrev.com/a1f88856f95086d1ea35b4bd1bde2adab6091b0f/scripts/slave/recipe_modules/chromium_tests/steps.py
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 2 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/2cbe7404b09fc89c3bb1e8253d96635901d33a3b

commit 2cbe7404b09fc89c3bb1e8253d96635901d33a3b
Author: Stephen Martinis <martiniss@google.com>
Date: Fri Nov 02 17:09:57 2018
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/17973a567ac1e50f4bc586e31ae5143c031b6844

commit 17973a567ac1e50f4bc586e31ae5143c031b6844
Author: Stephen Martinis <martiniss@chromium.org>
Date: Fri Nov 02 17:57:49 2018

Remove old gyp values

These are not used anywhere.

Recipe-Nontrivial-Roll: release_scripts
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Bug: 889992
Change-Id: If556e7254df0cad70b75b839fda6170d4c9fb7cb
Reviewed-on: https://chromium-review.googlesource.com/c/1313569
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Auto-Submit: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>

[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_failed_test_android_nexus6_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Deterministic_Android_fail.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipe_modules/chromium_android/examples/full.expected/perf_runner_basic.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/emulator.expected/x86_Emulator_Tester_test_fail.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipe_modules/chromium_android/examples/full.expected/asan_setup_failure.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_android_tester_arm32_debug__nexus_5x__forced_invalid.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipe_modules/chromium_android/examples/full.expected/gerrit_try_builder_basic.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__forced_invalid.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipe_modules/chromium_android/examples/full.expected/keep_data_install_tester_basic.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipe_modules/chromium_android/examples/full.expected/webview_tester_basic.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_revisions_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_arm64_dbg.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus5_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_config_error_android_fyi_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_fyi_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_recipe_android_one_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_test_custom_name.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipe_modules/chromium_android/examples/full.expected/webview_cts_basic.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/swarming/staging.expected/android.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_android_arm64_debug.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipe_modules/chromium_android/examples/full.expected/telemetry_browser_tests_failures.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__failing_test.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_one_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_config_error_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_revisions_staging_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipe_modules/chromium_android/examples/full.expected/tester_no_devices_during_status.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_failed_test_staging_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus5_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_builder.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_webview_nexus6_aosp_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_metric_android_one_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_recipe_staging_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipe_modules/chromium_android/examples/full.expected/perf_tests_infra_failure.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus5_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipe_modules/chromium_android/examples/full.expected/slow_tester_basic.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_revisions_android_nexus6_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect.expected/local_basic_recipe_failed_device.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_android_webview_nexus6_aosp_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_config_error_android_nexus5_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/cronet.expected/local_test.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_ios.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_one_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64_builder_arm64.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect.expected/local_basic_recipe_disconnected_device.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_arm64_dbg.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipe_modules/chromium_android/examples/full.expected/tester_basic.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_one_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_nodefault_test.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipe_modules/chromium_android/examples/full.expected/upload_archives_to_bucket_basic.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/webrtc/more_configs.expected/full_tryserver_webrtc_android_more_configs.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_arm64_rel.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android_rel.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_config_error_android_webview_nexus6_aosp_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_dbg.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipe_modules/chromium_android/examples/full.expected/json_results_file_basic.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/chromedriver.expected/Android_ChromeDriver_Tests__dbg__test_failure.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipe_modules/chromium_android/examples/full.expected/resource_size_builder_basic.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_android_tester_arm32_debug__nexus_5x_.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipe_modules/chromium_android/examples/full.expected/device_flags_builder_basic.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_webview_nexus6_aosp_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_webview_nexus6_aosp_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_builder_x86.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/android/builder.expected/full_client_v8_fyi_Android_Builder.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_android_nexus5_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_webview_arm64_aosp_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect_staging.expected/local_basic_recipe_no_device.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_nexus5_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_ios_arm64.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_ios_arm64_debug.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_metric_android_nexus7_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipe_modules/emulator/examples/full.expected/Disable_settings_after_launch_emulator_test_basic.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android_mips.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64__m_nexus5x_.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Deterministic_Android.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_revisions_android_fyi_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipe_modules/chromium_android/examples/full.expected/tester_blacklisted_devices.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_revisions_android_webview_arm64_aosp_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipe_modules/chromium_android/examples/full.expected/perf_runner_disable_location_basic.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus6_.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_webview_arm64_aosp_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_x86_dbg.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_fyi_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipe_modules/chromium_android/examples/full.expected/tombstones_m53.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipe_modules/chromium_android/examples/full.expected/perf_runner_allow_high_battery_temp_basic.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipe_modules/chromium_android/examples/full.expected/no_cache_builder_basic.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_recipe_android_webview_nexus6_aosp_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipe_modules/chromium_android/examples/full.expected/gerrit_refs.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipe_modules/chromium_tests/tests/api/compile_specific_targets.expected/android.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/cronet.expected/android_cronet_arm64_builder.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_rel.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipe_modules/chromium/config.py
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_android_release.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_android_one_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5_.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_config_error_android_one_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux32_arm_rel.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android64_tests__l_nexus9_.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32__m_nexus5x_.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipe_modules/chromium_android/examples/full.expected/coverage_builder_basic.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipe_modules/chromium/examples/full.expected/basic_out_dir_ninja_no_op_failure.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/android/builder.expected/full_chromium_perf_Android_arm64_Builder_Perf.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipe_modules/chromium_android/examples/full.expected/tester_offline_devices.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_one_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/cronet.expected/cronet_try.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_arm64_rel.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipe_modules/chromium/examples/full.expected/basic_out_dir_goma_module_ping_failure.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_webview_arm64_aosp_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_failed_test_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/cronet.expected/android_cronet_kitkat_builder.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_staging_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_android_nexus7_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug__arm_.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_fyi_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64__m_nexus5x__dbg_.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_metric_android_webview_arm64_aosp_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_android_fyi_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/cronet.expected/android_cronet_x86_builder__dbg_.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus7_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_ios_release.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_one_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_nexus7_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/cronet.expected/android_cronet_x86_builder.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipe_modules/cronet/examples/full.expected/gn_test.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipe_modules/chromium_android/examples/full.expected/no_strict_mode_tester_basic.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipe_modules/chromium/examples/full.expected/basic_out_dir_goma_module_build_failure.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_android_nexus6_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipe_modules/chromium_android/examples/full.expected/perf_adb_vendor_keys_basic.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__forced.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux32_arm_dbg.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus7_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/cronet.expected/android_cronet_builder_asan.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_rel.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_recipe_android_fyi_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_webview_nexus6_aosp_perf_bisect.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipes/bisection/android_bisect.expected/local_basic_recipe_basic_device.json
[modify] https://crrev.com/17973a567ac1e50f4bc586e31ae5143c031b6844/scripts/slave/recipe
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/0547a2d019f638868abffa0bd525d9e0ea9631d1

commit 0547a2d019f638868abffa0bd525d9e0ea9631d1
Author: Garrett Beaty <gbeaty@chromium.org>
Date: Thu Nov 15 19:05:21 2018

Don't use GYP_DEFINES for the various sanitizer values.

Bug: 889992
Change-Id: I5382cda276704dbb96c2a0d12d2c4875a1e8ab68
Recipe-Manual-Change: build_limited_scripts_slave
Reviewed-on: https://chromium-review.googlesource.com/c/1330004
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/0547a2d019f638868abffa0bd525d9e0ea9631d1/scripts/slave/recipe_modules/chromium_android/examples/full.expected/asan_basic.json
[modify] https://crrev.com/0547a2d019f638868abffa0bd525d9e0ea9631d1/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_asan.json
[modify] https://crrev.com/0547a2d019f638868abffa0bd525d9e0ea9631d1/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_linux_asan.json
[modify] https://crrev.com/0547a2d019f638868abffa0bd525d9e0ea9631d1/scripts/slave/recipes/chromium.expected/dynamic_gtest_memory_mac64.json
[modify] https://crrev.com/0547a2d019f638868abffa0bd525d9e0ea9631d1/scripts/slave/recipe_modules/chromium_android/examples/full.expected/asan_setup_failure.json
[modify] https://crrev.com/0547a2d019f638868abffa0bd525d9e0ea9631d1/scripts/slave/recipes/chromium_libfuzzer.expected/full_chromium_fyi_Libfuzzer_Upload_Linux_MSan.json
[modify] https://crrev.com/0547a2d019f638868abffa0bd525d9e0ea9631d1/scripts/slave/recipe_modules/chromium_android/api.py
[modify] https://crrev.com/0547a2d019f638868abffa0bd525d9e0ea9631d1/scripts/slave/recipe_modules/chromium_tests/api.py
[modify] https://crrev.com/0547a2d019f638868abffa0bd525d9e0ea9631d1/scripts/slave/recipes/chromium.expected/msan.json
[modify] https://crrev.com/0547a2d019f638868abffa0bd525d9e0ea9631d1/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_mac_asan.json
[modify] https://crrev.com/0547a2d019f638868abffa0bd525d9e0ea9631d1/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_tsan2.json
[modify] https://crrev.com/0547a2d019f638868abffa0bd525d9e0ea9631d1/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_asan.json
[modify] https://crrev.com/0547a2d019f638868abffa0bd525d9e0ea9631d1/scripts/slave/recipe_modules/chromium/config.py
[modify] https://crrev.com/0547a2d019f638868abffa0bd525d9e0ea9631d1/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_linux_tsan_v2.json
[modify] https://crrev.com/0547a2d019f638868abffa0bd525d9e0ea9631d1/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_linux_msan.json
[modify] https://crrev.com/0547a2d019f638868abffa0bd525d9e0ea9631d1/scripts/slave/recipe_modules/chromium_tests/tests/api/prepare_checkout.expected/disable_tests.json
[modify] https://crrev.com/0547a2d019f638868abffa0bd525d9e0ea9631d1/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_tsan2.json
[modify] https://crrev.com/0547a2d019f638868abffa0bd525d9e0ea9631d1/scripts/slave/recipes/chromium.expected/dynamic_gtest_memory_asan_no_lsan.json
[modify] https://crrev.com/0547a2d019f638868abffa0bd525d9e0ea9631d1/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_tsan_v2.json
[modify] https://crrev.com/0547a2d019f638868abffa0bd525d9e0ea9631d1/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_msan.json
[modify] https://crrev.com/0547a2d019f638868abffa0bd525d9e0ea9631d1/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_asan.json
[modify] https://crrev.com/0547a2d019f638868abffa0bd525d9e0ea9631d1/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_asan.json
[modify] https://crrev.com/0547a2d019f638868abffa0bd525d9e0ea9631d1/scripts/slave/recipe_modules/chromium/api.py
[modify] https://crrev.com/0547a2d019f638868abffa0bd525d9e0ea9631d1/scripts/slave/recipes/cronet.expected/android_cronet_builder_asan.json
[modify] https://crrev.com/0547a2d019f638868abffa0bd525d9e0ea9631d1/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_msan.json
[modify] https://crrev.com/0547a2d019f638868abffa0bd525d9e0ea9631d1/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_asan.json
[modify] https://crrev.com/0547a2d019f638868abffa0bd525d9e0ea9631d1/scripts/slave/recipes/chromium.expected/tsan.json
[modify] https://crrev.com/0547a2d019f638868abffa0bd525d9e0ea9631d1/scripts/slave/recipe_modules/chromium_android/chromium_config.py
[modify] https://crrev.com/0547a2d019f638868abffa0bd525d9e0ea9631d1/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac_asan.json
[modify] https://crrev.com/0547a2d019f638868abffa0bd525d9e0ea9631d1/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_asan.json
[modify] https://crrev.com/0547a2d019f638868abffa0bd525d9e0ea9631d1/scripts/slave/recipes/chromium.expected/dynamic_gtest_memory_builder.json
[modify] https://crrev.com/0547a2d019f638868abffa0bd525d9e0ea9631d1/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_msan.json
[modify] https://crrev.com/0547a2d019f638868abffa0bd525d9e0ea9631d1/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_mac_asan.json
[modify] https://crrev.com/0547a2d019f638868abffa0bd525d9e0ea9631d1/scripts/slave/recipe_modules/chromium_android/tests/android_build_wrapper.expected/basic.json
[modify] https://crrev.com/0547a2d019f638868abffa0bd525d9e0ea9631d1/scripts/slave/recipe_modules/chromium_tests/tests/api/archive_build.expected/cf_archive_build.json
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 15 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/601f9cc2224d492d5df916b2b5d39ab7b781a78e

commit 601f9cc2224d492d5df916b2b5d39ab7b781a78e
Author: Garrett Beaty <gbeaty@chromium.org>
Date: Thu Nov 15 19:24:38 2018
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e08eee5ba3bbb558113660818c37fdca486690d

commit 9e08eee5ba3bbb558113660818c37fdca486690d
Author: Garrett Beaty <gbeaty@chromium.org>
Date: Wed Nov 28 22:42:10 2018

Remove dead code dealing with gyp.

Bug: 889992
Change-Id: I3cc9b095ecd19acda49e1d1d34b5b064668d7e26
Reviewed-on: https://chromium-review.googlesource.com/c/1343367
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611908}
[modify] https://crrev.com/9e08eee5ba3bbb558113660818c37fdca486690d/build/gyp_chromium.py
[modify] https://crrev.com/9e08eee5ba3bbb558113660818c37fdca486690d/build/gyp_environment.py
[delete] https://crrev.com/3177145e5a33469a40ee21cb9fff020ce5dfd59a/build/gyp_helper.py
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a31a68fac4f033ab1d5ad26455f567d99e7fe16f

commit a31a68fac4f033ab1d5ad26455f567d99e7fe16f
Author: Garrett Beaty <gbeaty@chromium.org>
Date: Thu Nov 29 19:17:36 2018

Remove unused conditionally_execute script.

Bug: 889992
Change-Id: I9a8d8f787507c7e461b8a02ad5b130389a9f876c
Reviewed-on: https://chromium-review.googlesource.com/c/1351489
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612303}
[delete] https://crrev.com/f6a9827421a4059369e5b846ee26b048e4f4c931/tools/perf/conditionally_execute
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/95ab152eff69fec46da42294eb5846d45f9a6e7f

commit 95ab152eff69fec46da42294eb5846d45f9a6e7f
Author: Garrett Beaty <gbeaty@chromium.org>
Date: Fri Nov 30 00:28:50 2018

Remove the build_angle_deqp_tests chromium config.

The configuration only set a value in the GYP_DEFINES config value
which was not actually being read anywhere. Instead
build_angle_deqp_tests is a gn arg determined by mb_config.pyl.

Bug: 889992
Change-Id: I6bc7a5c83e1b3d80de9a889b3c8c8f32b9d5ffb0
Reviewed-on: https://chromium-review.googlesource.com/c/1355342
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>

[modify] https://crrev.com/95ab152eff69fec46da42294eb5846d45f9a6e7f/scripts/slave/recipes/chromium.expected/dynamic_swarmed_serialized_gtests.json
[modify] https://crrev.com/95ab152eff69fec46da42294eb5846d45f9a6e7f/scripts/slave/recipe_modules/chromium_tests/chromium_gpu_fyi.py
[modify] https://crrev.com/95ab152eff69fec46da42294eb5846d45f9a6e7f/scripts/slave/recipe_modules/chromium/config.py
[modify] https://crrev.com/95ab152eff69fec46da42294eb5846d45f9a6e7f/scripts/slave/recipe_modules/chromium/tests/configs.py
►

Sign in to add a comment