New issue
Advanced search Search tips

Issue 889985 link

Starred by 2 users
Status: Fixed
Owner:
tiborg@chromium.org
Closed: Nov 7
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Task
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Remove partial VR tab support

Project Member Reported by cjgrant@chromium.org, Sep 27 
Some tab support code landed before the work was paused in favor of DFM work.  From team group chat, the consensus is that this code should be removed, and reintroduced later if necessary.

Tibor, as primary author on that code, you have the honors on this, unless you'd like to delegate.

Comment 1 by tiborg@chromium.org, Nov 6

Labels: -M-71 Target-72
Status: Started (was: Assigned)

Comment 2 by tiborg@chromium.org, Nov 6

Labels: -Type-Bug Type-Task
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f08b6cda603489f807b9d9798b95482609372496

commit f08b6cda603489f807b9d9798b95482609372496
Author: Tibor Goldschwendt <tiborg@chromium.org>
Date: Wed Nov 07 23:35:48 2018

[vr] Remove tabs view

Bug:  889985 
Change-Id: If65ba8da760c0d9c0e79e71c8a2d2b6f240c5e9d
Reviewed-on: https://chromium-review.googlesource.com/c/1319849
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606209}
[modify] https://crrev.com/f08b6cda603489f807b9d9798b95482609372496/chrome/android/java/src/org/chromium/chrome/browser/vr/VrShell.java
[modify] https://crrev.com/f08b6cda603489f807b9d9798b95482609372496/chrome/browser/about_flags.cc
[modify] https://crrev.com/f08b6cda603489f807b9d9798b95482609372496/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/f08b6cda603489f807b9d9798b95482609372496/chrome/browser/android/chrome_feature_list.h
[modify] https://crrev.com/f08b6cda603489f807b9d9798b95482609372496/chrome/browser/android/vr/vr_gl_thread.cc
[modify] https://crrev.com/f08b6cda603489f807b9d9798b95482609372496/chrome/browser/android/vr/vr_gl_thread.h
[modify] https://crrev.com/f08b6cda603489f807b9d9798b95482609372496/chrome/browser/android/vr/vr_shell.cc
[modify] https://crrev.com/f08b6cda603489f807b9d9798b95482609372496/chrome/browser/android/vr/vr_shell.h
[modify] https://crrev.com/f08b6cda603489f807b9d9798b95482609372496/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/f08b6cda603489f807b9d9798b95482609372496/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/f08b6cda603489f807b9d9798b95482609372496/chrome/browser/vr/BUILD.gn
[modify] https://crrev.com/f08b6cda603489f807b9d9798b95482609372496/chrome/browser/vr/browser_ui_interface.h
[delete] https://crrev.com/e91c7821d50ac78a8496cafb1d794ad6a5b56a3a/chrome/browser/vr/elements/paged_grid_layout.cc
[delete] https://crrev.com/e91c7821d50ac78a8496cafb1d794ad6a5b56a3a/chrome/browser/vr/elements/paged_grid_layout.h
[delete] https://crrev.com/e91c7821d50ac78a8496cafb1d794ad6a5b56a3a/chrome/browser/vr/elements/paged_grid_layout_unittest.cc
[delete] https://crrev.com/e91c7821d50ac78a8496cafb1d794ad6a5b56a3a/chrome/browser/vr/elements/paged_scroll_view.cc
[delete] https://crrev.com/e91c7821d50ac78a8496cafb1d794ad6a5b56a3a/chrome/browser/vr/elements/paged_scroll_view.h
[modify] https://crrev.com/f08b6cda603489f807b9d9798b95482609372496/chrome/browser/vr/elements/ui_element_name.cc
[modify] https://crrev.com/f08b6cda603489f807b9d9798b95482609372496/chrome/browser/vr/elements/ui_element_name.h
[modify] https://crrev.com/f08b6cda603489f807b9d9798b95482609372496/chrome/browser/vr/model/color_scheme.cc
[modify] https://crrev.com/f08b6cda603489f807b9d9798b95482609372496/chrome/browser/vr/model/color_scheme.h
[modify] https://crrev.com/f08b6cda603489f807b9d9798b95482609372496/chrome/browser/vr/model/model.cc
[modify] https://crrev.com/f08b6cda603489f807b9d9798b95482609372496/chrome/browser/vr/model/model.h
[delete] https://crrev.com/e91c7821d50ac78a8496cafb1d794ad6a5b56a3a/chrome/browser/vr/model/tab_model.cc
[delete] https://crrev.com/e91c7821d50ac78a8496cafb1d794ad6a5b56a3a/chrome/browser/vr/model/tab_model.h
[modify] https://crrev.com/f08b6cda603489f807b9d9798b95482609372496/chrome/browser/vr/model/ui_mode.h
[modify] https://crrev.com/f08b6cda603489f807b9d9798b95482609372496/chrome/browser/vr/target_property.h
[modify] https://crrev.com/f08b6cda603489f807b9d9798b95482609372496/chrome/browser/vr/test/mock_browser_ui_interface.h
[modify] https://crrev.com/f08b6cda603489f807b9d9798b95482609372496/chrome/browser/vr/test/mock_ui_browser_interface.h
[modify] https://crrev.com/f08b6cda603489f807b9d9798b95482609372496/chrome/browser/vr/testapp/vr_test_context.cc
[modify] https://crrev.com/f08b6cda603489f807b9d9798b95482609372496/chrome/browser/vr/testapp/vr_test_context.h
[modify] https://crrev.com/f08b6cda603489f807b9d9798b95482609372496/chrome/browser/vr/ui.cc
[modify] https://crrev.com/f08b6cda603489f807b9d9798b95482609372496/chrome/browser/vr/ui.h
[modify] https://crrev.com/f08b6cda603489f807b9d9798b95482609372496/chrome/browser/vr/ui_browser_interface.h
[modify] https://crrev.com/f08b6cda603489f807b9d9798b95482609372496/chrome/browser/vr/ui_scene.cc
[modify] https://crrev.com/f08b6cda603489f807b9d9798b95482609372496/chrome/browser/vr/ui_scene.h
[modify] https://crrev.com/f08b6cda603489f807b9d9798b95482609372496/chrome/browser/vr/ui_scene_constants.h
[modify] https://crrev.com/f08b6cda603489f807b9d9798b95482609372496/chrome/browser/vr/ui_scene_creator.cc
[modify] https://crrev.com/f08b6cda603489f807b9d9798b95482609372496/chrome/browser/vr/ui_scene_creator.h
[modify] https://crrev.com/f08b6cda603489f807b9d9798b95482609372496/chrome/browser/vr/ui_unittest.cc
[modify] https://crrev.com/f08b6cda603489f807b9d9798b95482609372496/chrome/browser/vr/win/vr_browser_renderer_thread_win.cc

Comment 4 by tiborg@chromium.org, Nov 7

Status: Fixed (was: Started)
►

Sign in to add a comment