New issue
Advanced search Search tips

Issue 889976 link

Starred by 1 user
Status: Fixed
Owner:
wanderview@chromium.org
Closed: Oct 12
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 885347



Sign in to add a comment

add histogram to record why SimpleBackendImpl::FileStructureConsistent() fails

Project Member Reported by wanderview@chromium.org, Sep 27 
We are seeing some failures when cache_storage initializes its simple disk_cache backend.  This means the simple disk_cache failed to initialie.  There is logging in place for these failures, but it would be nice to have a histogram to see if any particular failure mode is most typical.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0cd1e985e07fb39916a3f3af2d3025833233329

commit c0cd1e985e07fb39916a3f3af2d3025833233329
Author: Ben Kelly <wanderview@chromium.org>
Date: Fri Oct 05 21:26:12 2018

Add SimpleCache.ConsistencyResult histogram.

When SimpleCache starts up it runs a consistency check and performs any
necessary version upgrades.  The cache_storage code is seeing SimpleCache
initialization fail on some devices.  This histogram will record why the
SimpleCache check and upgrade process is failing to help track down any
underlying problems.

R=morlovich@chromium.org

Bug:  889976 
Change-Id: I6072d7d11294d360d3ff48b44ae0531fce03e004
Reviewed-on: https://chromium-review.googlesource.com/c/1249961
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597306}
[modify] https://crrev.com/c0cd1e985e07fb39916a3f3af2d3025833233329/net/disk_cache/simple/simple_backend_impl.cc
[modify] https://crrev.com/c0cd1e985e07fb39916a3f3af2d3025833233329/net/disk_cache/simple/simple_backend_impl.h
[modify] https://crrev.com/c0cd1e985e07fb39916a3f3af2d3025833233329/net/disk_cache/simple/simple_index_file_unittest.cc
[modify] https://crrev.com/c0cd1e985e07fb39916a3f3af2d3025833233329/net/disk_cache/simple/simple_version_upgrade.cc
[modify] https://crrev.com/c0cd1e985e07fb39916a3f3af2d3025833233329/net/disk_cache/simple/simple_version_upgrade.h
[modify] https://crrev.com/c0cd1e985e07fb39916a3f3af2d3025833233329/net/disk_cache/simple/simple_version_upgrade_unittest.cc
[modify] https://crrev.com/c0cd1e985e07fb39916a3f3af2d3025833233329/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/c0cd1e985e07fb39916a3f3af2d3025833233329/tools/metrics/histograms/histograms.xml

Comment 2 by wanderview@chromium.org, Oct 12

Labels: M-71
Status: Fixed (was: Started)
►

Sign in to add a comment