New issue
Advanced search Search tips

Issue 889973 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Network file share gets mounted twice when same is mounted via both IP address & hostname

Project Member Reported by mkarkada@chromium.org, Sep 27

Issue description

Chrome OS version: 11021.28.0, 70.0.3538.34 beta-channel eve

What steps will reproduce the problem?
1. Goto Settings > Downloads > Network File Shares > Add File Share
2. Mount a network file share using IP address by entering “smb://<ip address of NAS>/testShare”
3. Again mount the same file share using the hostname by entering “smb://smbtest/testShare”
4. Open Files app 

What happens instead?
The same file share is mounted twice although the mounting methods were different.

What is the expected result?
File share must be mounted once. An error message to be displayed saying file share is already mounted.
 
Labels: -Pri-1 -M-70 M-71 Pri-2
I don't think this is urgent, so P2 and M-71. The restriction to only mount the same share once was put in place because early in the implementation the share path was the key to lookup the credential and we wanted to avoid a case where it was ambiguous (or we chose incorrectly) if someone mounted the same path but with 2 different credentials.

However now we don't have that problem so this restriction is somewhat arbitrary and actually prevents the valid case of potentially wanting to mount the same share with different credentials.

Besides some possibility of user confusion (though they did this themself), there's no reason we need to even try to prevent this any more. Plus there are 
 other things like using escape characters, DNS aliases (short vs fully qualfied) or shares having multiple IP's/interfaces that would make it unreliable to 100% prevent this.

In the case that DNS is used (vs mDNS or NetBIOS) the name resolution is transparent to us anyway so even trying to use the IP address as a more reliable indicator wouldn't be possible.

Also its possible that a user could mount 2 shares with different names, then DNS settings change so that they both now point to the same IP address, when we reboot/remount we wouldn't be able to do anything about that.

So I'd actually be inclined to remove the restriction all together. If the user wants to mount the same share twice, that's up to them and there's no technical reason we need to prevent it.
Labels: -M-71 M-72
Labels: -Restrict-View-Google -M-72 M-73
Labels: CrOSFilesFeature-SMB
Owner: ----
Status: Available (was: Assigned)
Let's remove the restriction altogether since we no longer map credentials to paths 
Labels: -M-73

Sign in to add a comment