New issue
Advanced search Search tips

Issue 889946 link

Starred by 1 user
Status: Duplicate
Merged: issue 872096
Owner:
frechette@chromium.org
Closed: Nov 6
Cc:
yyushkina@chromium.org
anthonyvd@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

"Translate to...." in context menu on desktop should reflect target language

Project Member Reported by yyushkina@chromium.org, Sep 27 
Right now we show the UI language 
: e.g. "Translate to English." even if I changed my target language to "French." I imagine the easiest way to do this is to make sure "translate to..." shows most recent target and falls back to UI language if a user has never translated.

Comment 1 by frechette@chromium.org, Nov 6 

This is a consequence of the target language always being the UI language with the baseline language model. Once we use a language model that actually returns the first accept language as a target, this problem will be fixed.

See how the context menu item is populated from the actual target language: https://cs.chromium.org/chromium/src/chrome/browser/renderer_context_menu/render_view_context_menu.cc?rcl=a9e4ec1adb5906b7186faeec89f4ddf82950ad16&l=1348.

Comment 2 by frechette@chromium.org, Nov 6

Mergedinto: 872096
Status: Duplicate (was: Assigned)
►

Sign in to add a comment