New issue
Advanced search Search tips

Issue 889940 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 29
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Skia change to antialiased textured-quad vertex calculation produces imperceptible layout image diffs

Project Member Reported by bsalo...@google.com, Sep 27

Issue description

These two tests will need to be rebaselined.
virtual/gpu/fast/canvas/canvas-drawImage-antiAlias.html
virtual/gpu-rasterization/images/cross-fade-background-size.html
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec20e3a25ba38639e0cad88672caebcb7c2d6622

commit ec20e3a25ba38639e0cad88672caebcb7c2d6622
Author: Brian Salomon <bsalomon@google.com>
Date: Thu Sep 27 18:21:20 2018

Add two GPU raster layout tests to TestExpectations pending rebaselining

Bug:  889940 
Change-Id: I282344fe5efa03933c86bb0a4f9d763521aebf67
Reviewed-on: https://chromium-review.googlesource.com/1249394
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Cr-Commit-Position: refs/heads/master@{#594790}
[modify] https://crrev.com/ec20e3a25ba38639e0cad88672caebcb7c2d6622/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb4b9ea75c3b039492373f114ab63f44aee476bc

commit cb4b9ea75c3b039492373f114ab63f44aee476bc
Author: Florin Malita <fmalita@chromium.org>
Date: Fri Oct 05 14:54:50 2018

Rebaseline pending Skia suppressions

virtual/gpu/fast/canvas/canvas-arc-circumference.html
virtual/gpu/fast/canvas/canvas-drawImage-antiAlias.html
virtual/gpu/fast/canvas/canvas-ellipse-circumference.html
virtual/gpu/fast/canvas/canvas-ellipse-circumference-fill.html
virtual/gpu/fast/canvas/fillrect_gradient.html
virtual/gpu/fast/canvas/gradient-add-second-start-end-stop.html
virtual/gpu-rasterization/images/cross-fade-background-size.html

TBR=

Bug: 884166, 889940 , 888675 , 802896 
Change-Id: I43312a60d4e8784cd915533bda5cf54141160adb
Reviewed-on: https://chromium-review.googlesource.com/c/1262895
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Stephen White <senorblanco@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597120}
[modify] https://crrev.com/cb4b9ea75c3b039492373f114ab63f44aee476bc/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/cb4b9ea75c3b039492373f114ab63f44aee476bc/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/fillrect_gradient-expected.png
[modify] https://crrev.com/cb4b9ea75c3b039492373f114ab63f44aee476bc/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/cross-fade-background-size-expected.png
[modify] https://crrev.com/cb4b9ea75c3b039492373f114ab63f44aee476bc/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/fillrect_gradient-expected.png
[modify] https://crrev.com/cb4b9ea75c3b039492373f114ab63f44aee476bc/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/cross-fade-background-size-expected.png
[modify] https://crrev.com/cb4b9ea75c3b039492373f114ab63f44aee476bc/third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/fillrect_gradient-expected.png
[modify] https://crrev.com/cb4b9ea75c3b039492373f114ab63f44aee476bc/third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/canvas-arc-circumference-expected.png
[modify] https://crrev.com/cb4b9ea75c3b039492373f114ab63f44aee476bc/third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/canvas-drawImage-antiAlias-expected.png
[modify] https://crrev.com/cb4b9ea75c3b039492373f114ab63f44aee476bc/third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/canvas-ellipse-circumference-expected.png
[add] https://crrev.com/cb4b9ea75c3b039492373f114ab63f44aee476bc/third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/canvas-ellipse-circumference-fill-expected.png
[modify] https://crrev.com/cb4b9ea75c3b039492373f114ab63f44aee476bc/third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/gradient-add-second-start-end-stop-expected.png

Status: Fixed (was: Started)

Sign in to add a comment