The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/050cab6ebf10c05442688f7fd0f11daefdf26bf7

commit 050cab6ebf10c05442688f7fd0f11daefdf26bf7
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Thu Sep 27 23:00:40 2018

[Extensions Bindings Cleanup] Constify extensions in bindings unittests

In practice, Extension objects are pretty much always const. Update the
native bindings unit tests to use const Extension objects, rather than
mutable ones. This makes the tests consistent (and removes the need for
a "mutable_extension" hack), and gets these ready for ExtensionBuilder
returning a const Extension.

Bug:  889925 

Change-Id: I44e1100515b055f5452f3ef90871a23d587b3f07
Reviewed-on: https://chromium-review.googlesource.com/1249528
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594907}
[modify] https://crrev.com/050cab6ebf10c05442688f7fd0f11daefdf26bf7/extensions/renderer/messaging_util_unittest.cc
[modify] https://crrev.com/050cab6ebf10c05442688f7fd0f11daefdf26bf7/extensions/renderer/native_extension_bindings_system_test_base.cc
[modify] https://crrev.com/050cab6ebf10c05442688f7fd0f11daefdf26bf7/extensions/renderer/native_extension_bindings_system_test_base.h
[modify] https://crrev.com/050cab6ebf10c05442688f7fd0f11daefdf26bf7/extensions/renderer/native_extension_bindings_system_unittest.cc
[modify] https://crrev.com/050cab6ebf10c05442688f7fd0f11daefdf26bf7/extensions/renderer/native_renderer_messaging_service_unittest.cc
[modify] https://crrev.com/050cab6ebf10c05442688f7fd0f11daefdf26bf7/extensions/renderer/one_time_message_handler_unittest.cc
[modify] https://crrev.com/050cab6ebf10c05442688f7fd0f11daefdf26bf7/extensions/renderer/runtime_hooks_delegate_unittest.cc
[modify] https://crrev.com/050cab6ebf10c05442688f7fd0f11daefdf26bf7/extensions/renderer/storage_area_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/854bc43f8000a151f698934d69592f5c222a3ef7

commit 854bc43f8000a151f698934d69592f5c222a3ef7
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Fri Sep 28 20:43:14 2018

[Extensions Cleanup] Constify extensions in api_unittest

In practice, Extension objects are pretty much always const. Update
extensions/browser/api_unittest.h to use const Extension objects, rather
than mutable ones.

Bug:  889925 
Change-Id: I7e13dac4376eb0e358a30e2fe49154976f02fb0d
Reviewed-on: https://chromium-review.googlesource.com/1252008
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595200}
[modify] https://crrev.com/854bc43f8000a151f698934d69592f5c222a3ef7/extensions/browser/api/alarms/alarms_api_unittest.cc
[modify] https://crrev.com/854bc43f8000a151f698934d69592f5c222a3ef7/extensions/browser/api_unittest.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3f6d956495c9798bd7fdd184c5ffc9700264bdf

commit f3f6d956495c9798bd7fdd184c5ffc9700264bdf
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Mon Oct 01 19:00:15 2018

[Extensions Cleanup] Remove api_test_utils::CreateExtension() variants

api_test_utils::CreateExtension() variants are no longer really useful
with the new-and-improved ExtensionBuilder class. Remove them to reduce
code and have one fewer ways of constructing test extension objects.

While we're at it, const-ify the creation sites.

TBR=atwilson@chromium.org
(just updating background_mode_manager_unittest to use a builder)

Bug:  889925 
Change-Id: I99087834e6b4c30a43c0badb0245295e0e1de525
Reviewed-on: https://chromium-review.googlesource.com/1252766
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595488}
[modify] https://crrev.com/f3f6d956495c9798bd7fdd184c5ffc9700264bdf/chrome/browser/background/background_mode_manager_unittest.cc
[modify] https://crrev.com/f3f6d956495c9798bd7fdd184c5ffc9700264bdf/chrome/browser/extensions/extension_api_unittest.cc
[modify] https://crrev.com/f3f6d956495c9798bd7fdd184c5ffc9700264bdf/chrome/browser/extensions/extension_message_bubble_controller_unittest.cc
[modify] https://crrev.com/f3f6d956495c9798bd7fdd184c5ffc9700264bdf/extensions/browser/api/alarms/alarms_api_unittest.cc
[modify] https://crrev.com/f3f6d956495c9798bd7fdd184c5ffc9700264bdf/extensions/browser/api/runtime/restart_after_delay_api_unittest.cc
[modify] https://crrev.com/f3f6d956495c9798bd7fdd184c5ffc9700264bdf/extensions/browser/api/system_display/system_display_apitest.cc
[modify] https://crrev.com/f3f6d956495c9798bd7fdd184c5ffc9700264bdf/extensions/browser/api_test_utils.cc
[modify] https://crrev.com/f3f6d956495c9798bd7fdd184c5ffc9700264bdf/extensions/browser/api_test_utils.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e5892fb8b75c048c5c066cc81f89e2b77204aaa

commit 8e5892fb8b75c048c5c066cc81f89e2b77204aaa
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Thu Oct 04 00:13:43 2018

[Extensions Cleanup] Constify ExtensionBuiler::Build()

In practice, Extension objects are pretty much always const. Update
ExtensionBuilder::Build() to return a const Extension object, rather
than a mutable one.

TBR=tapted@chromium.org (c/b/apps, c/b/ui, c/b/web_applications)
TBR=stevenjb@chromium.org (c/b/chromeos, c/b/notifications)
TBR=dalecurtis@chromium.org (c/b/media)
TBR=holte@chromium.org (c/b/metrics)
TBR=vakh@chromium.org (c/b/safe_browsing)
TBR=treib@chromium.org (c/b/supervised_user)
TBR=raymes@chromium.org (c/c/pepper_permission_util_unittest.cc)

Bug:  889925 
Change-Id: I7da674b29e209540803acfd40576c7daba3da2a3
Reviewed-on: https://chromium-review.googlesource.com/c/1256167
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596434}
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/apps/app_shim/extension_app_shim_handler_mac_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/chromeos/extensions/active_tab_permission_granter_delegate_chromeos_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/chromeos/extensions/extension_tab_util_delegate_chromeos_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/chromeos/extensions/gfx_utils_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/chromeos/extensions/permissions_updater_delegate_chromeos_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/chromeos/extensions/signin_screen_policy_provider_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/chromeos/lock_screen_apps/state_controller_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/chromeos/power/extension_event_observer_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/chromeos/power/renderer_freezer_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/extensions/activity_log/activity_log_enabled_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/extensions/api/declarative/rules_registry_service_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/extensions/api/declarative_content/content_action_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/extensions/api/declarative_content/declarative_content_is_bookmarked_condition_tracker_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/extensions/api/file_system/consent_provider_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/extensions/api/identity/identity_apitest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/extensions/api/notifications/notifications_apitest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/extensions/api/sessions/sessions_apitest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/extensions/api/tabs/tabs_interactive_test.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/extensions/api/tabs/tabs_test.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/extensions/api/web_request/web_request_apitest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_apitest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/extensions/error_console/error_console_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/extensions/extension_action_manager_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/extensions/extension_api_unittest.h
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/extensions/extension_garbage_collector_chromeos_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/extensions/extension_gcm_app_handler_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/extensions/extension_install_prompt_browsertest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/extensions/extension_migrator_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/extensions/extension_prefs_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/extensions/extension_protocols_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/extensions/extension_service_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/extensions/extension_web_ui_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/extensions/install_tracker_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/extensions/shared_module_service_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/extensions/test_extension_environment.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/extensions/test_extension_environment.h
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/extensions/test_extension_prefs.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/extensions/test_extension_prefs.h
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/extensions/update_install_gate_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/media/router/test/media_router_mojo_test.h
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/metrics/chrome_metrics_service_client_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/notifications/notification_permission_context_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/notifications/platform_notification_service_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/safe_browsing/chrome_cleaner/srt_delete_extension_win_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/safe_browsing/incident_reporting/extension_data_collection_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/supervised_user/supervised_user_service_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/ui/app_list/search/arc/arc_playstore_search_provider_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/ui/app_list/search/tests/app_search_provider_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/ui/ash/keyboard_controller_browsertest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/ui/media_router/media_router_ui_helper_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views_browsertest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/ui/views/extensions/extension_uninstall_dialog_view_browsertest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/ui/webui/policy_ui_browsertest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/browser/web_applications/extensions/pending_bookmark_app_manager_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/common/extensions/api/common_extension_api_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/common/extensions/api/file_browser_handlers/file_browser_handler_manifest_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/common/extensions/permissions/permission_set_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/common/pepper_permission_util_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/renderer/extensions/chrome_native_extension_bindings_system_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/renderer/extensions/custom_types_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/renderer/extensions/extension_hooks_delegate_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/renderer/extensions/i18n_hooks_delegate_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/chrome/renderer/extensions/tabs_hooks_delegate_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/extensions/browser/api/api_resource_manager_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/extensions/browser/api/bluetooth/bluetooth_apitest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/extensions/browser/api/bluetooth_socket/bluetooth_socket_api_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/extensions/browser/api/bluetooth_socket/bluetooth_socket_apitest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/extensions/browser/api/cast_channel/cast_channel_apitest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/extensions/browser/api/declarative/declarative_rule_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/extensions/browser/api/declarative/rules_registry_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/extensions/browser/api/dns/dns_apitest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/extensions/browser/api/power/power_api_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/extensions/browser/api/socket/socket_apitest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/extensions/browser/api/sockets_tcp/sockets_tcp_apitest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/extensions/browser/api/sockets_tcp_server/sockets_tcp_server_apitest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/extensions/browser/api/sockets_udp/sockets_udp_apitest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/extensions/browser/api/system_display/system_display_apitest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/extensions/browser/api/system_network/system_network_api_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/extensions/browser/app_window/app_window_geometry_cache_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/extensions/browser/event_router_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/extensions/browser/extension_registry_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/extensions/browser/info_map_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/extensions/browser/lazy_background_task_queue_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/extensions/browser/policy_check_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/extensions/browser/renderer_startup_helper_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/extensions/browser/runtime_data_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/extensions/browser/updater/update_service_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/extensions/common/extension_builder.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/extensions/common/extension_builder.h
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/extensions/common/manifest_handler_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/extensions/shell/browser/root_window_controller_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/extensions/shell/browser/shell_desktop_controller_aura_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/extensions/shell/browser/shell_native_app_window_aura_unittest.cc
[modify] https://crrev.com/8e5892fb8b75c048c5c066cc81f89e2b77204aaa/extensions/shell/browser/system_logs/shell_system_logs_fetcher_unittest.cc