New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 889914 link

Starred by 2 users
Status: Fixed
Owner:
gwendal@chromium.org
Closed: Sep 28
Cc:
█ rspangler@chromium.org
sdantul...@chromium.org
mkarkada@chromium.org
hungte@chromium.org
dhadd...@chromium.org
█ venkatar...@chromium.org
adurbin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

chromeos-firmwareupdate: Fail to update on scarlet

Project Member Reported by gwendal@chromium.org, Sep 27 
Using close to ToT version:
CHROMEOS_RELEASE_DESCRIPTION=11102.0.0 (Official Build) dev-channel scarlet-unibuild (dru) test

chromeos-firmwareupdate fails:
chromeos-firmwareupdate --mode autoupdate --debug
 (DEBUG) Using programs in system.
Model is dru
 (DEBUG) cros_acquire_lock: Set lock file to /tmp/chromeos-firmwareupdate-running.
 (DEBUG) No PD firmware bundled in updater, ignored.
Starting Google_Scarlet firmware updater v5 (autoupdate)...
 (DEBUG) No keysets folder.
*** Quirks for platform Google_Scarlet: min_platform_version=1
 (DEBUG) args: -i models/dru/bios.bin --ec_image models/dru/ec.bin --debug --quirks 'min_platform_version=1'
>> Firmware updater started.
DEBUG: setup_config_quirks: Looking for quirk <'min_platform_version=1>.
ERROR: setup_config_quirks: Unknown quirk: 'min_platform_version
>> FAILED: Firmware updater stopped due to error.
ERROR: Firmware update (autoupdate) failed.
ERROR: Execution failed: ./updater5.sh (error code = 1)

The problem is setup_config_quirks is not removing the "'" from the arguments.

Comment 1 by gwendal@chromium.org, Sep 27

Owner: gwendal@chromium.org
Status: Started (was: Untriaged)

Comment 2 by hungte@chromium.org, Sep 27 

The ' should not even be sent to updater - let's fix the script side (updater5).
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/firmware/+/324e7866a0e6d2f3a5387c408af2013480a2e301

commit 324e7866a0e6d2f3a5387c408af2013480a2e301
Author: Gwendal Grignou <gwendal@chromium.org>
Date: Fri Sep 28 13:26:14 2018

updater5: Fix "futility update" invocation

- expanding a shell variable won't really look at quotes (' or ").
- quirks do not really need space, so no quotes are needed.
- -i was repeated twice.

BUG= chromium:889914 
TEST=Check that invoking futility with quirks without '' works:
From:
*** Quirks for platform Google_Scarlet: min_platform_version=1
 (DEBUG) args: -i models/dru/bios.bin --ec_image models/dru/ec.bin
--debug --quirks 'min_platform_version=1'
>> Firmware updater started.
DEBUG: setup_config_quirks: Looking for quirk <'min_platform_version=1>.
To
futility update -t -i models/dru/bios.bin --ec_image models/dru/ec.bin
--debug --quirks min_platform_version=1
>> Firmware updater started.
DEBUG: setup_config_quirks: Looking for quirk <min_platform_version=1>.
DEBUG: setup_config_quirks: Set quirk min_platform_version to 1.

Change-Id: I811d89f66e46ea9609a8fc420f154ba9bab27ee6
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1249363
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/324e7866a0e6d2f3a5387c408af2013480a2e301/pack_dist/updater5.sh

Comment 4 by hungte@chromium.org, Sep 28

Status: Fixed (was: Started)

Comment 5 by hungte@chromium.org, Sep 28 

Note you need both new futility and chromeos-firmwareupdate to work.

Comment 6 by hungte@chromium.org, Sep 29

Cc: mkarkada@chromium.org dhadd...@chromium.org sdantul...@chromium.org venkatar...@chromium.org
 Issue 889951  has been merged into this issue.
►

Sign in to add a comment