New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 889912 link

Starred by 2 users
Status: WontFix
Owner:
█ digit@chromium.org
Last visit > 30 days ago
Closed: Oct 26
Cc:
heamy@chromium.org
js...@chromium.org
cjgrant@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 882860



Sign in to add a comment

Provide Android ICU data files containing tables for 9 more locales

Project Member Reported by digit@google.com, Sep 27 
As mentioned by jshin@, the current Android-specific ICU data file omits tables (e.g. collation data) for 9 locales that are currently omitted from regular Chrome APK builds.

We are however in the process of supporting these locales, and even more in the future, for application bundles. The bundle should thus include a version of the ICU data file that also supports these new locales.

This issue is to provide the following:

1) Provide a new Android-specific ICU data file that contains tables for the 9 missing locales. Note that this may be kept in parallel with the existing "restricted" file.

2) Adjust the build system to use the restricted data file for regular APKs (to avoid increasing their size), and the new "full" data file when building bundles.

Note that long-term, we may want to build the data files during the build, instead of relying on large prebuilt blobs. But there is a different issue to track this: https://bugs.chromium.org/p/chromium/issues/detail?id=632116

Comment 1 by digit@google.com, Oct 26

Status: WontFix (was: Assigned)
It turns out that the Android-specific ICU data file *does* include collation tables for the 9 omitted locales after all. So closing this as WontFix :)

A few more details though:

1) There is a comment in third_party/icu/README.chromium that suggests that
   the android/patch_locale.sh script actually removes the tables for our
   9 omitted locales. However, inspection of the script shows no such removal.

2) Manual inspection of the android/icudtl.dat file in a hex viewer shows
   various data tables for omitted locales like "kn" or "bn".

In theory, we should be able to remove these tables to reduce the size of the data file, in order to create two versions of it. However, I don't think it's really worth it right now, due to the amount of complexity this would add to our build system.

I believe there is a long standing plan to allow building the data files directly from GN build rules, instead on relying on ICU custom binaries, and that might be a better way to achieve this.

Another plan to reduce the size of the data file would be to split the file into multiple locale-related ones (if that makes sense), and spread them over language-based splits, but I'm unsure how easy that would be.
►

Sign in to add a comment