Remove prefs::kReverseAutologinEnabled & DisableOneClickSignIn |
|||
Issue descriptionThe preference is set but never read, so it is probably obsolete. The method DisableOneClickSignIn() just set the preference to false, so can also be removed if the preference is indeed obsolete.
,
Oct 4
I would like to fix this issue if no one working on this.
,
Oct 8
,
Oct 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e7d226c7a576e4b90de8460df4f11cff2e3cd0a commit 6e7d226c7a576e4b90de8460df4f11cff2e3cd0a Author: Jaeyong Bae <jdragon.bae@gmail.com> Date: Fri Oct 12 14:12:40 2018 Remove prefs::kReverseAutologinEnabled & DisableOneClickSignIn This patch means removing the preference and functions that reference it. Because preference is set but never read, that is indeed obsolete. Bug: 889908 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I22a80bed2387b08480dae9c930bb1d329dd8c45d Reviewed-on: https://chromium-review.googlesource.com/c/1264343 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#599200} [modify] https://crrev.com/6e7d226c7a576e4b90de8460df4f11cff2e3cd0a/chrome/browser/prefs/browser_prefs.cc [modify] https://crrev.com/6e7d226c7a576e4b90de8460df4f11cff2e3cd0a/chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc [modify] https://crrev.com/6e7d226c7a576e4b90de8460df4f11cff2e3cd0a/components/signin/core/browser/signin_manager.cc [modify] https://crrev.com/6e7d226c7a576e4b90de8460df4f11cff2e3cd0a/components/signin/core/browser/signin_manager.h [modify] https://crrev.com/6e7d226c7a576e4b90de8460df4f11cff2e3cd0a/components/signin/core/browser/signin_manager_base.cc [modify] https://crrev.com/6e7d226c7a576e4b90de8460df4f11cff2e3cd0a/components/signin/core/browser/signin_pref_names.cc [modify] https://crrev.com/6e7d226c7a576e4b90de8460df4f11cff2e3cd0a/components/signin/core/browser/signin_pref_names.h [modify] https://crrev.com/6e7d226c7a576e4b90de8460df4f11cff2e3cd0a/ios/chrome/browser/prefs/browser_prefs.mm
,
Oct 26
|
|||
►
Sign in to add a comment |
|||
Comment 1 by sdefresne@chromium.org
, Sep 27