New issue
Advanced search Search tips

Issue 889908 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 26
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Task

Blocking:
issue 883330



Sign in to add a comment

Remove prefs::kReverseAutologinEnabled & DisableOneClickSignIn

Project Member Reported by sdefresne@chromium.org, Sep 27

Issue description

The preference is set but never read, so it is probably obsolete. The method DisableOneClickSignIn() just set the preference to false, so can also be removed if the preference is indeed obsolete.

 
Labels: Proj-Servicification-VendorBug
I would like to fix this issue if no one working on this.
Owner: jdragon....@gmail.com
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e7d226c7a576e4b90de8460df4f11cff2e3cd0a

commit 6e7d226c7a576e4b90de8460df4f11cff2e3cd0a
Author: Jaeyong Bae <jdragon.bae@gmail.com>
Date: Fri Oct 12 14:12:40 2018

Remove prefs::kReverseAutologinEnabled & DisableOneClickSignIn

This patch means removing the preference and functions
that reference it.
Because preference is set but never read, that is indeed obsolete.

Bug:  889908 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I22a80bed2387b08480dae9c930bb1d329dd8c45d
Reviewed-on: https://chromium-review.googlesource.com/c/1264343
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599200}
[modify] https://crrev.com/6e7d226c7a576e4b90de8460df4f11cff2e3cd0a/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/6e7d226c7a576e4b90de8460df4f11cff2e3cd0a/chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc
[modify] https://crrev.com/6e7d226c7a576e4b90de8460df4f11cff2e3cd0a/components/signin/core/browser/signin_manager.cc
[modify] https://crrev.com/6e7d226c7a576e4b90de8460df4f11cff2e3cd0a/components/signin/core/browser/signin_manager.h
[modify] https://crrev.com/6e7d226c7a576e4b90de8460df4f11cff2e3cd0a/components/signin/core/browser/signin_manager_base.cc
[modify] https://crrev.com/6e7d226c7a576e4b90de8460df4f11cff2e3cd0a/components/signin/core/browser/signin_pref_names.cc
[modify] https://crrev.com/6e7d226c7a576e4b90de8460df4f11cff2e3cd0a/components/signin/core/browser/signin_pref_names.h
[modify] https://crrev.com/6e7d226c7a576e4b90de8460df4f11cff2e3cd0a/ios/chrome/browser/prefs/browser_prefs.mm

Status: Fixed (was: Started)

Sign in to add a comment