Long press with non-url should say 'Paste and Search' |
||||||
Issue descriptionPer crbug.com/746817 2) Menu has 2 items (non-URL string in pasteboard): "Copy | Paste and Search"
,
Sep 28
I don't think this is P2.
,
Oct 22
This is the current behavior. Updating title and description accordingly.
,
Oct 22
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c80d20d650a5e13df76ab1b08b5b27496d2d4ea2 commit c80d20d650a5e13df76ab1b08b5b27496d2d4ea2 Author: Robbie Gibson <rkgibson@google.com> Date: Wed Dec 19 12:59:28 2018 [iOS] Add url vs text for omnibox longpress menu This CL adds differentiation for copied urls vs copied text in the omnibox long-press menu. The two have different text on their buttons. Bug: 889905 Change-Id: Ic4f5ee3941731419343aaa41b7d4e84314a7759f Reviewed-on: https://chromium-review.googlesource.com/c/1377852 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#617812} [modify] https://crrev.com/c80d20d650a5e13df76ab1b08b5b27496d2d4ea2/ios/chrome/app/strings/ios_strings.grd [add] https://crrev.com/c80d20d650a5e13df76ab1b08b5b27496d2d4ea2/ios/chrome/app/strings/ios_strings_grd/IDS_IOS_SEARCH_COPIED_TEXT.png.sha1 [add] https://crrev.com/c80d20d650a5e13df76ab1b08b5b27496d2d4ea2/ios/chrome/app/strings/ios_strings_grd/IDS_IOS_VISIT_COPIED_LINK.png.sha1 [modify] https://crrev.com/c80d20d650a5e13df76ab1b08b5b27496d2d4ea2/ios/chrome/browser/ui/location_bar/BUILD.gn [modify] https://crrev.com/c80d20d650a5e13df76ab1b08b5b27496d2d4ea2/ios/chrome/browser/ui/location_bar/location_bar_view_controller.mm [modify] https://crrev.com/c80d20d650a5e13df76ab1b08b5b27496d2d4ea2/ios/chrome/browser/ui/omnibox/BUILD.gn [modify] https://crrev.com/c80d20d650a5e13df76ab1b08b5b27496d2d4ea2/ios/chrome/browser/ui/omnibox/omnibox_view_controller.mm
,
Dec 21
To Robbie :)
,
Jan 2
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by justincohen@chromium.org
, Sep 27