New issue
Advanced search Search tips

Issue 889903 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 17
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Task

Blocking:
issue 883330



Sign in to add a comment

Remove PrimaryAccountMutator APIs that intended to replace SigninManager::IsSignoutProhibited

Project Member Reported by sdefresne@chromium.org, Sep 27

Issue description

The method SigninManager::IsSignoutProhibited() should probably be moved to IdentityManager or IdentityMutator (see issue 889902) along with SigninManager::ProhibitSignOut().

In fact, they look like what the API for IsSigninAllowed() should ideally be.

 
Owner: chcunningham@chromium.org
Status: Fixed (was: Available)
This method was removed in https://chromium-review.googlesource.com/c/chromium/src/+/1162173/. Please reopen if there is some work that still needs to be done here :).
Labels: -Pri-1 Proj-Servicification-VendorBug Pri-2
Owner: ----
Status: Available (was: Fixed)
Summary: Remove PrimaryAccountMutator APIs that intended to replace SigninManager::IsSignoutProhibited (was: Provide IdentityManager APIs to replace SigninManager::IsSignoutProhibited)
Then we should probably remove the methods that were intended to replace those API from PrimaryAccountMutator. Re-opening (and renaming) bug.

This mean removing the following methods from PrimaryAccountMutator:
- IsClearingPrimaryAccountAllowed
- SetClearingPrimaryAccountAllowed
Labels: -Pri-2 Pri-1
Status: Started (was: Available)
Driven by, CL https://chromium-review.googlesource.com/c/chromium/src/+/1378989.
Owner: toniki...@chromium.org
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02d2a603883d494c18af9d2e5459cf8e36bf8693

commit 02d2a603883d494c18af9d2e5459cf8e36bf8693
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Mon Dec 17 13:00:10 2018

[s13n] Remove PrimaryAccountMutator APIs that intended to replace SigninManager::IsSignoutProhibited

This CL removes the following methods from PrimaryAccountMutator:

- IsClearingPrimaryAccountAllowed
- SetClearingPrimaryAccountAllowed

The methods were a replacement for SigninManager::IsSignoutProhibited()
and SigninManager::ProhibitSignOut(), but they got removed in
https://chromium-review.googlesource.com/c/chromium/src/+/1162173/.

BUG= 889903 

Change-Id: I959e5a6a8c02795284960042fa029b8395626c0d
Reviewed-on: https://chromium-review.googlesource.com/c/1378989
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617098}
[modify] https://crrev.com/02d2a603883d494c18af9d2e5459cf8e36bf8693/services/identity/public/cpp/primary_account_mutator.h
[modify] https://crrev.com/02d2a603883d494c18af9d2e5459cf8e36bf8693/services/identity/public/cpp/primary_account_mutator_impl.cc
[modify] https://crrev.com/02d2a603883d494c18af9d2e5459cf8e36bf8693/services/identity/public/cpp/primary_account_mutator_impl.h

Status: Fixed (was: Started)

Sign in to add a comment