Remove PrimaryAccountMutator APIs that intended to replace SigninManager::IsSignoutProhibited |
||||||
Issue descriptionThe method SigninManager::IsSignoutProhibited() should probably be moved to IdentityManager or IdentityMutator (see issue 889902) along with SigninManager::ProhibitSignOut(). In fact, they look like what the API for IsSigninAllowed() should ideally be.
,
Dec 14
Then we should probably remove the methods that were intended to replace those API from PrimaryAccountMutator. Re-opening (and renaming) bug. This mean removing the following methods from PrimaryAccountMutator: - IsClearingPrimaryAccountAllowed - SetClearingPrimaryAccountAllowed
,
Dec 14
,
Dec 17
Driven by, CL https://chromium-review.googlesource.com/c/chromium/src/+/1378989.
,
Dec 17
,
Dec 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/02d2a603883d494c18af9d2e5459cf8e36bf8693 commit 02d2a603883d494c18af9d2e5459cf8e36bf8693 Author: Antonio Gomes <tonikitoo@igalia.com> Date: Mon Dec 17 13:00:10 2018 [s13n] Remove PrimaryAccountMutator APIs that intended to replace SigninManager::IsSignoutProhibited This CL removes the following methods from PrimaryAccountMutator: - IsClearingPrimaryAccountAllowed - SetClearingPrimaryAccountAllowed The methods were a replacement for SigninManager::IsSignoutProhibited() and SigninManager::ProhibitSignOut(), but they got removed in https://chromium-review.googlesource.com/c/chromium/src/+/1162173/. BUG= 889903 Change-Id: I959e5a6a8c02795284960042fa029b8395626c0d Reviewed-on: https://chromium-review.googlesource.com/c/1378989 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#617098} [modify] https://crrev.com/02d2a603883d494c18af9d2e5459cf8e36bf8693/services/identity/public/cpp/primary_account_mutator.h [modify] https://crrev.com/02d2a603883d494c18af9d2e5459cf8e36bf8693/services/identity/public/cpp/primary_account_mutator_impl.cc [modify] https://crrev.com/02d2a603883d494c18af9d2e5459cf8e36bf8693/services/identity/public/cpp/primary_account_mutator_impl.h
,
Dec 17
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by blundell@chromium.org
, Dec 14Status: Fixed (was: Available)