New issue
Advanced search Search tips

Issue 889888 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Move checks from renderer to the browser process

Project Member Reported by na...@chromium.org, Sep 27

Issue description

Background Fetch has some checks in the renderer process for parity with Fetch. These include mixed content checks and CORS checks. These should happen in the browser process because it's more trusted.
 
Components: Blink>BackgroundFetch
Does this depend on issue 736308?
Hi Adam,

I've already got a CL out for the mixed content checks [here](https://chromium-review.googlesource.com/c/chromium/src/+/1230025)
The CORS check I was referring to, was only to block requests requiring CORS Preflight. Once network service supports CORS, we'll remove this check.
I have a CL in progress for the temporary check [here](https://chromium-review.googlesource.com/c/chromium/src/+/1249265)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e05f7e7ce194afc91a53bd0933be5a2187be2337

commit e05f7e7ce194afc91a53bd0933be5a2187be2337
Author: Mugdha Lakhani <nator@chromium.org>
Date: Thu Oct 04 16:53:21 2018

[Background Fetch] Move CORS preflight check to the controller.

Bug: 889888
Change-Id: I2429361627ffea2e1b8d5a11eb0e34b0cbfa1abb
Reviewed-on: https://chromium-review.googlesource.com/c/1249265
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596707}
[modify] https://crrev.com/e05f7e7ce194afc91a53bd0933be5a2187be2337/content/browser/background_fetch/background_fetch_job_controller.cc
[modify] https://crrev.com/e05f7e7ce194afc91a53bd0933be5a2187be2337/content/browser/background_fetch/background_fetch_job_controller.h
[modify] https://crrev.com/e05f7e7ce194afc91a53bd0933be5a2187be2337/content/browser/cache_storage/cache_storage_cache.cc
[modify] https://crrev.com/e05f7e7ce194afc91a53bd0933be5a2187be2337/third_party/WebKit/LayoutTests/external/wpt/background-fetch/fetch.https.window-expected.txt
[modify] https://crrev.com/e05f7e7ce194afc91a53bd0933be5a2187be2337/third_party/WebKit/LayoutTests/external/wpt/background-fetch/fetch.https.window.js
[modify] https://crrev.com/e05f7e7ce194afc91a53bd0933be5a2187be2337/third_party/WebKit/LayoutTests/http/tests/background_fetch/block-cors-preflights.https.html
[modify] https://crrev.com/e05f7e7ce194afc91a53bd0933be5a2187be2337/third_party/blink/renderer/modules/background_fetch/background_fetch_manager.cc

Sign in to add a comment