New issue
Advanced search Search tips

Issue 889879 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 1
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Task

Blocking:
issue 883330



Sign in to add a comment

Convert forced_reauthentication_dialog_view.cc to IdentityManager

Project Member Reported by sdefresne@chromium.org, Sep 27

Issue description

Methods used:
- SigninManagerBase::GetAuthenticatedAccountInfo()
- SigninManager::SignOut()

 
Owner: ma...@igalia.com
Status: Started (was: Available)
Taking this one
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/522b635b37a755c181a7a8eeccf3a3f34c229b67

commit 522b635b37a755c181a7a8eeccf3a3f34c229b67
Author: Mario Sanchez Prada <mario@igalia.com>
Date: Mon Oct 01 08:51:46 2018

Migrate ForcedReauthenticationDialogView to the IdentityManager

Use the IdentityManager APIs and update callers accordingly,
including calls from the associated test suite.

Bug:  889879 
Change-Id: I69c1c29d033602dd0c37618fefd71c5229ceacbe
Reviewed-on: https://chromium-review.googlesource.com/1251609
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#595407}
[modify] https://crrev.com/522b635b37a755c181a7a8eeccf3a3f34c229b67/chrome/browser/ui/forced_reauthentication_dialog.h
[modify] https://crrev.com/522b635b37a755c181a7a8eeccf3a3f34c229b67/chrome/browser/ui/views/profiles/forced_reauthentication_dialog_view.cc
[modify] https://crrev.com/522b635b37a755c181a7a8eeccf3a3f34c229b67/chrome/browser/ui/views/profiles/forced_reauthentication_dialog_view.h
[modify] https://crrev.com/522b635b37a755c181a7a8eeccf3a3f34c229b67/chrome/browser/ui/views/profiles/forced_reauthentication_dialog_view_browsertest.cc

Status: Fixed (was: Started)

Sign in to add a comment