Convert profile_info_watcher.cc to IdentityManager |
|||||
Issue descriptionMethods used: - SigninManagerBase::GetAuthenticatedAccountInfo() - prefs::kSigninAllowed
,
Oct 25
,
Oct 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc262267dce49a68a63f1bafe0a7f55d4eacc5b2 commit cc262267dce49a68a63f1bafe0a7f55d4eacc5b2 Author: Antonio Gomes <tonikitoo@igalia.com> Date: Thu Oct 25 16:35:57 2018 [s13n] Convert profile_info_watcher.cc to IdentityManager BUG= 889876 Change-Id: I91c04f9fa3a2189826ac6cd74728be3b6c329320 Reviewed-on: https://chromium-review.googlesource.com/c/1298773 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#602743} [modify] https://crrev.com/cc262267dce49a68a63f1bafe0a7f55d4eacc5b2/chrome/browser/ui/webui/profile_info_watcher.cc [modify] https://crrev.com/cc262267dce49a68a63f1bafe0a7f55d4eacc5b2/chrome/browser/ui/webui/profile_info_watcher.h
,
Oct 25
sdefresne: could you elaborate on what needs to be converted with |prefs::kSigninAllowed|?
,
Oct 26
+sdefresne (please see comment #4)
,
Nov 15
Hi Antonio, Apologies for the greatly-delayed response here! Sylvain and I chatted, and the answer is that nothing needs to be done; this bug was filed before we changed direction to have accessing the pref be the long-term direction for determining whether signin is allowed. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by sdefresne@chromium.org
, Sep 27