New issue
Advanced search Search tips

Issue 889874 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 31
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Task

Blocking:
issue 883330



Sign in to add a comment

Convert password_sync_util.cc to IdentityManager

Project Member Reported by sdefresne@chromium.org, Sep 27

Issue description

Methods used:
- SigninManagerBase::GetAuthenticatedAccountInfo()

 
Owner: toniki...@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/386ec91fcc487ff5330e544923bdfcc798076324

commit 386ec91fcc487ff5330e544923bdfcc798076324
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Wed Oct 31 16:29:33 2018

[s13n] Convert password_sync_util.cc to IdentityManager

This CL changes password_sync_util.cc|h and its various call sites to
work with IdentityManager rather than SigninManager.

There should be no functionality change, and the work is part of the
identity manager servicification (//services/identity) effort.
Specifically about IdentityManager, it wraps internally both
SigninManager and OAuth2TokenService objects, exposing a new API.

BUG= 889874 

Change-Id: I2014aff5a3fe4842d23f9c7610adbb9522f9e366
Reviewed-on: https://chromium-review.googlesource.com/c/1306153
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604288}
[modify] https://crrev.com/386ec91fcc487ff5330e544923bdfcc798076324/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/386ec91fcc487ff5330e544923bdfcc798076324/chrome/browser/ui/passwords/password_manager_presenter.cc
[modify] https://crrev.com/386ec91fcc487ff5330e544923bdfcc798076324/components/password_manager/core/browser/BUILD.gn
[modify] https://crrev.com/386ec91fcc487ff5330e544923bdfcc798076324/components/password_manager/core/browser/DEPS
[modify] https://crrev.com/386ec91fcc487ff5330e544923bdfcc798076324/components/password_manager/core/browser/password_sync_util.cc
[modify] https://crrev.com/386ec91fcc487ff5330e544923bdfcc798076324/components/password_manager/core/browser/password_sync_util.h
[modify] https://crrev.com/386ec91fcc487ff5330e544923bdfcc798076324/components/password_manager/core/browser/password_sync_util_unittest.cc
[modify] https://crrev.com/386ec91fcc487ff5330e544923bdfcc798076324/components/password_manager/core/browser/store_metrics_reporter.cc
[modify] https://crrev.com/386ec91fcc487ff5330e544923bdfcc798076324/components/password_manager/core/browser/store_metrics_reporter.h
[modify] https://crrev.com/386ec91fcc487ff5330e544923bdfcc798076324/components/password_manager/core/browser/store_metrics_reporter_unittest.cc
[modify] https://crrev.com/386ec91fcc487ff5330e544923bdfcc798076324/components/password_manager/core/browser/sync_credentials_filter.cc
[modify] https://crrev.com/386ec91fcc487ff5330e544923bdfcc798076324/components/password_manager/core/browser/sync_credentials_filter.h
[modify] https://crrev.com/386ec91fcc487ff5330e544923bdfcc798076324/components/password_manager/core/browser/sync_credentials_filter_unittest.cc
[modify] https://crrev.com/386ec91fcc487ff5330e544923bdfcc798076324/components/password_manager/core/browser/sync_username_test_base.cc
[modify] https://crrev.com/386ec91fcc487ff5330e544923bdfcc798076324/components/password_manager/core/browser/sync_username_test_base.h
[modify] https://crrev.com/386ec91fcc487ff5330e544923bdfcc798076324/ios/chrome/browser/passwords/ios_chrome_password_manager_client.mm

Status: Fixed (was: Started)

Sign in to add a comment