Issue metadata
Sign in to add a comment
|
NetworkServiceRestartBrowserTests failing (timeout) on chromium.memory/Linux TSan Tests |
||||||||||||||||||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of marinaciocea@google.com content_browsertests failing on chromium.memory/Linux TSan Tests Builders failed on: - Linux TSan Tests: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20TSan%20Tests Sample flaky tests timing out: NetworkServiceRestartBrowserTest.FetchFromServiceWorkerControlledPage_RespondWithFetch NetworkServiceRestartBrowserTest.FetchFromServiceWorkerControlledPage_PassThrough NetworkServiceRestartBrowserTest.FetchFromServiceWorkerControlledPage_NoFetchHandler Sample failed builds: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20TSan%20Tests/26542 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20TSan%20Tests/26540 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20TSan%20Tests/26536 Trace:
,
Sep 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dea06809039ade7489b95261d3539582a26b55b5 commit dea06809039ade7489b95261d3539582a26b55b5 Author: Marina Ciocea <marinaciocea@chromium.org> Date: Thu Sep 27 14:52:44 2018 Disable NetworkServiceRestartBrowserTests on chromium.memory/Linux TSan Tests. Disabled tests: NetworkServiceRestartBrowserTest.FetchFromServiceWorkerControlledPage_RespondWithFetch NetworkServiceRestartBrowserTest.FetchFromServiceWorkerControlledPage_PassThrough NetworkServiceRestartBrowserTest.FetchFromServiceWorkerControlledPage_NoFetchHandler TBR=shimazu@chromium.org Bug: 889855 Change-Id: I7215b4e074da8932725a2d6540cccf29eea823a3 Reviewed-on: https://chromium-review.googlesource.com/1249083 Reviewed-by: Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#594719} [modify] https://crrev.com/dea06809039ade7489b95261d3539582a26b55b5/content/browser/network_service_restart_browsertest.cc
,
Oct 8
Possibly related post: https://groups.google.com/a/chromium.org/d/msg/network-service-dev/b8oc-TBWbNs/658QdDW5AgAJ
,
Nov 14
These 3 tests are failing almost consistently on Android for UNKNOWN reason on asan-clang-phone. https://ci.chromium.org/buildbot/internal.client.clank/asan-clang-phone/ https://ci.chromium.org/buildbot/internal.client.clank/asan-clang-phone/4439 [ FAILED ] 3 tests, listed below: [ FAILED ] NetworkServiceRestartBrowserTest.FetchFromServiceWorkerControlledPage_NoFetchHandler (UNKNOWN) [ FAILED ] NetworkServiceRestartBrowserTest.FetchFromServiceWorkerControlledPage_PassThrough (UNKNOWN) [ FAILED ] NetworkServiceRestartBrowserTest.FetchFromServiceWorkerControlledPage_RespondWithFetch (UNKNOWN)
,
Nov 14
I will disable them on Android ASAN. Makoto, could you please take a look?
,
Nov 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3dff9cb43846a3f9a82da47cbe0cf23e7d650cf5 commit 3dff9cb43846a3f9a82da47cbe0cf23e7d650cf5 Author: Arthur Sonzogni <arthursonzogni@chromium.org> Date: Wed Nov 14 10:50:24 2018 Disable NetworkServiceRestartBrowserTests on Android ASan. Disabled tests: NetworkServiceRestartBrowserTest.FetchFromServiceWorkerControlledPage_RespondWithFetch NetworkServiceRestartBrowserTest.FetchFromServiceWorkerControlledPage_PassThrough NetworkServiceRestartBrowserTest.FetchFromServiceWorkerControlledPage_NoFetchHandler TBR=shimazu@chromium.org Bug: 889855 Change-Id: Ibbeb9faaf6d5d1657d893bf4d4c825045b1f0cbf Reviewed-on: https://chromium-review.googlesource.com/c/1335587 Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#607948} [modify] https://crrev.com/3dff9cb43846a3f9a82da47cbe0cf23e7d650cf5/content/browser/network_service_restart_browsertest.cc
,
Nov 15
I'm now starting to look at this issue. It looks like waiting for STOPPED forever since the worker seems already re-started when WaitForState(STOPPED) is called.
,
Nov 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2540a64831994cf0e880aaa88c26cc32ba77f106 commit 2540a64831994cf0e880aaa88c26cc32ba77f106 Author: Makoto Shimazu <shimazu@chromium.org> Date: Thu Nov 15 06:24:44 2018 Deflake NetworkServiceRestartBrowserTests on slower bots Previously ServiceWorkerObserver::WaitForState(STOPPED) starts to observe the state when it's called, but sometimes it's too slow and restarting the worker is already happening when starting to wait for state STOPPED. This CL fixes it by keeping all state changes and returning from WaitForState() if the observer saw the state previously at least once. Bug: 889855 Change-Id: Ide180fa49c9f47f68e1482b9a368b386648a3d4e Reviewed-on: https://chromium-review.googlesource.com/c/1337214 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#608279} [modify] https://crrev.com/2540a64831994cf0e880aaa88c26cc32ba77f106/content/browser/network_service_restart_browsertest.cc
,
Nov 15
I'll check if it's fixed tomorrow.
,
Nov 15
Thanks! Note to sherrif: The clank autoroller have issues (bug 904394). So disabling of the test doesn't show up on the bot. The next roll will probably contain "disabling of the test" AND "reenabling of the test + fix".
,
Nov 16
Flakiness dashboard looks good.
,
Nov 16
The NextAction date has arrived: 2018-11-16 |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by marinaciocea@chromium.org
, Sep 27Owner: shimazu@chromium.org
Status: Assigned (was: Available)