New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 889848 link

Starred by 4 users
Status: Fixed
Owner:
sa...@chromium.org
Closed: Nov 22
Cc:
ajha@chromium.org
weifangsun@chromium.org
fukino@chromium.org
█ brajkumar@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Non-Regression : Unnecessarily General information page gets refreshed after taking screenshot in File Manager

Project Member Reported by mmanchala@chromium.org, Sep 27 
Chrome Version:  71.0.3562.0/11104.0.0 dev channel Daisy,Kip and Reks
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User -> Open any Web page (Ex: New tab page)-> Save the page
(2)Page is saved with '.mhtml' extension -> Now Go to Files App -> Select saved page
and Right Click for Context Menu and select 'Get info' option or click on 'Space' Key
(3)Now in General information page observe content is displayed -> Now Press 'Ctrl+F5(Overview Mode Button)' for screenshot and observe unnecessarily page gets refreshed 
(Please refer Video)

Expected:  Unnecessarily General information page should not get refreshed after taking screenshot
Actual:  Instead  Unnecessarily General information page gets refreshed

This is Non-Regression Issue seen from M-63
Actual_PageRefreshes.mp4
15.3 MB Download

Comment 1 by mmanchala@chromium.org, Sep 27 

Attaching Expected video for reference
Expected_PageWillNotGetRefresh.mp4
12.9 MB View Download

Comment 2 by weifangsun@chromium.org, Oct 3

Labels: -M-71 CrOSFilesFeature-QuickView
Status: Available (was: Untriaged)

Comment 3 by sa...@chromium.org, Nov 22

Labels: Files-Fixit-2018
Owner: sa...@chromium.org
Status: Assigned (was: Available)

Comment 4 by sa...@chromium.org, Nov 22

Cc: fukino@chromium.org
 Issue 890301  has been merged into this issue.

Comment 5 by sa...@chromium.org, Nov 22

Cc: brajkumar@chromium.org
 Issue 835254  has been merged into this issue.
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e08ab349827622766cb4e0824df7fb77abe62634

commit e08ab349827622766cb4e0824df7fb77abe62634
Author: Sam McNally <sammc@chromium.org>
Date: Thu Nov 22 04:44:39 2018

Skip updating quickview if the new selected entry is the same as before.

Test: manual
Bug:  889848 
Change-Id: I4f7c510e28541bc596c46b8ccd16623dea27fd2b
Reviewed-on: https://chromium-review.googlesource.com/c/1347645
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610301}
[modify] https://crrev.com/e08ab349827622766cb4e0824df7fb77abe62634/ui/file_manager/file_manager/foreground/js/quick_view_controller.js

Comment 7 by sa...@chromium.org, Nov 22

Status: Fixed (was: Assigned)
►

Sign in to add a comment