New issue
Advanced search Search tips

Issue 889839 link

Starred by 1 user
Status: Fixed
Owner:
kmarshall@chromium.org
Closed: Sep 27
Cc:
scottmg@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 0
Type: Bug

Blocking:
issue 888476



Sign in to add a comment

fuchsia_sdk update fails

Project Member Reported by h...@chromium.org, Sep 27 
On two buildbots:
https://ci.chromium.org/buildbot/tryserver.chromium.mac/mac_upload_clang/405
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_upload_clang/348

And I get the same error locally on my Mac:

$ src/build/fuchsia/update_sdk.py
Downloading SDK ebbe4babd77b3b6a943ebc24daeeb48b1a2468d5...
Copying gs://fuchsia/sdk/mac-amd64/ebbe4babd77b3b6a943ebc24daeeb48b1a2468d5...
| [1 files][179.6 MiB/179.6 MiB]
Operation completed over 1 objects/179.6 MiB.
Creating directory /work/chromium/src/third_party/fuchsia-sdk/sdk
Traceback (most recent call last):
  File "/work/chromium/src/third_party/fuchsia-sdk/gen_build_defs.py", line 105, in <module>
    sys.exit(ConvertSdkManifests())
  File "/work/chromium/src/third_party/fuchsia-sdk/gen_build_defs.py", line 101, in ConvertSdkManifests
    stdout=open(os.devnull))
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 535, in check_call
    retcode = call(*popenargs, **kwargs)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 522, in call
    return Popen(*popenargs, **kwargs).wait()
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 710, in __init__
    errread, errwrite)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 1335, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory
Traceback (most recent call last):
  File "src/build/fuchsia/update_sdk.py", line 130, in <module>
    sys.exit(main())
  File "src/build/fuchsia/update_sdk.py", line 119, in main
    subprocess.check_call([os.path.join(sdk_root, 'gen_build_defs.py')])
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 540, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['/work/chromium/src/third_party/fuchsia-sdk/gen_build_defs.py']' returned non-zero exit status 1

Comment 1 by h...@chromium.org, Sep 27

Cc: kmarshall@chromium.org
gen_build_defs.py landed yesterday in
https://chromium-review.googlesource.com/1246681
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/712b34569c5dad99d67ad7ade9e4c456f61a3de0

commit 712b34569c5dad99d67ad7ade9e4c456f61a3de0
Author: Hans Wennborg <hans@chromium.org>
Date: Thu Sep 27 11:37:46 2018

Revert "[fuchsia] Reland "Generate BUILD.gn from SDK metadata...""

This reverts commit 386fa9a70028f97ce511bc7bf84e5ce96e47f926.

Reason for revert:
Broke the fuchsia_sdk update step, see bug.

Original change's description:
> [fuchsia] Reland "Generate BUILD.gn from SDK metadata..."
> 
> Reland of CL https://chromium-review.googlesource.com/c/chromium/src/+/1241842.
> (Confirmed that the code builds on Cast builders, and manually examined
> all references to targets under //third_party/fuchsia-sdk to verify
> that all FIDL targets have been modified to reference the new sdk/
> subdir.)
> 
> This script uses the metadata JSON files in the SDK to generate a
> BUILD.gn in //third_party/fuchsia-sdk/sdk. The build file is
> regenerated whenever a new SDK is downloaded using "gclient sync".
> 
> Only FIDL libraries are migrated for now. Additional metadata types can
> be migrated in followup CLs.
> 
> TBR=scottmg@chromium.org
> TBR=sky@chromium.org
> 
> Bug:  888753 
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: I7ec714982cdfbb6f6ccd8fad3cd7cbb48af4eb1c
> Reviewed-on: https://chromium-review.googlesource.com/1246681
> Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
> Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#594419}

TBR=kmarshall@chromium.org

Change-Id: I1a89a1c3d8223e6dd58e2a4b23f251eb96a7bba8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  888753 ,  889839 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1249203
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594671}
[modify] https://crrev.com/712b34569c5dad99d67ad7ade9e4c456f61a3de0/build/fuchsia/update_sdk.py
[modify] https://crrev.com/712b34569c5dad99d67ad7ade9e4c456f61a3de0/chromecast/media/cma/backend/fuchsia/BUILD.gn
[modify] https://crrev.com/712b34569c5dad99d67ad7ade9e4c456f61a3de0/content/common/BUILD.gn
[modify] https://crrev.com/712b34569c5dad99d67ad7ade9e4c456f61a3de0/content/shell/BUILD.gn
[modify] https://crrev.com/712b34569c5dad99d67ad7ade9e4c456f61a3de0/media/audio/BUILD.gn
[modify] https://crrev.com/712b34569c5dad99d67ad7ade9e4c456f61a3de0/net/BUILD.gn
[modify] https://crrev.com/712b34569c5dad99d67ad7ade9e4c456f61a3de0/skia/BUILD.gn
[modify] https://crrev.com/712b34569c5dad99d67ad7ade9e4c456f61a3de0/third_party/fuchsia-sdk/BUILD.gn
[modify] https://crrev.com/712b34569c5dad99d67ad7ade9e4c456f61a3de0/third_party/fuchsia-sdk/fuchsia_sdk_pkg.gni
[delete] https://crrev.com/c354aa9af805705f827519f7c87522e8f21634f1/third_party/fuchsia-sdk/gen_build_defs.py
[modify] https://crrev.com/712b34569c5dad99d67ad7ade9e4c456f61a3de0/tools/fuchsia/local-sdk.py
[modify] https://crrev.com/712b34569c5dad99d67ad7ade9e4c456f61a3de0/ui/base/ime/BUILD.gn
[modify] https://crrev.com/712b34569c5dad99d67ad7ade9e4c456f61a3de0/ui/events/BUILD.gn
[modify] https://crrev.com/712b34569c5dad99d67ad7ade9e4c456f61a3de0/ui/ozone/demo/BUILD.gn
[modify] https://crrev.com/712b34569c5dad99d67ad7ade9e4c456f61a3de0/ui/ozone/platform/scenic/BUILD.gn
[modify] https://crrev.com/712b34569c5dad99d67ad7ade9e4c456f61a3de0/ui/platform_window/BUILD.gn
[modify] https://crrev.com/712b34569c5dad99d67ad7ade9e4c456f61a3de0/webrunner/BUILD.gn
[modify] https://crrev.com/712b34569c5dad99d67ad7ade9e4c456f61a3de0/webrunner/net_http/BUILD.gn

Comment 4 by h...@chromium.org, Sep 27

Blocking: 888476

Comment 6 by h...@chromium.org, Sep 27 

[1/1] Regenerating ninja files                                                                        
ninja: error: '../../third_party/fuchsia-sdk/sdk/fidl/fuchsia.media/audio_in.fidl', needed by 'gen/third_party/fuchsia-sdk/media.rsp', missing and no known rule to make it
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6be9416cc5578fd8561dfcf2f578e904f824c624

commit 6be9416cc5578fd8561dfcf2f578e904f824c624
Author: Hans Wennborg <hans@chromium.org>
Date: Thu Sep 27 12:05:01 2018

Revert "Roll Fuchsia SDK from 98ba6c8440c2 to b9dd8279f122"

This reverts commit 8ce5e80eb25191d3c5b25406ef3ebd08d98313d8.

Reason for revert:
It depended on #594419 which has been reverted, see bug.

Original change's description:
> Roll Fuchsia SDK from 98ba6c8440c2 to b9dd8279f122
> 
> The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
> 
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
> 
> If the roll is causing failures, please contact the current sheriff, who should
> be CC'd on the roll, and stop the roller if necessary.
> 
> 
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
> TBR=cr-fuchsia+bot@chromium.org
> TBR=sergeyu@chromium.org
> TBR=mmenke@chromium.org
> 
> Change-Id: I470f7f3a9b10ed9c31b40b02e1f5a01a36ff25f4
> Reviewed-on: https://chromium-review.googlesource.com/1246955
> Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
> Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#594479}

TBR=kmarshall@chromium.org,cr-fuchsia+bot@chromium.org
Bug:  889839 

Change-Id: I30b99003450fab8abdcc1c7751d264c5ae77a0aa
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
Reviewed-on: https://chromium-review.googlesource.com/1249105
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594681}
[modify] https://crrev.com/6be9416cc5578fd8561dfcf2f578e904f824c624/build/fuchsia/linux.sdk.sha1
[modify] https://crrev.com/6be9416cc5578fd8561dfcf2f578e904f824c624/build/fuchsia/mac.sdk.sha1
[modify] https://crrev.com/6be9416cc5578fd8561dfcf2f578e904f824c624/net/base/network_change_notifier_fuchsia_unittest.cc

Comment 9 by h...@chromium.org, Sep 27 

I forgot to set the Bug field on it, but this revert was needed before the others: https://chromium-review.googlesource.com/c/chromium/src/+/1249262

Comment 10 by h...@chromium.org, Sep 27

Cc: -kmarshall@chromium.org
Owner: kmarshall@chromium.org
Status: Fixed (was: Untriaged)
Things seem to be working now.

Comment 11 by thakis@chromium.org, Sep 27

Cc: scottmg@chromium.org
Possibly related is  https://chromium-review.googlesource.com/1217464
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f10ee89e7ecf8142fa85cc557b5d1cfedf231346

commit f10ee89e7ecf8142fa85cc557b5d1cfedf231346
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Tue Oct 02 01:45:37 2018

Reland SDK manifest generation script & SDK rolls.

The issue which prompted reverts on "mac_upload_clang" and
"linux_upload_clang" had to do with incorrect platform-specific
paths to the GN tool.

Summary of reverts:
Reland "Revert "Roll Fuchsia SDK from 98ba6c8440c2 to b9dd8279f122""
This reverts commit 6be9416cc5578fd8561dfcf2f578e904f824c624.

Reland "Revert "[Fuchsia] Remove namespace_path parameter from FIDL targets""
This reverts commit c354aa9af805705f827519f7c87522e8f21634f1.

Reland "Revert "[fuchsia] Reland "Generate BUILD.gn from SDK metadata..."""
This reverts commit 712b34569c5dad99d67ad7ade9e4c456f61a3de0.

TBR=sky@chromium.org

Bug:  889839 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I46650fb6c7887393c409bd13d9f0851a5630c88e
Reviewed-on: https://chromium-review.googlesource.com/1252013
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595689}
[modify] https://crrev.com/f10ee89e7ecf8142fa85cc557b5d1cfedf231346/base/BUILD.gn
[modify] https://crrev.com/f10ee89e7ecf8142fa85cc557b5d1cfedf231346/build/config/fuchsia/fidl_library.gni
[modify] https://crrev.com/f10ee89e7ecf8142fa85cc557b5d1cfedf231346/build/fuchsia/linux.sdk.sha1
[modify] https://crrev.com/f10ee89e7ecf8142fa85cc557b5d1cfedf231346/build/fuchsia/mac.sdk.sha1
[modify] https://crrev.com/f10ee89e7ecf8142fa85cc557b5d1cfedf231346/build/fuchsia/update_sdk.py
[modify] https://crrev.com/f10ee89e7ecf8142fa85cc557b5d1cfedf231346/chromecast/media/cma/backend/fuchsia/BUILD.gn
[modify] https://crrev.com/f10ee89e7ecf8142fa85cc557b5d1cfedf231346/content/common/BUILD.gn
[modify] https://crrev.com/f10ee89e7ecf8142fa85cc557b5d1cfedf231346/content/shell/BUILD.gn
[modify] https://crrev.com/f10ee89e7ecf8142fa85cc557b5d1cfedf231346/media/audio/BUILD.gn
[modify] https://crrev.com/f10ee89e7ecf8142fa85cc557b5d1cfedf231346/net/BUILD.gn
[modify] https://crrev.com/f10ee89e7ecf8142fa85cc557b5d1cfedf231346/skia/BUILD.gn
[modify] https://crrev.com/f10ee89e7ecf8142fa85cc557b5d1cfedf231346/third_party/fuchsia-sdk/BUILD.gn
[modify] https://crrev.com/f10ee89e7ecf8142fa85cc557b5d1cfedf231346/third_party/fuchsia-sdk/fuchsia_sdk_pkg.gni
[add] https://crrev.com/f10ee89e7ecf8142fa85cc557b5d1cfedf231346/third_party/fuchsia-sdk/gen_build_defs.py
[modify] https://crrev.com/f10ee89e7ecf8142fa85cc557b5d1cfedf231346/tools/fuchsia/local-sdk.py
[modify] https://crrev.com/f10ee89e7ecf8142fa85cc557b5d1cfedf231346/ui/base/ime/BUILD.gn
[modify] https://crrev.com/f10ee89e7ecf8142fa85cc557b5d1cfedf231346/ui/events/BUILD.gn
[modify] https://crrev.com/f10ee89e7ecf8142fa85cc557b5d1cfedf231346/ui/ozone/demo/BUILD.gn
[modify] https://crrev.com/f10ee89e7ecf8142fa85cc557b5d1cfedf231346/ui/ozone/platform/scenic/BUILD.gn
[modify] https://crrev.com/f10ee89e7ecf8142fa85cc557b5d1cfedf231346/ui/platform_window/BUILD.gn
[modify] https://crrev.com/f10ee89e7ecf8142fa85cc557b5d1cfedf231346/webrunner/BUILD.gn
[modify] https://crrev.com/f10ee89e7ecf8142fa85cc557b5d1cfedf231346/webrunner/net_http/BUILD.gn
►

Sign in to add a comment