[NTP]Shortcut icons appear chopped on resizing browser window
Reported by
vineetha...@etouch.net,
Sep 27
|
||||||||
Issue descriptionChrome Version: 70.0.3538.37 (Official Build) Revision 53f287561c37d0074842843cca3b4ac3560a4459-refs/branch-heads/3538@{#693}(32/64 bit) OS: Windows(7,8,8.1,10), Mac (10.12.6, 10.13.1, 10.13.6, 10.14) and Linux(14.04) Pre-condition: Enable "Enable using the Google local NTP" ,"New Tab Page Background Selection" and "New Tab Page Custom Links" flags under chrome://flags. What steps will reproduce the problem? (1) Launch chrome and open NTP. (2) Add at least 10 shortcuts on the NTP. (3) Resize the browser window from RHS to the maximum (observe shortcuts are displayed 3 in a row). (4) Press tab to traverse focus to the 'Add Shortcut' button. (5) Now press Shift + tab to take focus to shortcuts in the second row and observe. Actual : Shortcut icons appear chopped on resizing browser window. Expected: Shortcut icons should not appear chopped on resizing browser window. This is a non-regression issue, seen from M70. Thank you.
,
Sep 27
I'm a bit confused by the labels - the description indicates M70, but the label indicates FoundIn-71. Please clarify. I cannot repro on 71.0.3562.0 on Mac. cc'ing Kristi in case this was a known & fixed issue.
,
Sep 27
Tested on 71.0.3563.0 on Mac, and resizing alone does not cut off the tiles. However tabbing does "scroll" previously hidden tiles into view, which is not intended behavior. The screencast probably was in a state where the tiles were already scrolled before the window was resized to the initial size. This is also present in current stable (local and remote).
,
Sep 27
,
Sep 28
Update with respect to comment #2, Regarding labels, for Non-Regression issues i.e. 1. If the bug is newly discovered but has been around for many previous milestones (Ex: existing since M60) or 2. If the bug is found in a newly introduced feature Then, in both the above cases we just apply the current canary milestone. Rechecked the above issue using latest Canary #71.0.3564.0 on Windows(7,8,8.1,10), Mac (10.12.6, 10.13.1, 10.13.6, 10.14) and Linux(14.04) and the issue is reproducible. Kindly refer attached screen cast. Thank you
,
Sep 28
Ramya, as per the original report this bug is found in M70 as well, updating now.
,
Sep 28
,
Oct 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/30b891346bd02d47d1b6b9dd09afd81306b7ad07 commit 30b891346bd02d47d1b6b9dd09afd81306b7ad07 Author: Kristi Park <kristipark@chromium.org> Date: Mon Oct 01 21:58:04 2018 [NTP] Explicitly hide MV tiles that are not visible This will prevent keyboard navigation from reaching tiles that are not visible. Screencast: https://screencast.googleplex.com/cast/NTQ4MTM0NjE3MjQ1Mjg2NHxkYjlmMjExNy0zOQ Bug: 889792 Change-Id: Id4c327417d97d9fa0b28f94fd3f98ddf97c4fc1d Reviewed-on: https://chromium-review.googlesource.com/1252377 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by: Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#595545} [modify] https://crrev.com/30b891346bd02d47d1b6b9dd09afd81306b7ad07/chrome/browser/resources/local_ntp/most_visited_single.js
,
Oct 1
,
Oct 3
Update : Rechecked the above issue on Win(7,8,8.1,10) ,Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14.1) and Linux(14.04 LTS)OS with Canary version #71.0.3569.0 and the issue is still reproducible. Kindly refer the attached screen cast.
,
Oct 3
Apologies, there was a bug in the previous change. This has been addressed in https://chromium-review.googlesource.com/c/chromium/src/+/1257664 and should fixed in the next Canary.
,
Oct 4
Update : Rechecked the above issue on Win(7,8,8.1,10) ,Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14.1) and Linux(14.04 LTS)OS with Canary version #71.0.3570.0 and the issue is fixed. Kindly refer the attached screen cast. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by vineetha...@etouch.net
, Sep 27851 KB
851 KB View Download