Update:
--
Above issue is also reproducible in Canary #71.0.3562.0 on Windows(7,8,10) and Linux(14.04 LTS) OS.

Deleted: icon_focus.png 9.5 KB

	icon_focus.png 9.5 KB View Download

+pbos

I've taken a look and they are all the same color.

However, they are lighter than the spec, which specifies GG900 @ 10% for hover, and GG900 @ 16% for press.

From what I can tell, this is because the color is derived from the native theme:

SkColor LocationBarView::GetIconInkDropColor() const {
  return GetNativeTheme()->GetSystemColor(
      ui::NativeTheme::kColorId_TextfieldDefaultColor);
}

This doesn't necessarily match the spec provided by designers.

Do we want to match the native theme, or the spec?

I think we need to derive the color from the native theme, or we'll mismatch badly if the native theme provides something not-really-close-to-black. If they all match I think you can WontFix this.

+pbos: Thanks for the extra context. I agree with you that sticking with NativeTheme seems the most important.

You can have your cake and eat it too.

The right thing to do is to compute what the contrast ratio of GG900 @ 10%/16% would be with the default colors; compute the actual overlay color as either BlendTowardOppositeLuma(omnibox_background_color, SK_AlphaOPAQUE) or the native textfield color; then use color_utils::FindBlendValueForContrastRatio(omnibox_background_color, overlay_color, omnibox_background_color, desired_contrast, 0) to compute the correct alpha to use that matches the desired contrast.

Whether you want to use the textfield color route or the BlendTowardOppositeLuma() route here depends on what effect you want if, say, the native theme asks for red text.  Do you want all your omnibox ink drops to turn red?  Then use the textfield color.  Do you just want them to use greyscale contrast with the background regardless?  Then use the BlendTowardOppositeLuma() route.  Personally, I would go the BlendTowardOppositeLuma() route; I'm not convinced that the text color should also dictate the ink drop colors, and the color_utils call above should ensure that we still have good contrast.