Flaky test: ExtensionWebstorePrivateApiTest.InstallAccepted Sample failed build due to flakiness: https://chromium-swarm.appspot.com/task?id=4032438c89d53410 Test output log: https://ci.chromium.org/buildbot/chromium.win/Win10%20Tests%20x64/27918 Culprit (78.8% confidence): https://chromium-review.googlesource.com/q/I2f0cd71815a08bcddfca753378543749389d78db Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyvAELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKFAWNocm9taXVtLndpbi9XaW4xMCBUZXN0cyB4NjQvMjc5MTgvYnJvd3Nlcl90ZXN0cyBvbiBXaW5kb3dzLTEwLTE1MDYzL1JYaDBaVzV6YVc5dVYyVmljM1J2Y21WUWNtbDJZWFJsUVhCcFZHVnpkQzVKYm5OMFlXeHNRV05qWlhCMFpXUT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA Please revert the culprit, or disable the test and find the appropriate owner. If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20ExtensionWebstorePrivateApiTest.InstallAccepted&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyvAELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKFAWNocm9taXVtLndpbi9XaW4xMCBUZXN0cyB4NjQvMjc5MTgvYnJvd3Nlcl90ZXN0cyBvbiBXaW5kb3dzLTEwLTE1MDYzL1JYaDBaVzV6YVc5dVYyVmljM1J2Y21WUWNtbDJZWFJsUVhCcFZHVnpkQzVKYm5OMFlXeHNRV05qWlhCMFpXUT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/50db3d6ab7f88f43fcf010513859959ddf291555 commit 50db3d6ab7f88f43fcf010513859959ddf291555 Author: Marina Ciocea <marinaciocea@chromium.org> Date: Thu Sep 27 13:10:44 2018 Revert "Download Shelf : Connect OfflineItem to the shelf" This reverts commit e6f5eba3b2be98ba20ead82a46e4f7963a71111d. Reason for revert: looks related to the Win10 Test flakiness reported by findit. Original change's description: > Download Shelf : Connect OfflineItem to the shelf > > This CL connects offline item with the download shelf. Some of > the OfflineItemModel methods are still not implemented. > > Bug: 881499 > Change-Id: I2f0cd71815a08bcddfca753378543749389d78db > Reviewed-on: https://chromium-review.googlesource.com/1239875 > Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> > Reviewed-by: Carlos Knippschild <carlosk@chromium.org> > Reviewed-by: Min Qin <qinmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594471} TBR=qinmin@chromium.org,carlosk@chromium.org,shaktisahu@chromium.org Change-Id: I98129d5eaca139d27ab7bb15f3ca194efb1331c6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 881499, 889790 Reviewed-on: https://chromium-review.googlesource.com/1249068 Reviewed-by: Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#594697} [modify] https://crrev.com/50db3d6ab7f88f43fcf010513859959ddf291555/chrome/browser/download/download_core_service_impl.cc [modify] https://crrev.com/50db3d6ab7f88f43fcf010513859959ddf291555/chrome/browser/download/download_core_service_impl.h [modify] https://crrev.com/50db3d6ab7f88f43fcf010513859959ddf291555/chrome/browser/download/download_item_model.cc [modify] https://crrev.com/50db3d6ab7f88f43fcf010513859959ddf291555/chrome/browser/download/download_item_model.h [modify] https://crrev.com/50db3d6ab7f88f43fcf010513859959ddf291555/chrome/browser/download/download_shelf.cc [modify] https://crrev.com/50db3d6ab7f88f43fcf010513859959ddf291555/chrome/browser/download/download_shelf.h [modify] https://crrev.com/50db3d6ab7f88f43fcf010513859959ddf291555/chrome/browser/download/download_shelf_controller.cc [modify] https://crrev.com/50db3d6ab7f88f43fcf010513859959ddf291555/chrome/browser/download/download_shelf_controller.h [modify] https://crrev.com/50db3d6ab7f88f43fcf010513859959ddf291555/chrome/browser/download/download_shelf_unittest.cc [modify] https://crrev.com/50db3d6ab7f88f43fcf010513859959ddf291555/chrome/browser/download/download_ui_controller.cc [modify] https://crrev.com/50db3d6ab7f88f43fcf010513859959ddf291555/chrome/browser/download/offline_item_model.cc [modify] https://crrev.com/50db3d6ab7f88f43fcf010513859959ddf291555/chrome/browser/download/offline_item_model.h [modify] https://crrev.com/50db3d6ab7f88f43fcf010513859959ddf291555/chrome/browser/download/offline_item_model_manager_factory.cc [modify] https://crrev.com/50db3d6ab7f88f43fcf010513859959ddf291555/chrome/browser/download/offline_item_model_manager_factory.h [modify] https://crrev.com/50db3d6ab7f88f43fcf010513859959ddf291555/chrome/browser/download/offline_item_utils.cc [modify] https://crrev.com/50db3d6ab7f88f43fcf010513859959ddf291555/chrome/browser/download/offline_item_utils.h [modify] https://crrev.com/50db3d6ab7f88f43fcf010513859959ddf291555/chrome/browser/download/test_download_shelf.cc [modify] https://crrev.com/50db3d6ab7f88f43fcf010513859959ddf291555/chrome/browser/download/test_download_shelf.h [modify] https://crrev.com/50db3d6ab7f88f43fcf010513859959ddf291555/chrome/browser/offline_pages/android/offline_page_bridge.cc [modify] https://crrev.com/50db3d6ab7f88f43fcf010513859959ddf291555/chrome/browser/ui/views/download/download_shelf_view.cc [modify] https://crrev.com/50db3d6ab7f88f43fcf010513859959ddf291555/chrome/browser/ui/views/download/download_shelf_view.h [modify] https://crrev.com/50db3d6ab7f88f43fcf010513859959ddf291555/components/offline_items_collection/core/launch_location.h
Shakti, please have a look
Comment 1 by bugdroid1@chromium.org
, Sep 27