New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 889783 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 1
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:[NTP]'Can't Create shortcut' confirmation message is not displayed on creating duplicate shortcut

Reported by vineetha...@etouch.net, Sep 27

Issue description

Chrome Version: 70.0.3538.37 (Official Build) Revision 53f287561c37d0074842843cca3b4ac3560a4459-refs/branch-heads/3538@{#693}(32/64-Bit)
OS: Windows(7,8,8.1,10), Mac (10.12.6, 10.13.1, 10.13.6, 10.14) and Linux (14.04 LTS)

Steps to reproduce:
1.Launch chrome and navigate to chrome://restart and relaunch browser.
2.Navigate to NTP and add a shortcut by clicking on 'Add Shortcut' button.
3.Now add another shortcut with the same URL used for the previously added shortcut and observe the confirmation message.

Actual Result  : 'Can't Create shortcut' confirmation message is not displayed.
Expected Result: 'Can't Create shortcut' confirmation message should be displayed on creating a new shortcut using existing URL.

This is a regression issue, broken in 'M-70', and below is the bisect info:
Good Build:70.0.3537.0 (Revision: 587303)
Bad Build :70.0.3538.0 (Revision: 587811)

Change-Log URL: https://chromium.googlesource.com/chromium/src/+log/70.0.3537.0..70.0.3538.0?pretty=fuller&n=10000 

Suspecting:r587313?

@kristipark: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note:
1. Providing suspect through 'Change-Log' because unable to perform bisect using 'per-revision' and 'chromium bisect' script.
2. Tried performing 'per revision' bisect on multiple Windows, Mac and Linux machines but unable to perform the same since getting following error:
   (a) Error message on Windows and Linux OS : Unable to find locale data files
   (b) Error message on Mac OS:[Errno 2] No such file or directory error message
3. Unable to perform 'chromium bisect' script as issue is not reproducible on chromium builds. 

Thank You!
 
ActualVideo.mp4
792 KB View Download
ExpectedVideo.mp4
428 KB View Download
Labels: ReleaseBlock-Stable
Adding RB label, please edit or remove if it is not the case.
Tested with 70.0.3538.35, and the add shortcut error message is working as expected in local NTP. Support for remote NTP is still rolling out, however. Is the Actual screencast using remote NTP?
Update w.r.t comment #2,

Yes, the attached Actual screencast is using remote NTP.
Friendly ping! Could you please provide any update on this issue as it has been marked as a stable blocker.

Thank You!
[bulk edit] - This issue is marked as a stable blocker for M70. We are two weeks away from M70 Stable. Please take a look urgently!
Status: Fixed (was: Assigned)
Apologies for the delay, the fix has completed rolling out. Please go ahead and verify. Thanks!
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-70; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-70 label, otherwise remove Merge-TBD label. Thanks.
Labels: -Merge-TBD
Labels: -ReleaseBlock-Stable

Sign in to add a comment