New issue
Advanced search Search tips

Issue 889776 link

Starred by 2 users
Status: Fixed
Owner:
hashimoto@chromium.org
Closed: Oct 12
Cc:
apronin@chromium.org
mnissler@chromium.org
hidehiko@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Walk through Cryptohome related autotest.

Project Member Reported by hidehiko@chromium.org, Sep 27 
We have many platform_Cryptohome* prefixed tests for cryptohome (both client and server tests).
However, only a few look running continuously:

platform_CryptohomeChangePassword
platform_CryptohomeLECredentialManagerServer (Note: continuously failing)
platform_CryptohomeTestAuth
platform_CryptohomeTpmLiveTestServer

The main reason seems that missing or unexpectedly configured ATTRIBUTES fields in control file.

Maybe it's nice to walk through them to see what are running, what should run, and what should be removed.

If it's better to add some to CQ, then it's better to add bvt-perbuild first to see its trajectory, then move them to bvt-cq or bvt-inline.

Comment 1 by hidehiko@chromium.org, Sep 27 

One more:
- login_CryptohomeOwnerQuery

Note that others look running:
- login_Cryptohome
- login_CryptohomeDataLeak
- login_CryptohomeIncognito

Comment 2 by zalcorn@chromium.org, Sep 28 

Triage nag: This Chrome OS bug has an owner but no component. Please add a component so that this can be tracked by the relevant team.

Comment 3 by hashimoto@chromium.org, Oct 1

Components: Tests
The attribute in the control file of login_CryptohomeOwnerQuery is "suite:experimental".
On which bots is this test running?

Comment 4 by derat@chromium.org, Oct 1

Cc: apronin@chromium.org mnissler@chromium.org
Components: OS>Systems

Comment 5 by hashimoto@chromium.org, Oct 9 

Run test_that "e:.*ryptohome.*" locally, and all tests are passing except CryptohomeSyncStressServer.
I'll make a CL to add these tests to bvt-perbuild.
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/9a17ee576699f1e9078d762d700a818a4c31b446

commit 9a17ee576699f1e9078d762d700a818a4c31b446
Author: Ryo Hashimoto <hashimoto@google.com>
Date: Wed Oct 10 16:44:58 2018

autotest-tests-cryptohome: Add existing tests

BUG= chromium:889776 
TEST=None

Change-Id: I57c3340d222164aa7d2fcb6f1e23f457e7e55b0d
Reviewed-on: https://chromium-review.googlesource.com/1270542
Commit-Ready: Ryo Hashimoto <hashimoto@chromium.org>
Tested-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Shuhei Takahashi <nya@chromium.org>

[modify] https://crrev.com/9a17ee576699f1e9078d762d700a818a4c31b446/chromeos-base/autotest-tests-cryptohome/autotest-tests-cryptohome-9999.ebuild
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/17e78ed98a9aebebd95ec15de9d6f25ff5ee93f5

commit 17e78ed98a9aebebd95ec15de9d6f25ff5ee93f5
Author: Ryo Hashimoto <hashimoto@google.com>
Date: Wed Oct 10 16:44:58 2018

Add cryptohome-related tests to suite:bvt-perbuild

Add all tests which contain "Cryptohome" in their names except
CryptohomeSyncStressServer which fails.

BUG= chromium:889776 
TEST=None
CQ-DEPEND=CL:1270542

Change-Id: Iae39784c40a584a9d43f4fc4add42f8156e06ba6
Reviewed-on: https://chromium-review.googlesource.com/1270616
Commit-Ready: Ryo Hashimoto <hashimoto@chromium.org>
Tested-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Shuhei Takahashi <nya@chromium.org>

[modify] https://crrev.com/17e78ed98a9aebebd95ec15de9d6f25ff5ee93f5/client/site_tests/platform_CryptohomeStress/control.surfing
[modify] https://crrev.com/17e78ed98a9aebebd95ec15de9d6f25ff5ee93f5/server/site_tests/platform_CryptohomeTPMReOwnServer/control
[modify] https://crrev.com/17e78ed98a9aebebd95ec15de9d6f25ff5ee93f5/client/site_tests/platform_CryptohomeBadPerms/control
[modify] https://crrev.com/17e78ed98a9aebebd95ec15de9d6f25ff5ee93f5/client/site_tests/platform_CryptohomeNonDirs/control
[modify] https://crrev.com/17e78ed98a9aebebd95ec15de9d6f25ff5ee93f5/client/site_tests/platform_CryptohomeFio/control.dirty_setting
[modify] https://crrev.com/17e78ed98a9aebebd95ec15de9d6f25ff5ee93f5/client/site_tests/platform_CryptohomeMigrateKey/control
[modify] https://crrev.com/17e78ed98a9aebebd95ec15de9d6f25ff5ee93f5/client/site_tests/platform_CryptohomeStress/control
[modify] https://crrev.com/17e78ed98a9aebebd95ec15de9d6f25ff5ee93f5/server/site_tests/platform_CryptohomeMigrateChapsToken/control
[modify] https://crrev.com/17e78ed98a9aebebd95ec15de9d6f25ff5ee93f5/client/site_tests/platform_CryptohomeKeyEviction/control
[modify] https://crrev.com/17e78ed98a9aebebd95ec15de9d6f25ff5ee93f5/client/site_tests/platform_CryptohomeMultiple/control
[modify] https://crrev.com/17e78ed98a9aebebd95ec15de9d6f25ff5ee93f5/client/site_tests/platform_CryptohomeFio/control.stress
[modify] https://crrev.com/17e78ed98a9aebebd95ec15de9d6f25ff5ee93f5/client/site_tests/platform_CryptohomeMount/control
[modify] https://crrev.com/17e78ed98a9aebebd95ec15de9d6f25ff5ee93f5/client/site_tests/platform_CryptohomeFio/control
[modify] https://crrev.com/17e78ed98a9aebebd95ec15de9d6f25ff5ee93f5/client/site_tests/platform_CryptohomeGetEnrollmentId/control
[modify] https://crrev.com/17e78ed98a9aebebd95ec15de9d6f25ff5ee93f5/client/site_tests/login_CryptohomeOwnerQuery/control
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/21e36d63267759a18a2993e0494c58e78831c025

commit 21e36d63267759a18a2993e0494c58e78831c025
Author: Ryo Hashimoto <hashimoto@google.com>
Date: Thu Oct 11 20:25:58 2018

Remove platform_CryptohomeSyncStressServer

AFAIK no one is running this test which requires a special power strip
device.
(Please feel free to revert this change if there is anyone who needs
this test.)

Also remove the power_strip utility whose only user is this test.

BUG= chromium:889776 
TEST=None

Change-Id: I33df32f1e7ee0a1933e889738c3901ec7321997b
Reviewed-on: https://chromium-review.googlesource.com/1273236
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Shuhei Takahashi <nya@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>

[delete] https://crrev.com/bd5391adf559d5a93585e4e9876cb5697c3ee194/client/site_tests/platform_CryptohomeSyncStress/control
[delete] https://crrev.com/bd5391adf559d5a93585e4e9876cb5697c3ee194/client/cros/power/power_strip.py
[delete] https://crrev.com/bd5391adf559d5a93585e4e9876cb5697c3ee194/client/site_tests/platform_CryptohomeSyncStress/platform_CryptohomeSyncStress.py
[delete] https://crrev.com/bd5391adf559d5a93585e4e9876cb5697c3ee194/server/site_tests/platform_CryptohomeSyncStressServer/platform_CryptohomeSyncStressServer.py
[delete] https://crrev.com/bd5391adf559d5a93585e4e9876cb5697c3ee194/server/site_tests/platform_CryptohomeSyncStressServer/control

Comment 9 by hashimoto@chromium.org, Oct 12

Status: Fixed (was: Assigned)
Now all tests are run by bots.
►

Sign in to add a comment