New issue
Advanced search Search tips

Issue 889768 link

Starred by 4 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

VDA: Failed to play VP9 testing stream with intra_only

Project Member Reported by akahuang@chromium.org, Sep 27

Issue description

Currently both slice V4L2 VDA and Vaapi VDA cannot handle the test stream with intra_only flag correctly. This testing stream comes from Android CTS. 

I haven't found what the root cause is.
 
Can you please share the stream?
vp90_2_16_intra_only.vp9.ivf
32 bytes Download
Is it a real stream at all? :)
32bytes means,only ivf header , no frame in it!
Oops maybe I failed to convert the format. The original stream is this.
vp90_2_16_intra_only.vp9
171 KB Download
Thanks for sharing the video sample. Interestingly this reveals multiple issues in vp9 decoder implementation (VDA path). I will provide a couple of fixes.

BTW, One of the issue is related with this: https://bugs.chromium.org/p/chromium/issues/detail?id=832264
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cecd07c128d36d28b12046878c44cda3c8b6e09e

commit cecd07c128d36d28b12046878c44cda3c8b6e09e
Author: Sreerenj Balachandran <sreerenj.balachandran@intel.com>
Date: Wed Nov 21 06:56:06 2018

media/filters: Relax the vp9 colorspace matching restriction

For the Intra only frames in profile0, we assign the default
color_space :BT_601 as per the spec. But there are lazily encoded
streams with UNKNOWN color space information in non-intra-only frames
and that will cause enum comparison mismatch for the current frame header
with the frame in the reference list. So we relax the requirement
a bit to cover more streams similar to the other media stacks like
libvpx, gstreamer etc

BUG=889768
R=dalecurtis@chromium.org, hiroh@chromium.org

Change-Id: I5c343d03a941a3aa1447d4f0d3cd4979b92c4adb
Reviewed-on: https://chromium-review.googlesource.com/c/1342776
Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609929}
[modify] https://crrev.com/cecd07c128d36d28b12046878c44cda3c8b6e09e/media/filters/vp9_uncompressed_header_parser.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Nov 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/571633057a915e7eb7b3c552a5757f0176a0c8d3

commit 571633057a915e7eb7b3c552a5757f0176a0c8d3
Author: Sreerenj Balachandran <sreerenj.balachandran@intel.com>
Date: Wed Nov 28 02:45:57 2018

media/gpu: fix the vp9 decode when the stream starts with an Intra only frame

Current implementation allows only a keyframe as the first frame in the
stream. This patch relaxes the requiremnt a bit and legalize the decoding
when it starts with an Intra only frame. Also allows the resolution
change if there is no prior decoded frames and the current frame is an
intra only one.

BUG=889768

Change-Id: Ic3bdedc329072b473f057407101193ac7ba4dc09
Reviewed-on: https://chromium-review.googlesource.com/c/1341146
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611532}
[modify] https://crrev.com/571633057a915e7eb7b3c552a5757f0176a0c8d3/media/gpu/vp9_decoder.cc

Status: Assigned (was: Untriaged)
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this.

Sign in to add a comment