Remove v8_context_snapshot_generator from fuzzer builds |
||
Issue descriptionv8_context_snapshot_generator binary is too large to be archived in libFuzzer builds, see libfuzzer-linux-release-594553.zip, size of this file is 654mb which is crazy and then ClusterFuzz tries to check if it is a fuzzer by checking file contents, see bug 865732 Looks like this is regression from https://chromium.googlesource.com/chromium/src/+/8b6254d72354e61e9976d1b0817477689ec9eec7 v8_context_snapshot.bin is small (745kb), but v8_context_snapshot_generator is huge. peria@, is there a way in gn to avoid adding this binary in out/ folder. If not, Is this file any useful to archive on buildbots, maybe should be excluded in https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/archive/resources/filter_build_files.py?q=filter_build_files.py&sq=package:chromium&dr thoughts?
,
Sep 27
We don't need to archive this generator. Having .bin is enough. I'll update the filter to exclude it.
,
Sep 27
Thanks, that sounds good.
,
Sep 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/66af208afea0f93035b0637766f5d920e47a7712 commit 66af208afea0f93035b0637766f5d920e47a7712 Author: Hitoshi Yoshida <peria@chromium.org> Date: Fri Sep 28 09:00:57 2018 build: Exclude v8_context_snapshot_generator from archive v8_context_snapshot_generator makes v8_context_snapshot.bin, and the generator itself is not bundled in Chromium binary files. So we do not need to run the generator again, and we do not need to archive it. This CL excludes v8_context_snapshot from archived files, and reduces ~500MB (before compress) size. Bug: 889731 Change-Id: Ibc8b1935706655d2ff05dbb41bc0cb3f4ad56358 Reviewed-on: https://chromium-review.googlesource.com/1250621 Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> [modify] https://crrev.com/66af208afea0f93035b0637766f5d920e47a7712/scripts/slave/recipe_modules/archive/resources/filter_build_files.py
,
Sep 28
Thanks! |
||
►
Sign in to add a comment |
||
Comment 1 by infe...@chromium.org
, Sep 27