https://google.github.io/styleguide/cppguide.html#Namespace_Names
> > Namespace names are all lower-case.
//third_party/blink/ has many sub-namespaces with non-lowercase names.
e.g. *Names, WTF, WTF::Unicode, FrameTestHelpers, ColorSpaceUtilities, TouchAdjustment, Encoding, LayoutInvalidationReason, VectorMath, VectorMath::AVX, VectorMath::SSE, URLTestHelpers, AudioUtilities, StyleChangeReason, ListMaerkerText, CSSLongand, CSSShorthand
We should rename them to lower-case.
> Hi, Can I try this?
Please go ahead!
I recommend to declare what you will change in this issue when you start to make a patch. e.g. "I'll take blink::AudioUtilities."
FooNames:: is ready to be lowercased.
* For foo_tag_names.json5 and foo_attribute_names.json5:
- Drop 'FOO' from make_qualified_names.py:94
- Update C++ code
- Update audit_non_blink_usage.py
* For other foo_names.json5:
- Update the 'namespace' field in foo_names.json5 like:
namespace: "InputType" ==> namespace: "input_type_names"
- Update C++ code
- Update audit_non_blink_usage.py
#c94, "CSS" is for WebIDL, which is unrelated to this issue, and I think we should not change inspector protocol. Yeah, we have completed this task. Thank you for helping this!
Comment 1 by bugdroid1@chromium.org
, Sep 27