New issue
Advanced search Search tips

Issue 889722 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: ----
Type: Bug



Sign in to add a comment

CHECK failure: (data_) != nullptr in js-heap-broker.h

Project Member Reported by ClusterFuzz, Sep 27

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5805956104192000

Fuzzer: mbarbella_js_mutation
Job Type: windows_asan_d8_dbg
Platform Id: windows

Crash Type: CHECK failure
Crash Address: 
Crash State:
  (data_) != nullptr in js-heap-broker.h
  v8::platform::PrintStackTrace
  v8::internal::compiler::NativeContextRef::script_context_table
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_d8_dbg&range=55579:55580

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5805956104192000

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Sep 27

Labels: Test-Predator-Auto-Owner
Owner: neis@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/v8/v8/+/1075e6a0ec1b6ce33cc517413a1ecd113567d933 ([turbofan] Cleanup JSFunction and NativeContext serialization.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Cc: jarin@chromium.org
Labels: -Type-Bug-Security Type-Bug
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 27

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/bcbb6d9eb492646f11391a9200af513d82386ef1

commit bcbb6d9eb492646f11391a9200af513d82386ef1
Author: Georg Neis <neis@chromium.org>
Date: Thu Sep 27 10:22:51 2018

[turbofan] Prepare broker for the next steps.

- Add a new broker mode kRetired, in which the heap can
  again be accessed.
- Change the way modes work. We now always start in kDisabled.
  If FLAG_concurrent_compiler_frontend is on, we eventually move
  to kSerializing, then to kSerialized, then to kRetired.
- Add an ObjectDataKind to ObjectData that indicates whether the
  data is just a dummy (i.e. created while broker was in kDisabled
  mode).

This also happens to fix a bug found by clusterfuzz.

Bug: v8:7790,  chromium:889722 
Change-Id: I38833fe7ad26d2d3efb15ba560576defb82f673a
Reviewed-on: https://chromium-review.googlesource.com/1245425
Commit-Queue: Georg Neis <neis@chromium.org>
Reviewed-by: Maya Lekova <mslekova@chromium.org>
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56260}
[modify] https://crrev.com/bcbb6d9eb492646f11391a9200af513d82386ef1/src/compiler/js-heap-broker.cc
[modify] https://crrev.com/bcbb6d9eb492646f11391a9200af513d82386ef1/src/compiler/js-heap-broker.h
[modify] https://crrev.com/bcbb6d9eb492646f11391a9200af513d82386ef1/src/compiler/pipeline.cc
[add] https://crrev.com/bcbb6d9eb492646f11391a9200af513d82386ef1/test/mjsunit/regress/regress-889722.js
[modify] https://crrev.com/bcbb6d9eb492646f11391a9200af513d82386ef1/test/unittests/compiler/graph-unittest.cc
[modify] https://crrev.com/bcbb6d9eb492646f11391a9200af513d82386ef1/test/unittests/compiler/js-create-lowering-unittest.cc

Project Member

Comment 6 by ClusterFuzz, Sep 28

ClusterFuzz has detected this issue as fixed in range 56259:56260.

Detailed report: https://clusterfuzz.com/testcase?key=5805956104192000

Fuzzer: mbarbella_js_mutation
Job Type: windows_asan_d8_dbg
Platform Id: windows

Crash Type: CHECK failure
Crash Address: 
Crash State:
  (data_) != nullptr in js-heap-broker.h
  v8::platform::PrintStackTrace
  v8::internal::compiler::NativeContextRef::script_context_table
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_d8_dbg&range=55579:55580
Fixed: https://clusterfuzz.com/revisions?job=windows_asan_d8_dbg&range=56259:56260

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5805956104192000

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Sep 28

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 5805956104192000 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 8 by sheriffbot@chromium.org, Sep 28

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 9 by sheriffbot@chromium.org, Jan 4

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment