New issue
Advanced search Search tips

Issue 889701 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: WebRequestUnresponsiveListenerTest.WebRequestListenerNeverResponds



Sign in to add a comment

WebRequestUnresponsiveListenerTest.WebRequestListenerNeverResponds/* is flaky

Project Member Reported by Findit, Sep 27

Issue description


Flaky test: WebRequestUnresponsiveListenerTest.WebRequestListenerNeverResponds/0
Sample failed build due to flakiness: https://chromium-swarm.appspot.com/task?id=4031453fff741810
Test output log: https://ci.chromium.org/buildbot/chromium.win/Win%207%20Tests%20x64%20%281%29/43524
Culprit (100.0% confidence): https://chromium-review.googlesource.com/q/Id918d6d5f7bf5d8235f1386ef48838bffaa1b50c
Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy2AELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKhAWNocm9taXVtLndpbi9XaW4gNyBUZXN0cyB4NjQgKDEpLzQzNTI0L25ldHdvcmtfc2VydmljZV9icm93c2VyX3Rlc3RzL1YyVmlVbVZ4ZFdWemRGVnVjbVZ6Y0c5dWMybDJaVXhwYzNSbGJtVnlWR1Z6ZEM1WFpXSlNaWEYxWlhOMFRHbHpkR1Z1WlhKT1pYWmxjbEpsYzNCdmJtUnpMekE9DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw

Please revert the culprit, or disable the test and find the appropriate owner.

If the culprit above is wrong, please file a bug using this link:
https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20WebRequestUnresponsiveListenerTest.WebRequestListenerNeverResponds/0&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy2AELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKhAWNocm9taXVtLndpbi9XaW4gNyBUZXN0cyB4NjQgKDEpLzQzNTI0L25ldHdvcmtfc2VydmljZV9icm93c2VyX3Rlc3RzL1YyVmlVbVZ4ZFdWemRGVnVjbVZ6Y0c5dWMybDJaVXhwYzNSbGJtVnlWR1Z6ZEM1WFpXSlNaWEYxWlhOMFRHbHpkR1Z1WlhKT1pYWmxjbEpsYzNCdmJtUnpMekE9DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a0b3647919257319e4f6607a285c907bda90736

commit 5a0b3647919257319e4f6607a285c907bda90736
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Thu Sep 27 01:07:32 2018

Revert "[Extensions] Add a test for webRequestBlocking listeners that are killed"

This reverts commit dee92446f78ac70361de59ae224939be8f82398f.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 594509 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZGVlOTI0NDZmNzhhYzcwMzYxZGU1OWFlMjI0OTM5YmU4ZjgyMzk4Zgw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win%207%20Tests%20x64%20%281%29/43524

Sample Failed Step: network_service_browser_tests

Sample Flaky Test: WebRequestUnresponsiveListenerTest.WebRequestListenerNeverResponds/0

Original change's description:
> [Extensions] Add a test for webRequestBlocking listeners that are killed
> 
> Add a test that exercises behavior for a webRequestBlocking listener
> that never returns, and then the tab is closed. Do this with two
> flavors:
> - A listener in the extension's background page, where the
>   RenderProcessHost is shutdown.
> - A listener in an extension tab, which is then closed.
> 
> Verify that in both cases, navigation is unblocked when the extension
> listener goes away.
> 
> Inspired by, but not in any way a fix for,  https://crbug.com/877543 .
> 
> Change-Id: Id918d6d5f7bf5d8235f1386ef48838bffaa1b50c
> Reviewed-on: https://chromium-review.googlesource.com/1188942
> Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
> Reviewed-by: Nasko Oskov <nasko@chromium.org>
> Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#594509}

Change-Id: I2c9ebb07e448747ca7f83e51470e1d5e96edc9bd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 889701
Reviewed-on: https://chromium-review.googlesource.com/1247527
Cr-Commit-Position: refs/heads/master@{#594550}
[modify] https://crrev.com/5a0b3647919257319e4f6607a285c907bda90736/chrome/browser/extensions/api/web_request/web_request_apitest.cc
[modify] https://crrev.com/5a0b3647919257319e4f6607a285c907bda90736/extensions/browser/api/web_request/web_request_api.cc
[modify] https://crrev.com/5a0b3647919257319e4f6607a285c907bda90736/extensions/browser/api/web_request/web_request_api.h

Project Member

Comment 2 by Findit, Sep 27


Flaky test: WebRequestUnresponsiveListenerTest.WebRequestListenerNeverResponds/1
Test output log: https://chromium-swarm.appspot.com/task?id=40314c6bfbf63110
Findit identified the culprit r594509 with confidence 100.0% for the example failed
build https://ci.chromium.org/buildbot/chromium.win/Win%207%20Tests%20x64%20%281%29/43525 based on the flakiness trend:

https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy2AELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKhAWNocm9taXVtLndpbi9XaW4gNyBUZXN0cyB4NjQgKDEpLzQzNTI1L25ldHdvcmtfc2VydmljZV9icm93c2VyX3Rlc3RzL1YyVmlVbVZ4ZFdWemRGVnVjbVZ6Y0c5dWMybDJaVXhwYzNSbGJtVnlWR1Z6ZEM1WFpXSlNaWEYxWlhOMFRHbHpkR1Z1WlhKT1pYWmxjbEpsYzNCdmJtUnpMekU9DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw

If the culprit above is wrong, please file a bug using this link:
https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20WebRequestUnresponsiveListenerTest.WebRequestListenerNeverResponds/1&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy2AELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKhAWNocm9taXVtLndpbi9XaW4gNyBUZXN0cyB4NjQgKDEpLzQzNTI1L25ldHdvcmtfc2VydmljZV9icm93c2VyX3Rlc3RzL1YyVmlVbVZ4ZFdWemRGVnVjbVZ6Y0c5dWMybDJaVXhwYzNSbGJtVnlWR1Z6ZEM1WFpXSlNaWEYxWlhOMFRHbHpkR1Z1WlhKT1pYWmxjbEpsYzNCdmJtUnpMekU9DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw

Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Project Member

Comment 3 by Findit, Sep 27


Flaky test: WebRequestUnresponsiveListenerTest.WebRequestListenerNeverResponds/0
Test output log: https://chromium-swarm.appspot.com/task?id=403164c8b507d610
Findit identified the culprit r594509 with confidence 100.0% for the example failed
build https://ci.chromium.org/buildbot/chromium.linux/linux-xenial-rel/3647 based on the flakiness trend:

https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy5gELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKvAWNocm9taXVtLmxpbnV4L2xpbnV4LXhlbmlhbC1yZWwvMzY0Ny9uZXR3b3JrX3NlcnZpY2VfYnJvd3Nlcl90ZXN0cyBvbiBVYnVudHUtMTYuMDQvVjJWaVVtVnhkV1Z6ZEZWdWNtVnpjRzl1YzJsMlpVeHBjM1JsYm1WeVZHVnpkQzVYWldKU1pYRjFaWE4wVEdsemRHVnVaWEpPWlhabGNsSmxjM0J2Ym1Sekx6QT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA

If the culprit above is wrong, please file a bug using this link:
https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20WebRequestUnresponsiveListenerTest.WebRequestListenerNeverResponds/0&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy5gELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKvAWNocm9taXVtLmxpbnV4L2xpbnV4LXhlbmlhbC1yZWwvMzY0Ny9uZXR3b3JrX3NlcnZpY2VfYnJvd3Nlcl90ZXN0cyBvbiBVYnVudHUtMTYuMDQvVjJWaVVtVnhkV1Z6ZEZWdWNtVnpjRzl1YzJsMlpVeHBjM1JsYm1WeVZHVnpkQzVYWldKU1pYRjFaWE4wVEdsemRHVnVaWEpPWlhabGNsSmxjM0J2Ym1Sekx6QT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA

Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Project Member

Comment 4 by Findit, Sep 27


Flaky test: WebRequestUnresponsiveListenerTest.WebRequestListenerNeverResponds/1
Test output log: https://chromium-swarm.appspot.com/task?id=403176583e208510
Findit identified the culprit r594509 with confidence 100.0% for the example failed
build https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%28dbg%29%281%29/71836 based on the flakiness trend:

https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy2AELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKhAWNocm9taXVtLndpbi9XaW43IFRlc3RzIChkYmcpKDEpLzcxODM2L25ldHdvcmtfc2VydmljZV9icm93c2VyX3Rlc3RzL1YyVmlVbVZ4ZFdWemRGVnVjbVZ6Y0c5dWMybDJaVXhwYzNSbGJtVnlWR1Z6ZEM1WFpXSlNaWEYxWlhOMFRHbHpkR1Z1WlhKT1pYWmxjbEpsYzNCdmJtUnpMekU9DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw

If the culprit above is wrong, please file a bug using this link:
https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20WebRequestUnresponsiveListenerTest.WebRequestListenerNeverResponds/1&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy2AELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKhAWNocm9taXVtLndpbi9XaW43IFRlc3RzIChkYmcpKDEpLzcxODM2L25ldHdvcmtfc2VydmljZV9icm93c2VyX3Rlc3RzL1YyVmlVbVZ4ZFdWemRGVnVjbVZ6Y0c5dWMybDJaVXhwYzNSbGJtVnlWR1Z6ZEM1WFpXSlNaWEYxWlhOMFRHbHpkR1Z1WlhKT1pYWmxjbEpsYzNCdmJtUnpMekU9DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw

Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Labels: -Sheriff-Chromium
Owner: rdevlin....@chromium.org
Status: Assigned (was: Untriaged)
Devlin, please have a look.

Sign in to add a comment