New issue
Advanced search Search tips

Issue 889694 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Sep 28
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove BaseAudioContext::suspendContext

Project Member Reported by rtoy@chromium.org, Sep 27 
BaseAudioContext defines a virtual suspendContext() method.  This should be removed because there's no corresponding method in BaseAudioContext idl and because the idl suspend() methods are unrelated.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/611030c89e0e6b2f65d091d99bde1bae45991adf

commit 611030c89e0e6b2f65d091d99bde1bae45991adf
Author: Raymond Toy <rtoy@chromium.org>
Date: Thu Sep 27 19:18:52 2018

Remove BaseAudioContext::suspendContext()

This virtual method is not needed.  The derived classes don't all
support this method, and indeed it is invalid for an
OfflineAudioContext because the offline context requires a time
argument.

Bug:  889694 
Test: internal change
Change-Id: I9ee9aa6279693f90b4a91bfa34f3f584e5f3654d
Reviewed-on: https://chromium-review.googlesource.com/1247683
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594809}
[modify] https://crrev.com/611030c89e0e6b2f65d091d99bde1bae45991adf/third_party/blink/renderer/modules/webaudio/audio_context.h
[modify] https://crrev.com/611030c89e0e6b2f65d091d99bde1bae45991adf/third_party/blink/renderer/modules/webaudio/base_audio_context.h
[modify] https://crrev.com/611030c89e0e6b2f65d091d99bde1bae45991adf/third_party/blink/renderer/modules/webaudio/offline_audio_context.cc
[modify] https://crrev.com/611030c89e0e6b2f65d091d99bde1bae45991adf/third_party/blink/renderer/modules/webaudio/offline_audio_context.h

Comment 2 by rtoy@chromium.org, Sep 28

Status: Fixed (was: Available)
►

Sign in to add a comment